summaryrefslogtreecommitdiff
path: root/src/lib/eet
diff options
context:
space:
mode:
authorJean-Philippe Andre <jp.andre@samsung.com>2016-07-13 15:44:58 +0900
committerJean-Philippe Andre <jp.andre@samsung.com>2016-07-13 15:44:58 +0900
commit1b6825d3fef6307b5bd93b7160b97dcae0143f73 (patch)
treefcbd40913b9a91a6dfe0852617c6407eac03e8c6 /src/lib/eet
parentcdc8d15a5ca0eb478882e670af89fa914ffec8ce (diff)
edje: Fix coverity warning
CID 1355234 Logically dead code The indicated dead code may have performed some action; that action will never occur. In eet_data_descriptor_element_add: Code can never be reached because of a logical contradiction (CWE-561) Solution: use explicit range within valid values with <= and >= rather than excluded values with > and <
Diffstat (limited to 'src/lib/eet')
-rw-r--r--src/lib/eet/eet_data.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/lib/eet/eet_data.c b/src/lib/eet/eet_data.c
index 0df96afac8..35ef7fb6ca 100644
--- a/src/lib/eet/eet_data.c
+++ b/src/lib/eet/eet_data.c
@@ -2223,9 +2223,8 @@ eet_data_descriptor_element_add(Eet_Data_Descriptor *edd,
2223 */ 2223 */
2224 if ((group_type > EET_G_UNKNOWN) 2224 if ((group_type > EET_G_UNKNOWN)
2225 && (group_type < EET_G_LAST) 2225 && (group_type < EET_G_LAST)
2226 && (((type > EET_T_UNKNOW) && (type < EET_T_STRING)) 2226 && (((type >= EET_T_CHAR) && (type <= EET_T_ULONG_LONG))
2227 || ((type > EET_T_NULL) && (type < EET_T_VALUE)) 2227 || ((type >= EET_T_F32P32) && (type <= EET_T_F8P24)))
2228 || ((type > EET_T_VALUE) && (type < EET_T_LAST)))
2229 && (!subtype)) 2228 && (!subtype))
2230 { 2229 {
2231 subtype = calloc(1, sizeof (Eet_Data_Descriptor)); 2230 subtype = calloc(1, sizeof (Eet_Data_Descriptor));