diff options
author | Marcel Hollerbach <marcel-hollerbach@t-online.de> | 2015-11-21 15:17:47 +0100 |
---|---|---|
committer | Marcel Hollerbach <marcel-hollerbach@t-online.de> | 2015-11-25 09:35:07 +0100 |
commit | 7b9bb510b4a6d00e33e9fd897810f950c64752ba (patch) | |
tree | 4913ce7d4f5d34fc2f778c0e267b2e102233db6f /src/lib/efreet/efreet_icon.c | |
parent | 8ccea8233c144f723470da09a01487484c269440 (diff) |
efreet_icon: Fix wrong inherit selection
Summary:
The list of elem->paths is given with the actual icon at position 0 and
the bigger the index is the lower the icon in the inherit structure is.
Due to the for loop beginning at 0 walking to the end this
direction is flipped. So the last r is returned, which is the lowest
icon in the inherit structure.
This is fixed by returning if the first valid path is found.
@fix
Test Plan: run jesus or efm with a custom icon theme beore the wrong icons are taken, now the correct ones are taken
Reviewers: raster, cedric
Subscribers: DaveMDS
Differential Revision: https://phab.enlightenment.org/D3366
Diffstat (limited to '')
-rw-r--r-- | src/lib/efreet/efreet_icon.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/lib/efreet/efreet_icon.c b/src/lib/efreet/efreet_icon.c index 89805201a4..6b02bfb19d 100644 --- a/src/lib/efreet/efreet_icon.c +++ b/src/lib/efreet/efreet_icon.c | |||
@@ -714,6 +714,8 @@ efreet_icon_lookup_path_path(Efreet_Cache_Icon_Element *elem, const char *path) | |||
714 | r = elem->paths[i]; | 714 | r = elem->paths[i]; |
715 | break; | 715 | break; |
716 | } | 716 | } |
717 | if (r) | ||
718 | break; | ||
717 | } | 719 | } |
718 | 720 | ||
719 | free((void*) path); | 721 | free((void*) path); |