path: root/src/lib/efreet (follow)
AgeCommit message (Collapse)Author
2014-09-18efreet: Store known desktop environmentsSebastian Dransfeld
2014-08-14make indenting consistentCarsten Haitzler (Rasterman)
this doesnt mean its right - it just matches. efreet needs some indent love.
2014-08-14efreet: replace 4096 with sizeof(buf) in snprintf(buf, 4096, ...).Adrien Nader
buf is a local variable defined as: char buf[4096]; The current code is correct; this change only makes sure the value won't get out-of-sync later on.
2014-08-14efreet: reverse if's condition and swap then/else blocks for readabilityAdrien Nader
The reversal makes it possible to merge two #if and unspaghetti the code a bit. Since the diff is not very readable, here is the before/after to show the spirit: before: #if cond if (...) #endif do_foo(); #if cond else do_bar(); #endif after: #if cond if ( ! ...) do_bar(); else #endif do_foo();
2014-08-14efreet: remove #ifdef GETUID inside #ifdef _WIN32 (it's always false).Adrien Nader
2014-08-14efreet: use eina_file_mkstemp to create filenameSebastian Dransfeld
2014-08-14efreet: remove creation of XDG_RUNTIME_DIRSebastian Dransfeld
XDG_RUNTIME_DIR should be created and set by the system, not a library.
2014-07-23efreet - add menu ref/unref calls and refcounting to try solve e issueCarsten Haitzler (Rasterman)
not much more to say really... efreet_menu_free now unrefs nd checks for 0 refcount first... unref just calls it to be "nice" @feature
2014-06-19Efreet: Fix shadow warningJean-Philippe Andre
2014-06-11efreet: improve handling of merged menusSebastian Dransfeld
If the menu is of the format ${XDG_MENU_PREFIX}, we want to merge applications-merged/, not ${XDG_MENU_PREFIX}applications-merged
2014-06-11efreet: remove code duplicationSebastian Dransfeld
If the menu starts with either kde- or gnome- the resulting action is the same.
2014-06-10efreet: Correctly handle default merge dirSebastian Dransfeld
When main menu file is or, we should be using applications as base for merged dir. Part of T1284
2014-05-19efreet: Fix mistakenly inverted behavior in URI handlingKai Huuhko
Fixes a mistake in commit 78c9a82a142f619ccd0957957351fe0e573de76c The authority part would get placed in the struct member "path", and vice versa. Lesson learned: Don't rewrite your patch late at night after arc has messed it up.
2014-05-19efreet: Handle URIs in a more generic wayKai Huuhko
Summary: Fixes T1219 Reviewers: englebass CC: cedric Maniphest Tasks: T1219 Differential Revision:
2014-04-17efreet: check magic only for file which has sizeWonguk Jeong
Summary: Due to unnecessary magic checking, there was freezing in /proc in efm. Proc file's st_size is zero, but, it's readable. therfore, it takes unnecessary time in magic checking. And, there is no need to check magic in case of 0 sized regular files as well. Therefore, skip magic check in case of st_size is zero. Fixes T1173 Test Plan: enlightenment -> file browser (efm) -> get int /proc --> check whether efm freezes or not Reviewers: raster, cedric, zmike CC: seoz, cedric Maniphest Tasks: T1173 Differential Revision: Signed-off-by: Cedric Bail <>
2014-04-10"whether" has 2x 'h'Mike Blumenkrantz
2014-01-09efreet: fix build on windows by matching the #if around the if statement.Cedric BAIL
2014-01-08fix mingw build for setuid fix/checksCarsten Haitzler (Rasterman)
2014-01-08setuid safeness - ensure if an app that is setuid doesn't do bad thingsCarsten Haitzler (Rasterman)
this makes efl ignore certain env vars for thnigs and entirely removes user modules (that no one ever used) etc. etc. to ensure that *IF* an app is setuid, there isn't a priv escalation path that is easy.
2014-01-01Fix documentation for efreet_desktop_exec().Guillaume Friloux
2014-01-01Fix documentation for efreet_desktop_environment_get().Guillaume Friloux
2014-01-01Simplify code of efreet_desktop_environment_set().Guillaume Friloux
2013-12-26efl: Unified eina critical manro to CRI.Daniel Juyung Seo
Being annoyed by different types of eina critical macros - CRI, CRIT, CRITICAL -, I concluded to unify them to one. Discussed on IRC and finally, CRI was chosen to meet the consistency with other macros - ERR, WRN, INF, DBG - in terms of the number of characters. If there is any missing bits, please let me know.
2013-11-29efreet: improve lockingSebastian Dransfeld
Do find and ref inside lock, so no one can ref-- after we find desktop
2013-11-21efreet: Only lock once for efficiencySebastian Dransfeld
2013-11-21efreet: TODO++Sebastian Dransfeld
2013-11-21efreet: store volatile value locally before returnSebastian Dransfeld
2013-11-04alpha1 release autofoo/build tree work to pass distcheck and actually workv1.8.0-alpha1Carsten Haitzler (Rasterman)
2013-10-14efreet: Check buffer sizeSebastian Dransfeld
CID 1039582, 1039583
2013-10-14efreet: Always '\0' terminate bufSebastian Dransfeld
CID 1039721
2013-08-07efreet: Fix buffer overrun, leave space for '\0'Sebastian Dransfeld
CID: #1039304, #1039305 and #1039306
2013-08-07efreet: be paranoid about '\0' terminationSebastian Dransfeld
CID: #1039721
2013-08-07efreet: formattingSebastian Dransfeld
2013-08-07efreet: clean up ugly internal_get functionSebastian Dransfeld
CID: #1039186
2013-08-07efreet: Remove dead codeSebastian Dransfeld
CID: #1039942
2013-08-07efreet: Explicitly set num_pending to 0Sebastian Dransfeld
CID: #1039185
2013-08-07efreet: Check return value of eet_listSebastian Dransfeld
CID: #1039327
2013-08-07efreet: fgetc returns intSebastian Dransfeld
CID: #1039720
2013-08-07efreet: Check return value of chmodSebastian Dransfeld
CID: #1039690
2013-08-07efreet: Be paranoid about '\0' terminationSebastian Dransfeld
CID: #1039722
2013-08-07efreet: TODO++Sebastian Dransfeld
2013-08-06efreet: let's pass memset parameter in the right order.Cedric Bail
2013-08-05efreet_menu_move_free will free "move" here so remove the menu fromChris Michael
the parent's list Before we free the menu. Signed-off-by: Chris Michael <>
2013-08-05efreet: Fix allocated data sizeSebastian Dransfeld
Since we check for count < 10 and then add 1, we could get count == 11. Also set array memory to 0 in one command.
2013-08-05efreet: FormattingSebastian Dransfeld
2013-07-16fix clang sizeof complaintCarsten Haitzler (Rasterman)
2013-07-08Fix memleak reported by Coverity: Close the descriptor returned byChris Michael
popen if we are going to error out. NB: Fixes Coverity CID1039184 Signed-off-by: Chris Michael <>
2013-07-08Fix memleak reported by Coverity: If we fail to allocate a newChris Michael
internal menu, then free the previously allocated memory for xml file. NB: Fixed Coverity CID 1039183 Signed-off-by: Chris Michael <>
2013-07-08Fix mem leak reported by Coverity: If we fail to create a new internalChris Michael
menu, then free the previously allocated xml file. NB: Fixes Coverity CID 1039182 Signed-off-by: Chris Michael <>
2013-06-27efreet: always sanitize path.Cedric Bail