path: root/src/lib/elementary (follow)
AgeCommit message (Collapse)Author
2017-03-09elementary: avoid crash during shutdown due to Ecore_Event queue.Cedric BAIL
2017-03-09popup: hides the popup when hide effect is finishedTaehyub Kim
Summary: When popup hides and shows fast, sometimes popup is not shown because of the difference visible value between popup and notify (case: popup visible state: 1, popup_notify visible state: 0) To sync this value I added the visible set code in elc_popup.c @fix Test Plan: 1. run elementary_text -to popup 2. shows the hide popup 3. hides popup using the hide button 4. repeat 2,3 step 5. popup will be shown well Reviewers: jpeg, cedric, Hermet, raster Subscribers: Blackmole, woohyun Differential Revision:
2017-03-09multibuttonentry : fix box indicated item correctly in item_insert_before ↵JEONGHYUN YUN
and item_insert_after Summary: If user added item with item_insert_before and item_insert_after, item was not displayed. For this reason, fixed box indicated item correctly from reference->button to VIEW(reference). Additionally, remove the unused variable button in _Multibuttonentry_Item struct. Reviewers: woohyun, CHAN, cedric, jpeg Reviewed By: CHAN Subscribers: cedric, jpeg Differential Revision:
2017-03-08naviframe: keep unfocusable state of item before finishing item push/popYoungbok Shin
If item pop was started without focus at a naviframe object and the naviframe object got focus before finising item pop, the naviframe object could give focus to its first object of prev item. It could ruin focus orders and failed to restore previous focused object in the item. To keep consistency of focus policy, same logic will be applied to item push scenario. @fix Change-Id: Ia74bdce3620bd59622ef32a0cedf5fbd84815400
2017-03-06elementary: fix tests build.Cedric Bail
2017-03-04elm_code: Fix missing syntax for .eo filesAndy Williams
This was accidentally removed in the transition from edi. using text/x-eolian which is not well reported by the FS yet. @fix
2017-03-02genlist: Remove weird behavior about item_show, bring_inJiwon Kim
Summary: When if item_show / bring_in is proceeded as 'deferred_show' sequence, Scrollto_Type does not be checked perfectly. As a result, ELM_GENLIST_ITEM_SCROLLTO_NONE and any other integer values are worked such as ELM_GENLIST_ITEM_SCROLLTO_BRING_IN. As doxygen of Elm_Genlist_Item_Scrollto_Type, ELM_GENLIST_ITEM_SCROLLTO_NONE and other incorrect number should not work. Fixes T4854 @fix Reviewers: SanghyeonLee, woohyun, jpeg Reviewed By: jpeg Subscribers: id213sin, conr2d, cedric Maniphest Tasks: T4854 Differential Revision:
2017-02-28elm_cnp: allocate space for null terminator in _wl_targets_converterDerek Foreman
strcat needs room for a string terminator.
2017-02-28elementary: Don't update opaque/input regions if not visibleChris Michael
Small patch to reduce calls to setting opaque/input regions in wayland. Basically, if the window is not shown then there is no point in updating these regions until such time that the window is actually visible and the regions will get committed. ref T5226 @fix Signed-off-by: Chris Michael <>
2017-02-27elm_code: Hide the cursor when it is off screenAndy Williams
This resolves cursor artifacts that could be seen @fix
2017-02-27elementary: Fix issue of trying to init ecore_wl2 if DISPLAY is setChris Michael
Small patch to fix an issue that Derek brought up ... that is basically, if you try: WAYLAND_DEBUG=1 WAYLAND_DISPLAY=wayland-0 terminology while inside an X11 environment, then elm_config would try to initialize ecore_wl2 even when running under X11. @fix Signed-off-by: Chris Michael <>
2017-02-27elementary: Minor formatting fixChris Michael
NB: No functional changes Signed-off-by: Chris Michael <>
2017-02-27elementary: Don't set pointer object theme on startChris Michael
As we are already resetting the pointer object theme when we make a call to set the cursor, don't set it on window creation. This should address the issue of animators getting created on window creation. ref T5209 @fix Signed-off-by: Chris Michael <>
2017-02-27elementary tooltip: adjust arrow if tooltip was movedMinkyu Kang
Summary: If orientation is TOP, BOTTOM, LEFT and RIGHT and tooltip was moved due to located out of screen, adjust location of arrow so that can indicate right position. Signed-off-by: Minkyu Kang <> Test Plan: elementary_test -to tooltip4 Reviewers: cedric, Hermet, jpeg Subscribers: jpeg Differential Revision:
2017-02-27genlist: Final fix for odd/even styles issueJean-Philippe Andre
The key was to emit & process the signal to the edje objects (item views) at the same time as we move them, ie. from the loop in _item_block_position(). Also the proper counting must be used at all times. Hidden items should not be counted. Tree effect may still have issues but otherwise there is no more blinking, double odd or even rows, etc... It all looks good (as long as there is no tree effect!). Fixes T3086 @fix
2017-02-27genlist: Fix fileselector crazy behaviourJean-Philippe Andre
When using the fileselector in tree view mode (ie. expandable), expanding any folder with a lot of files in it would cause the genlist view to jump somewhere to the bottom. This is because the mechanism preventing the view from moving was assuming that all "prepend" operations meant prepending before the selected item. This is not the case in case of expansion like in the fileselector. @fix
2017-02-27genlist: Fix rare jump in prepend insertJean-Philippe Andre
If an item is selected, and another item is insert before the selected item, then we try to lock the genlist view (pan) around the selected item (if it's visible). Unfortunately, every 16 inserts cause a jump by one line in the scroller. That's because the scroll math assumes the block position is known, but since it's a new block it wasn't known. This patch fixes this issue by precalculating the block position. Test scenario: elementary_test -to "Genlist Tree, Insert Relative" Select an item, clikck 50 times on "+ before". The view should not jump. This does not fix fileselector's craziness. @fix
2017-02-27genlist: (Mostly) fix item index odd/even stylesJean-Philippe Andre
This fixes the internal item order index. Note that groups don't reset the odd/even styles. The original code wasn't very clear on the intent (setting to 0 in one case, not increasing the counter in another, but that was not consistent all over the place). I believe resetting the odd/even styles at a group boundary would look great, but this might be for another patch :) This amends part of another commit, but keeps its feature: b40a6eb85bf44a genlist: implement list position signals. See T3086 PS: I've discovered more odd/even issues with the fileselector in particular. Still working on it... @fix
2017-02-27Revert "elm_genlist: when appending items to the parent, prepend to the parent"Jean-Philippe Andre
This reverts commit 43d82e567a2d655a089b6ca3f2d913e6ec52f1dc. I don't understand this commit. It broke the logical order of items, as the internal list wouldn't match the order on screen. Other places in the code didn't seem to make this assumption that parents come after their children. And for sure my recent fixes require the parent to come before. This commit was one of the many reasons why odd/even styles look often wrong. See T3086
2017-02-27genlist: Remove macro GL_IT()Jean-Philippe Andre
It was used to hide "it->item"... but was used less than it->item itself. Explicit code here is not longer, and just as readable. This macro I think was harmful to readability. Simple sed, no real change at all.
2017-02-23elementary: Fix compilation for SDLChris Michael
Not sure how long this has been broken, but the variable name changed in this routine to "is_gl_accel"..."is_hw_accel" is no longer used, so change variable name here to fix compilation with SDL. @fix Signed-off-by: Chris Michael <>
2017-02-23elm: Restore ABI compatibility (elm_pan_gravity)Jean-Philippe Andre
elm_pan_gravity_{set,get} are functions that were generated as legacy APIs (in other words EAPI), but were never actually exposed to applications as they were protected behind EFL_EO_API_SUPPORT (see elm_interfaces.h). This patch restores the ABI compatibility with elementary 1.18.
2017-02-22genlist: Simplify code (remove one argument)Jean-Philippe Andre
Parameter "qadd" is always true when calling _item_process_post(), so simplify the code by removing it.
2017-02-22genlist: Fix more tree issues (expanded state)Jean-Philippe Andre
This fixes a lot of cases where a genlist node (of any type) with children may have appeared in the invalid expanded or contracted state. Before this patch, the test case "Genlist tree, Relative insert" looked like below (all items are programmatically added): > A > 1 > 2 > B > 3 > 4 The problem above is that A and B have visible children but still believe they are in contracted state. This patch ensures that A and B will be marked as expanded, but will do so without firing an "expanded" signal and definitely without the "expand,request" signal. After this patch, the test case will look like this: v A > 1 > 2 v B > 3 > 4 Which is more correct. Note that this test case does not handle any expand/contract signal. NOTE: This is a behaviour break!
2017-02-22genlist: Fix insert after with a treeJean-Philippe Andre
This fixes a case where inserting item "C" after item "B" in this tree would go wrong: A B - 1 - 2 Before this patch, 1 and 2 lose their parent: A B C - 1 - 2 After this patch, 1 and 2 retain their parent: A B - 1 - 2 C Insert before worked by luck, no need to fix it. Note that this patch may require the next one to actually work (ensuring expanded state flag). NOTE: This is a behaviour break!
2017-02-22genlist: Fix sorted_insert with treeJean-Philippe Andre
This fixes the test case "Genlist Tree, Insert Sorted". This is a pretty ugly patch... but the genlist code is already pretty ugly, as it keeps a flat inlist of items (sd->items) as well as a tree structure in parallel. Before this patch, the following configuration led to issues: 1 3 - A - B Adding item "2" led to a crash. Adding item 4 led to this: 1 3 4 - A - B Items A and B lost their parent "3". Subsequent sorted inserts would lead to insane bahaviour, where for instance "8" would appear before "3". This patch fixes all sorted inserts, at the cost of performance (an optimized code path is avoided). Subsequent patches will increase the robustness of the tree structure. NOTE: This is a behaviour break! Fixes T4850
2017-02-21elementary gengrid: fix for working item reorder mode correctlyMinkyu Kang
Summary: Change the item indexing to start 1 after reordering animation. Change the logic of edge checking to get the row or col correctly. Signed-off-by: Minkyu Kang <> Test Plan: elementary_test -to gengrid2 append 6 items enable the reorder mode check reordering is working properly (4 to 1) @fix Reviewers: singh.amitesh, cedric Subscribers: jehun.lim, jpeg Differential Revision:
2017-02-21dayselector: Fix DaySelector widgetJean-Philippe Andre
An invalid strcmp() led to always reject the swallowed widgets, which were Elm.Check instead of Elm_Check. Use efl_isa() instead. Fixes T5034
2017-02-21elm: Make clock widget more resilient to invalid configJean-Philippe Andre
I was in a situation where my elm_config had the proper version but did not contain a proper module name for the clock widget. This resulted in not being able to create any field object in the clock widget... in other words it made for a very useless clock :) Ideally the config should be updated at this point. I'm not sure how to proceed exactly, though :(
2017-02-20interface_scrollable: Improve gravity_set api to support pan changingWonki Kim
Summary: When you set gravity 1 on scroller, scroller sticks to the bottom even content is changed. however, scroller don't work like above, if size of pan is changed. this commit uses pan_pos_max rather than w/h of content_info because pan_pos_max is related with both content_size and pan size. gravity_set will work properly even if both size of content and pan are changed simultaneously. Test Plan: 1. Select 'scroll3' in the elementary_test 2. Append enough items so that scroll bar appears (about 30 items) 3. Go to the bottom and Set gravity 1.0 4. Check that scroller sticks to the bottom once you append another item (it works) 5. Check that scroller sticks to to bottom once you resize window(pan) (it doesn't work without this patch) Reviewers: eagleeye, jpeg, cedric, woohyun, z-wony, herdsman Differential Revision:
2017-02-19elm_code: Another Coverity fix, better this time.Andy Williams
@fix CID1371322
2017-02-19elm code - fix warning about sign comparisonsCarsten Haitzler (Rasterman)
2017-02-18elm_code: Fix Coverity issues.Andy Williams
@fix CID1356612 CID1368335 CID1368489 CID1371123 CID1371124 CID1371126 CID1371128
2017-02-17fix entry selection by having proper cfg update and def fieldsCarsten Haitzler (Rasterman)
this should fix T5183
2017-02-16gengrid: Remove duplicated smart callbacksJean-Philippe Andre
WRN... evas_smart.c:219 evas_smart_cb_descriptions_fix() duplicated smart callback description with name 'item,focused' and type ''
2017-02-16widget: Reduce WRN to DBG for on_focus_region messageJean-Philippe Andre
Many widgets don't implement this function, and this case is perfectly well handled by the caller. No need to WRN here.
2017-02-16win: Avoid magic check failed in ecore with inline winJean-Philippe Andre
Fixes T4663
2017-02-16win: Avoid malloc in icon_object_setJean-Philippe Andre
Also support both Evas.Image and EO Efl.Canvas.Image classes. Add a test case in elm_test (under "Icon"). I'm not so happy about this patch... it shows that the API barrier between legacy and EO implemented for images may not be such a great idea after all :(
2017-02-16win: Fix window icons with object setJean-Philippe Andre
Fixes T4981
2017-02-15fileselector: Add missing call to group_delJean-Philippe Andre
Remove unused refcount thingy and enforce call to smart del. Fixes T4598
2017-02-15group: Track calls to group_delJean-Philippe Andre
After a long search I found that fileselector was not calling super.group_del on deletion, leading to the use of dangling pointers. So let's verify that group_del is properly called. See T4598
2017-02-15genlist: remove uncessary _item_cache_zero callAmitesh Singh
_item_cache_zero() is already getting called in _mirrored_set Signed-off-by: Amitesh Singh <>
2017-02-15elm_genlist_item: update docs for 'next_get'Vyacheslav Reutskiy
2017-02-15evas & elm: Fix invalid uses of efl_data_ref(obj, NULL)Jean-Philippe Andre
The data class should be specified for debug purposes. Also, this fixes invalid uses inside the smart object implementation where it assumed that the smart data was part of the eo data. It may not (legacy objects).
2017-02-15elm_widget: Fix order of operations (isa before data_get)Jean-Philippe Andre
This fixes some of the occurences of the following error message when using eo_debug: ERR<23101>:eo /home/jpeg/e/core/efl/src/lib/eo/eo.c:1955 efl_data_scope_get() Tried getting data of class 'Elm.Widget' from object of class 'Edje.Object', but the former is not a direct inheritance of the latter. If we're going to call efl_isa, then let's at least do it before efl_data_scope_get.
2017-02-15elc_multibuttonentry: input panel should be shown whenever mbe is clicked.Woochan Lee
Summary: When mbe got focus the input panel will be shown. Otherwise, input panel will be hidden. If the mbe still got focus then input panel hide by user action. there is no way to reactivate the input panel in case. Reviewers: woohyun, jpeg, cedric, Hermet Reviewed By: jpeg Subscribers: cedric, jpeg Differential Revision:
2017-02-14Edje calc: Fix textblock size calculation logicYoungbok Shin
Summary: In singleline textblock, using "text.min: 1 0" and min, max width, Edje allows to use expandable text with ellipsis. It shows ellipsis when only text's width reach the max width. But, Edje couldn't support same feature on multiline textblock. Edje dose not use max height or text.max properly if ellipsis is enabled. This feature is very useful to make a layout with dynamically aligned text. @fix Reviewers: cedric, tasn, woohyun, raster, herdsman Subscribers: z-wony, eagleeye, jpeg Differential Revision:
2017-02-13elm_index: Skip box auto fill when index size is invalid.Woochan Lee
Summary: _index_box_auto_fill will be called when user calling elm_index_level_go(), elm_index_omit_enabled_set(). item size re-calculated and each item style reset even index size is invalid. It can make performance issue during index creation time. Test Plan: elementary_test index sample Reviewers: taxi2se, jpeg, cedric Subscribers: cedric, jpeg Differential Revision:
2017-02-13win: Make ELM_ACCEL work with msaa, depth & stencilJean-Philippe Andre
This makes the env var override and the elementary config global override on accel preference work for not only "gl" but also advanced configs such as "gl:msaa_high:depth:stencil"
2017-02-11elm code - silence possibly uninitialied compiler warningsCarsten Haitzler (Rasterman)
every time i build efl i see all these warnigns spew by about elm_code and possibly uninited vars being used. yes - they're filled in via ptr ref bya func but gcc definitely seems to think they MIGHT not be filled in in some cases... and either way tyhe cost of setting to 0 is minimal and less noise is better so we see real warnings more easily... :)