From bb30cd58ce5e1e1ce171acf6ef51f530d31458ab Mon Sep 17 00:00:00 2001 From: Chris Michael Date: Mon, 8 Jul 2013 08:01:58 +0100 Subject: We cannot use dname in the error message if we have already freed it above, so fix. On a mkpath failure, print out the message, Then free dname. Be sure to also free dname if we do not error. NB: Fixes Coverity CID1039893 Signed-off-by: Chris Michael --- src/lib/ethumb/ethumb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/lib/ethumb/ethumb.c') diff --git a/src/lib/ethumb/ethumb.c b/src/lib/ethumb/ethumb.c index ad49444031..eab57a2d8f 100644 --- a/src/lib/ethumb/ethumb.c +++ b/src/lib/ethumb/ethumb.c @@ -1354,12 +1354,13 @@ ethumb_image_save(Ethumb *e) dname = ecore_file_dir_get(e->thumb_path); r = ecore_file_mkpath(dname); - free(dname); if (!r) { ERR("could not create directory '%s'", dname); + free(dname); return EINA_FALSE; } + free(dname); snprintf(flags, sizeof(flags), "quality=%d compress=%d", e->quality, e->compress); -- cgit v1.2.1