Commit Graph

257 Commits

Author SHA1 Message Date
Kim Woelders a4cd43578d dialogs: Fixup after recent layout changes 2022-04-24 12:22:58 +02:00
Kim Woelders a09b13260a dialogs: Drop re-centering combined dialog on item change
Gives maybe a bit more smooth appearance.
Allows it to be moved away and not re-centered on change.
2022-04-22 08:02:23 +02:00
Kim Woelders 3c42724f96 Dialog layout adjustments
In general left-align text labels.
2022-04-22 07:41:58 +02:00
Kim Woelders cf552ef7f9 Enable sounds in combined configuration dialog 2020-05-01 14:11:26 +02:00
Kim Woelders c839d0e14a src: Fix clang-analyzer complaints
arrange.c: Highly unlikely, maybe impossible situations

backgrounds.c: False positive (I think)

dialog.c: Fix memleak/segv on realloc failure

focus.c: False positive
	ewin should never be NULL with FOCUS_EWIN_NEW

main.c: False positive
	eoptarg will always be set if argument requires option

menus.c: Fix memleak on malloc failure

session.c: Fix dead assignment

stacking.c: False positive
	Changed code is nicer though

pager.c: False positive
	ewin would never be NULL if hiwin was NULL
	But rearrange for clarity anyway

ecompmgr.c: Avoid bogus issues
2020-01-29 16:43:01 +01:00
Kim Woelders 22b5e58dcd Refactor/rename/use _EFREE type macros 2018-12-22 11:44:22 +01:00
Kim Woelders ca5040e643 Remove pseudotransparency support - 3
- Remove obsolete image type argument.
2018-02-04 13:32:59 +01:00
Kim Woelders 0d97ea5285 Remove pseudotransparency support - 2
- Transparency...() macros
2018-02-04 13:28:54 +01:00
Kim Woelders 9c31fe29ed Clean up header file inclusion order.
Fixes building with e.g. -std=c99 and c11 by always including config.h
(which defines _GNU_SOURCE) first.
2015-01-17 19:33:42 +01:00
Kim Woelders 23872b2cac Simplify dialog data handling. 2014-04-29 19:42:15 +02:00
Kim Woelders 5fc86cc6ad Refactor dialog apply/exit handling.
Split into separate functions so we don't have to check on val all over
to figure out if it is one or the other.

This also avoids that the apply stuff may be done twice on exit a couple
of places.
2014-04-29 19:42:15 +02:00
Kim Woelders 4d1bde02ae Wrap XID and some other X types.
Mostly to change longs to ints to reduce memory footprint a bit on 64
bit systems.
2014-04-23 19:13:00 +02:00
Kim Woelders 9d9fa0edf5 Cosmetics (key->keycode). 2014-04-23 07:38:27 +02:00
Kim Woelders 872e4f57c5 Simplify/fix dialog layout code.
The widget and table coordinates were not properly aligned, potentially
causing some widgets (last in a table) to not be rendered properly in
certain themes.
2013-12-31 09:34:00 +01:00
Kim Woelders ce34edc4a3 Reduce nesting in DialogRealizeItem().
Also tweak some (disabled) debug messages.
2013-12-31 09:34:00 +01:00
Kim Woelders e1f062fff5 Use NoXID in stead of None. 2013-12-29 08:59:38 +01:00
Kim Woelders 49669bafa2 Forgot some 2013. 2013-11-24 16:37:17 +01:00
Kim Woelders e287b37e78 Switch to new list implementation.
Faster, less code, less memory usage.
Not that it matters much - mostly for fun.
2013-08-09 11:43:48 +02:00
Kim Woelders 30cb2101aa Still more double to float. 2013-07-08 00:20:44 +02:00
Kim Woelders 3d03033e7f Some more double to float. 2013-07-08 00:05:20 +02:00
Kim Woelders ba7d9cc4a9 Fix various issues reported by clang. Minor cleanups.
SVN revision: 81671
2012-12-24 10:41:50 +00:00
Kim Woelders a6061b81e1 Dialog sliders - Enable having upper bound below lower.
SVN revision: 70825
2012-05-06 17:20:16 +00:00
Kim Woelders ee90d82431 Dialogs - Add missing const.
SVN revision: 70824
2012-05-06 17:20:13 +00:00
Kim Woelders 0786a813d0 EwinMove/Resize - Change various global/ewin flags to function parameter.
SVN revision: 70390
2012-04-22 17:39:37 +00:00
Kim Woelders 7dc821d6bd Make dialogs sticky.
SVN revision: 62887
2011-08-27 15:42:39 +00:00
Kim Woelders ff3724295a Fix jumpy dialog sliders.
Based on patch by Daniel Manjarres.

SVN revision: 59852
2011-05-31 18:05:31 +00:00
Kim Woelders aef884b09a Move duplicated stuff to function. Cleanups.
SVN revision: 57923
2011-03-20 21:53:59 +00:00
Kim Woelders 288a6c0541 FreePmapMask() -> PmapMaskFree().
SVN revision: 53806
2010-10-23 10:22:50 +00:00
Kim Woelders 4ac03926da Adjustments for indent 2.2.11.
SVN revision: 50909
2010-08-08 19:03:34 +00:00
Kim Woelders 708e19593e Fix some poytential segvs. Minor cleanups.
SVN revision: 49485
2010-06-06 10:05:50 +00:00
Kim Woelders 19c3af1c46 Remove unused radio button event function.
SVN revision: 49483
2010-06-06 10:05:46 +00:00
Kim Woelders 31c97439d1 Fix potential segvs.
Could be triggered by early move/resizes, e.g. due to initially
shaded state.

SVN revision: 47727
2010-04-03 18:28:49 +00:00
Kim Woelders a7e538be10 Trivial fixes (clang).
SVN revision: 45718
2010-01-29 19:45:04 +00:00
Kim Woelders b820c7a662 Enable transparent image in dialog headers.
SVN revision: 43790
2009-11-18 19:15:33 +00:00
Kim Woelders 633281a9c6 Eliminate need for initial EwinMoveToDesktop (fix initial pager background).
SVN revision: 43737
2009-11-16 20:55:12 +00:00
Kim Woelders c5ed93a01b Fix memory leak.
SVN revision: 43644
2009-11-12 20:48:36 +00:00
Kim Woelders 2a4d0e3fbd Dialog cleanups.
SVN revision: 43638
2009-11-12 20:48:21 +00:00
Kim Woelders acf3c63ef9 DialogDrawItems should not have to be called explicitly.
SVN revision: 43637
2009-11-12 20:48:18 +00:00
Kim Woelders c0c9da09de Simplify handling of dialog configuration data.
SVN revision: 43467
2009-11-05 18:45:58 +00:00
Kim Woelders 0506fdb959 Remove some obsolete disabled code.
SVN revision: 42890
2009-10-05 16:43:30 +00:00
Kim Woelders cdaddb3376 Remove unused parameter.
SVN revision: 41510
2009-07-27 16:46:54 +00:00
Kim Woelders 24e0a0d7e8 Forgot some 2008->2009's.
SVN revision: 40605
2009-05-12 21:21:21 +00:00
Kim Woelders 287bbf4c3b Enable building without dialogs.
SVN revision: 38754
2009-01-24 08:31:50 +00:00
Kim Woelders e42a80764f Play sounds by number in stead of by name. Enable disabling specific sounds.
SVN revision: 38142
2008-12-14 16:44:45 +00:00
Kim Woelders 5364016cb3 Fix certain cases of clicking in slider.
SVN revision: 37633
2008-11-14 18:30:58 +00:00
Kim Woelders 86b3545635 Keep slider knob highlited when over (noted by Don Harrop).
SVN revision: 37632
2008-11-14 18:30:55 +00:00
Kim Woelders fed3c74369 Fix dialog text redraws when bg is tiled.
SVN revision: 37630
2008-11-14 18:30:50 +00:00
Kim Woelders 0760e357e4 More slider tweaks.
SVN revision: 37629
2008-11-14 18:30:48 +00:00
Kim Woelders b85d1f0533 Make coordinate system in vertical sliders same as in horizontal.
SVN revision: 37628
2008-11-14 18:30:45 +00:00
Kim Woelders 6f1390acba Slider tweaks.
SVN revision: 37627
2008-11-14 18:30:41 +00:00