251ea96020
edi_main: don't use exit, goto and shutdown properly.
2017-10-04 16:53:28 +01:00
f0c2c4605b
meson: handle also cases when the options are disabled
2017-10-03 21:33:45 +02:00
ac304ea2a9
time for meson!
2017-10-03 19:07:42 +02:00
10d706a08c
Update text for SCM changes
2017-10-03 15:22:18 +01:00
2bac1157db
scm_ui: Show user icon or a fallback, not both
2017-10-03 14:57:05 +01:00
15a1529df0
scm: fix avatar caching memory handling
2017-10-03 14:40:10 +01:00
eb6d238de6
about: Fix background alpha for changes in EFL
2017-10-03 14:24:20 +01:00
a1be071c4c
main: parsing command-line options.
...
Exit rather than shutdown if displaying --help or
--copyright etc.
@fix T6115
2017-10-03 14:11:50 +01:00
543de0a53e
Revert "about: explicitly set bg colour and alpha."
...
This reverts commit 9ef65252ed
2017-10-02 13:25:34 +01:00
6e263b091e
edi_scm: initalise to quieten compiler.
2017-10-01 12:40:00 +01:00
fc855bf0bb
mainview: search + search/replace popups, UI improvement.
2017-10-01 11:43:52 +01:00
9ef65252ed
about: explicitly set bg colour and alpha.
2017-10-01 11:27:38 +01:00
9b5af0abfc
edi_scm: fix memory leak.
...
If cancelling the diff while it's loading can potenitally lose
the contents of the diff buffer. This patch fixes that...
2017-09-30 23:59:33 +01:00
76a029a09e
edi_scm: small stylistic.
2017-09-30 22:53:09 +01:00
16d6a44625
edi_scm: show window at appropriate time.
...
Avoid bogus flickering during startup.
2017-09-30 22:26:10 +01:00
4149ee7c52
scm_ui: make sure we clear the widget.
...
meh meh meh...
2017-09-30 20:56:31 +01:00
a49931161c
edi_scm: handle thread cancel and shutdown properly.
...
This allows to flip switches and stuff while we're rendering
and changing stuffz. So shutdown during rendering should be ok
and also we can switch between modes without spazzing out.
Thanks be to God!
2017-09-30 20:31:21 +01:00
9cad93b64f
edi_scm: refactor code and use threads.
...
Refactor and use a thread so we don't lock up the UI.
2017-09-30 19:51:28 +01:00
12dce44812
edi_scm: rename some borrowed functions.
...
Fix typo also in header.
2017-09-30 13:06:58 +01:00
fad276133a
edi_scm: Monitor for changes and update when possible
...
Small "refactor" of the UI also to make better use of space.
2017-09-30 12:27:19 +01:00
e623190fa3
edi_scm: pack list and commit dialogue on same line.
...
This gives a much wider space to display the diff output.
2017-09-30 10:05:04 +01:00
e5aca41ad1
filepanel: simplify code by using existing method.
2017-09-30 00:28:53 +01:00
448b0b164d
edi_scm: win title.
...
Sorry! Ugh
2017-09-29 22:14:01 +01:00
3397bc93e6
scm: header file function erroneous description.
2017-09-29 21:42:49 +01:00
be53c4df18
scm: Create edi_scm binary for commit dialogue and use elsewhere.
...
This removes the existing popup code. The edi_scm executable should
run in any git tree giving the status of the repository. The Edi
UI calls this for the commit dialogue also.
2017-09-29 21:37:21 +01:00
f66ef895b8
welcome: don't show progressbar until downloaing.
2017-09-28 22:32:23 +01:00
b2e69bebb9
welcome: Add progressbar during retrievel of remote repository.
...
This gives an indicator to the user the download is in progress.
Moreover it stops the UI from freezing up with a large remote
repository.
2017-09-28 14:27:54 +01:00
3eadca948c
edi_file: use a static buffer for the path.
2017-09-28 01:39:49 +01:00
c826dee557
search: Add project-wide search and replace feature.
2017-09-28 01:23:18 +01:00
5cefe27e48
screens: scm. Stylistic changes.
2017-09-27 20:01:14 +01:00
c75c2d817f
scm: refactor scm screens.
...
There's absolutely zero need for a hash table here.
Refactor the scm commit screen to be more efficient and make more
sense.
2017-09-27 19:46:09 +01:00
e86760b802
edi: escape paths where necessary.
2017-09-27 19:42:45 +01:00
a5896c05ac
Fix make dist
2017-09-26 15:36:11 +01:00
2b2454a104
filepanel: fix menu icon for folders
2017-09-24 21:46:29 +01:00
2933c2faf6
autosuggest: avoid lingering tab-complete suggestions
...
On focus out or mouse downs we invalidate the suggestion
2017-09-24 21:38:14 +01:00
75afcf4be8
snippet: fix indentation of inserted lines
2017-09-24 21:38:01 +01:00
986bae6eb4
filepanel: make dir menu behave as file menu does.
2017-09-22 15:17:39 +01:00
e4704ed0ba
filepanel: make dialogues more informative.
2017-09-22 15:07:23 +01:00
ef18a26ddc
filepanel: Make the filename in menu informational
2017-09-22 12:27:40 +01:00
ba8dd2becf
snippet: add some python snippets
2017-09-22 11:58:29 +01:00
f1643f08ef
autosuggest: Add safety for optional language features
...
@fix crash with rust editor
2017-09-22 10:28:50 +01:00
eed2ae8328
about: fix layout of AUTHORS content in about
2017-09-21 22:15:37 +01:00
376d4c5752
screens: scm. only show staged changes.
2017-09-21 20:46:17 +01:00
d8e0087b6f
scm: use relative path not absolute.
...
This is also faster.
2017-09-21 20:26:13 +01:00
4edd09cc59
screens: scm, remove unnecessary hash clear.
...
Small stylistic change also.
2017-09-21 20:09:48 +01:00
89dfc351bf
scm screens: select text when staged changes made.
...
Another aspect of making the entry more user-friendly.
2017-09-21 14:51:54 +01:00
d85bc57a49
Merge Andy's fix
2017-09-21 14:16:06 +01:00
2e045c0a43
screeens: scm. Replace list with genlist and make commit entry more usable.
...
The original elm_list_ would segv if there were many hundreds of items, so
redone with a genlist. Also the entry for commit message is less of a pain
as it was.
2017-09-21 14:13:41 +01:00
add0d7f6c4
autosuggest: veto tab propagation for all inserts
2017-09-21 12:29:57 +01:00
ce824635fd
edi_main: use proper method to disable menu items.
2017-09-21 09:11:18 +01:00
d6b38524b9
edi_exe: fix bad bugs.
...
Make sure we're handling the right process. Also clean-up the
sockets manually. Also make sure we actually do ninja's
clean, otherwise we might be waiting for a long time.
2017-09-21 00:54:01 +01:00
02525fe8ad
autosuggest: speed up suggeestions
...
cache the list and refresh when we re-parse...
2017-09-20 22:11:43 +01:00
e03f234573
autosuggest: Show first match for tab completion
...
Displays a hover that shows the match - and you can click it too.
Closes T5902
@feature
2017-09-20 22:11:43 +01:00
002ab279dd
filepanel: do allow focus, else this causes problems.
2017-09-20 18:41:05 +01:00
647d866bba
Build: make build proces more robust.
...
Use a different socket address for each type. Also add some
UI indicators when a build is in progress.
2017-09-20 16:47:30 +01:00
d08e50b4b0
filepanel: add filename to the root of the filepanel menus.
2017-09-19 22:20:59 +01:00
959e2435e0
notify: less text is more.
...
Trim the notification text. Some unnecessary stuff there.
2017-09-19 20:34:15 +01:00
bcd9c85741
stash: fix bug missed. make sure to update all items on stash.
2017-09-19 14:38:23 +01:00
a53d3c0765
screens: scm popup align icons.
2017-09-19 14:16:10 +01:00
20633f5f12
filepanel: 100% ontinuity.
...
Sorry.
2017-09-19 12:11:04 +01:00
9c4264d22a
filepanel: 99% consistent icons
2017-09-19 11:50:59 +01:00
ba3111903f
screens: scm fix icons
2017-09-19 11:40:02 +01:00
faac98d51f
scm status: filepanel and commit screen.
...
Use icons only and tooltips for additional information.
2017-09-19 11:29:25 +01:00
1a6be5b94d
screens: scm. update label to be more sensible.
2017-09-19 00:28:46 +01:00
76532d799f
filepanel: add icon statuses.
...
Fix scm to avoid race-condition. Also get rid of the custom
text as it's too much. Two icons, one for states and one for
staged (visible if not staged).
2017-09-19 00:18:46 +01:00
5bdce73a1d
Revert "filepanel: update on contract."
...
This reverts commit 89fb7524c8
2017-09-18 09:40:42 +01:00
89fb7524c8
filepanel: update on contract.
2017-09-18 09:34:24 +01:00
47ab991da9
filepanel: don't duplicate unnecessary code and no need to memcpy.
...
This is a small logic change that should be more efficient also.
2017-09-17 20:28:50 +01:00
bdec0fceb6
filepanel: move function for clarity.
...
Moves a function to keep related content related. Also small
stylistic changes.
2017-09-17 19:46:07 +01:00
d54d156cd3
scm: reimplement support for file listing file status.
...
This method is far more efficient and works well with large
software trees. e.g. enlightenment.git.
2017-09-17 16:34:35 +01:00
15c19acf1a
filepanel: remove uneccessary methods.
2017-09-16 22:30:29 +01:00
c48220d61e
filepanel: Bad indentation.
2017-09-16 22:15:54 +01:00
ce81684f30
scm: undo the filepanel scm status far too slow.
...
Didn't test this with large projects, it needs to be redone.
Probably causing issues so undoing the badness.
Sorry!
2017-09-16 22:14:08 +01:00
2c42965b15
scm: fix init.
...
Make sure we actually init and also upon init update the
file list and initialise the local engine.
2017-09-16 20:41:46 +01:00
59a0ec1bae
scm: add support for file listing file status.
...
Add support for file listing status. Also some refactoring.
More to do, more testing first.
2017-09-16 01:19:54 +01:00
a446d3a8d1
popup: more UI tweaks.
2017-09-13 00:09:12 +01:00
02a1872365
popups: more UI tweaks.
2017-09-13 00:05:56 +01:00
332b5e1c55
debugpanel: previous commit typo.
...
ugh sorry!
2017-09-12 16:27:03 +01:00
6770e8c022
debugpanel: add useful comment.
...
The code looks wrong but it isn't, this comment explains why.
2017-09-12 16:25:44 +01:00
cff2817907
scm: fix loss of last line.
...
oops!
2017-09-12 16:18:57 +01:00
d694160d13
scm: add elm code widget for diff in commit screen.
...
Use a proper widget with lovely formatting.
2017-09-12 10:19:34 +01:00
08547bbd3a
Add translation support
...
Fixes T5901
2017-09-11 21:06:22 +01:00
3b1e7d0288
popups: refactor popups.
...
Some of these looked pretty duff. Have tried to make them
more consistent and nicer.
2017-09-11 18:54:02 +01:00
86731ea849
screens: slight UI improvement to scm commit popup.
2017-09-11 17:33:20 +01:00
4b12a5a1ae
scm: add method to get diff of changes in SCM repository.
...
Add method to obtain the diff of changes and also add this to the
commit screen. There is also some minor UI tweaks included in
this commit, though related to methods modified.
2017-09-11 16:27:40 +01:00
84a515ce87
build: status. MOre verbose notfication title.
...
Add status to the title of the notification also.
2017-09-08 11:04:45 +01:00
b19befd089
edi_exe: modify method to allow additional data parameter.
...
This adds an additional pointer for abritrary data. Have utilised
this to make the notidy on build more verbose without code
duplication.
2017-09-08 00:16:10 +01:00
7bb4a7cc24
syntax: Fix python syntax by adding a basic provider
2017-09-07 21:00:31 +01:00
d259a776a9
editor: background file changes. Fix editor reload on background file change.
2017-09-07 14:54:50 +01:00
9be1db4858
build: Add status detection of all build types.
...
This adds tracking of other build types and their exit status and
allows us to use desktop notification for these also. Also cleaned
up some unnecessary cleanup code.
2017-09-06 13:08:02 +01:00
b8642ab63c
main: show console panel before we start the build process.
...
Show the console panel before the build process begins.
2017-09-05 16:13:05 +01:00
7e9f33a635
exe: Add methods to handle async shell execution and acting on exit status.
...
This adds two methods for handling executing shells async. The notification
has been reworked to use this method so there is less blocking. A callback
can be passed to the handler method for various actions on the exit status
of the script execution.
2017-09-05 15:58:00 +01:00
5aba714f90
build: Add support for tracking build process exit code and add notification.
...
This patch adds tracking of the build process's status code. This allows us
to respond to the build process within the program much easier. Also added
a simple API for desktop notification of the build process and its exit code
which is useful and pretty.
2017-09-04 20:52:34 +01:00
65477c7d46
widgets: Use consistent text style across widgets in the application.
...
Make changes to text style along with some miminal word changes and
fixes.
2017-09-02 22:48:57 +01:00
5eaf4e3be2
mainview: also select filepanel on tab focus.
...
This was bad by me. Found an example with an image. Both instances
are necessary for uniform behaviour. Sorry.
2017-09-02 11:54:40 +01:00
514e472cd1
filepanek: set the filepanel focus on editor focus.
...
Tab selection will focus the editor. This fixes occasions
when clicking between panels. So the filepanel focus is
uniform. Should have thought of doing it this way before.
2017-09-02 11:47:18 +01:00
482c7b0946
screens: move popup creation to screens.
...
This is a small refactor of a generic information popup.
2017-09-02 11:20:49 +01:00
8175b007e5
main: change "split" option to "new panel"
...
Rename the callback and menu item to be more appropriate for its
current behaviour.
2017-09-02 10:27:10 +01:00
782ef16427
mainview_panel: remove unnecessary cast.
...
Edi_Mainview_Item pointer does not need to be cast.
2017-09-01 20:42:41 +01:00
6ee65ae7dc
filepanel: Add documentation for new method.
...
Adds new documentation and improves existing.
2017-09-01 20:40:02 +01:00
7f1dfbb26e
filepanel: add method to select by path and select upon tab promotion.
...
When a file is focussed in it's panel and tab the file is also selected
in the filepanel. Another visual indicator of current focus and
synchronises behaviour of tab selection and filepanel selection.
2017-09-01 20:16:19 +01:00
2731c4bb75
mainview: clicking on tabs or filename will focus the editor entry.
...
Remove focus from tab item as it was stopping us from focussing the
editor entry. This change keeps track of cursors upon item change
and will focus (if possible) the entry. In essence, less clicks!
Clicking tabs or a file in the file panel has the same result.
2017-09-01 18:49:38 +01:00
fb6bd4a322
welcome: center file selector window when opening existing project.
...
This patch will center the window over the existing dialogue in
the same region of the screen. Neater and more intuitive.
2017-09-01 14:11:35 +01:00
97e324654c
mainview: ensure only one instance of file is open across tabs and panels.
...
This change will ensure only one item can be opened at once across all
panels.
2017-09-01 13:53:27 +01:00
9ea0ba05c3
scm stash: on stash don't refresh all panels, let user decide on focus.
...
Removed the call to mainview_refresh_all which means after stashing
of changes the user can decide to reload the file contents when
focussing the editor.
2017-08-30 23:55:34 +01:00
1ed7c297cb
mainview_panel: do safe checks before accessing panel->current->view
...
Reviewers: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5149
2017-08-30 22:19:07 +01:00
8925c72adf
editor: unset focus on tab change.
...
Summary: This seems to fix the multiple cursors between underlying tabs.
Reviewers: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5148
2017-08-30 22:11:44 +01:00
7e173bd2c5
mainview_panel: fix panel focus on click of empty panel.
...
Summary: @fix T5904
Test Plan:
# Open a Project
# Use the menu option and create 5 empty panels by pressing it 4 times.
# click on a panel in any order and then select files.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Maniphest Tasks: T5904
Differential Revision: https://phab.enlightenment.org/D5133
2017-08-28 14:04:33 +01:00
d4d8d4fb91
edi_scm: make sure we always delete the file if it is untracked.
...
Summary:
there are times when new files are difficult to delete without adding commiting and removing etc.
this should stop that.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5120
2017-08-28 14:02:45 +01:00
61b79e7ed6
mainview: unrecognise mime popup UI improvements.
...
Summary: See http://www.enlightenment.org/ss/e-599c3eeac02540.00312412.jpg
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5121
2017-08-26 16:15:09 +01:00
da30264929
popups: improve visual display/style of the main popup widgets.
...
Reviewers: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5117
2017-08-22 12:43:59 +01:00
e35c4ba3af
windows: make windows work properly and autosave properly.
...
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5116
2017-08-22 12:38:56 +01:00
a004aeae6b
Fix possible crashes in windowed editor
2017-08-21 17:26:26 +01:00
fe2714ea7e
editor: handle file modifications properly.
...
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5114
2017-08-21 17:18:02 +01:00
5454d06721
mainview: add separators between panels.
...
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5110
2017-08-18 23:25:39 +01:00
758f74de28
mainview: fix close_all and close.
...
Summary:
Makes sure all panels close and remain with only one panel. When tab is last in panel, remove the panel also.
Also best not to free a NULL panel or its members.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Tags: #edi
Differential Revision: https://phab.enlightenment.org/D5094
2017-08-13 00:06:01 +01:00
7a8119af60
ui: fix cancel of goto popup
2017-08-12 18:00:58 +01:00
bcd0909ca9
mainview: add method for testing if mainview is empty.
...
Summary: Also add checks to some GUI functions that crash Edi if there is no panel with no items.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5083
2017-08-12 17:51:05 +01:00
ea8823a9d1
search: Fix Project Search
...
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5081
2017-08-09 14:27:27 +01:00
d4d37a82ea
scm: Fix refreshing of panels on stash
...
refresh_all now remembers the right panel
2017-08-09 14:04:52 +01:00
1bf88c4730
refactoring mainview panel freeing and docs
2017-08-09 12:46:20 +01:00
f4ef9bb35c
mainview: Fix potential segvs from D5052
2017-08-09 12:28:20 +01:00
182dd304e1
mainview: improve documentation.
...
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5042
2017-07-26 10:21:07 +01:00
cb39c546fe
mainview: fix removal of panels from the ui
...
This removes resizable panels for now but they were not really supported anyway...
2017-07-26 10:17:44 +01:00
dcd611c31f
filepanel: reorder menu
2017-07-25 22:52:39 +01:00
d9fccf5860
filepanel: Add proper icon for "open in new pane".
...
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5041
2017-07-25 22:47:31 +01:00
3586ac9cc0
mainview: Always open in first panel.
...
Summary: This patch ensures "open file in panel" will open in first mainview if no file exists in the primary mainview. Otherwise business-as-usual.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5040
2017-07-25 22:32:14 +01:00
c265dc2693
config: remove panel from config when we remove a panel from the UI.
...
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5039
2017-07-25 21:44:53 +01:00
2386b51a60
mainview_panels: on close tab focus on existing tab and always keep one mainview panel.
...
Summary: This fixes crashes when closing tabs/panel and losing focus.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5038
2017-07-25 14:26:16 +01:00
fae8350ea1
settings: fix graphical glitch on smaller screens
2017-07-24 23:35:30 +01:00
9d0db1a1a5
config: Save the current tab of each panel
...
This needed a refactor to do properly so your open tabs
will be forgotten, sorry :(
2017-07-24 23:28:48 +01:00
804d14cef3
panels: Track focus of editors when we're changing panel
2017-07-24 18:27:45 +01:00
a437b5202a
config: Be less notification-happy when saving
...
Let's not force all our editors to reload when we don't have to!
2017-07-24 13:22:19 +01:00
be333dee6f
add open files in new tab.
...
Summary: focus chanegs on click of tab in panel. closing last tab closes panel. Exit and open remembers tabs. etc.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5034
2017-07-23 22:02:24 +01:00
24f9dc79fa
search: fix segv on wrap!
...
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5032
2017-07-22 18:35:13 +01:00
e4aaffb9d4
screens: add confirmation dialogue to screens.
...
Summary: Also add some uses of this method on scm stash and file deletion.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D5028
2017-07-16 20:00:46 +01:00
5bba0073ed
editor: replace refactor to coincide with search optimisations.
...
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Tags: #edi
Differential Revision: https://phab.enlightenment.org/D5003
2017-07-08 22:05:16 +01:00
ddce7ca448
search: Reset search highlights on cancel
...
Also fix the highlighting of all matches on a line
2017-07-05 22:02:38 +01:00
5181c2219e
search: highlight each found search result
2017-07-05 21:42:48 +01:00
ee5bb1a4a7
ui: Remove duplicate code from menu fix
2017-07-05 21:04:38 +01:00
405f93efe1
build: Add support for cargo based rust projects
...
In the process we needed to define if a project can be run...
Python and rust can always be run as they will build their binaries
whereas make and cmake need to be configured etc...
2017-07-05 20:51:38 +01:00
3caa121b12
main: Fix some invalid API usages
...
1. toolbar items are not objects
2. main menu should not be manually packed, it's handled by the
window itself
3. show last is recommended, rather than show + add subobjects,
especially for a window (note: i hate this in principle)
2017-07-04 18:36:07 +09:00
4ee5f05982
Revert "menu: hide by default until we can fix elm menu calcs"
...
This reverts commit 863b3d7ab3
2017-07-04 15:00:16 +09:00
2924b323f6
edi_screens_scm: convert markup to utf8 for commit message.
...
Summary: Do conversion and optimize string len check.
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Differential Revision: https://phab.enlightenment.org/D4993
2017-06-29 23:53:25 +01:00
a8d62ded23
ui: Use correct icon naming for FDO arrows
2017-06-29 21:25:26 +00:00
a34a71f8f6
config: Correct project name comparison for substrings
2017-06-29 21:18:15 +00:00
09da41eb8e
debug: remove warning on OSX
2017-06-28 20:35:36 +01:00
2fc7a9a309
debug: Fix libtool command for OSX
2017-06-28 20:35:36 +01:00
4c4ec6e21b
debugpanel: fix debug process.
...
Reviewers: ajwillia.ms
Reviewed By: ajwillia.ms
Subscribers: bu5hm4n
Differential Revision: https://phab.enlightenment.org/D4987
2017-06-28 19:43:27 +01:00
849619d32b
tabs: correct remembering of mime types
...
Fixes issues where code functions would not appear to load for old tabs
2017-06-27 16:48:49 +01:00
Al Poole
Marcel Hollerbach
Andy Williams
Jean-Philippe Andre
