enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

elm elm_notify.c: Fixed parent_del routine. Remove callbacks when the 

parent is deleted.
On Tue, May 22, 2012 at 4:46 PM, Sohyun Kim <anna1014.kim@samsung.com>
wrote:
>
> Hi all.
> When I use elm_notify, I got a crash in the deleting routine. (you
can test it in elementary_test > Video)
>
> When parent window of elm_notify is deleted, elm_notify set its
parent to NULL.
> However, it doesn't delete event callbacks of the parent window.
>
> In the smart_del callback of elm_notify, it tries to delete event
callbacks of parent window.
> However, its parent is already set to NULL, the deleting is skipped.
> Then the widget data gets freed.
> In this case, when other objects in the window are deleted, they can
create the parent window's event (e.g. CHANGED_SIZE_HINTS,,)
>
> Please find a patch to delete event callbacks when parent window is
deleted.
>
> Regards, Sohyun

SVN revision: 71307
This commit is contained in:
Daniel Juyung Seo 2012-05-22 08:33:06 +00:00
parent 1f70eb1107
commit 1fada495ca
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
legacy/elementary/src/lib/elm_notify.c
View File

@ -453,9 +453,7 @@ _parent_del_cb(void *data,
Evas_Object *obj __UNUSED__,
void *event_info __UNUSED__)
{
ELM_NOTIFY_DATA_GET(data, sd);
sd->parent = NULL;
elm_notify_parent_set(data, NULL);
evas_object_hide(data);
}