enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

efreet: simplify 

Since we open the file, there is no need to check for file existance and
a fstat call is nicer than ecore_file_size

SVN revision: 78171
This commit is contained in:
Sebastian Dransfeld 2012-10-18 09:12:04 +00:00
parent 9fe5e81ccb
commit 39d7882866
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
legacy/efreet/src/lib/efreet_xml.c
View File

@ -86,27 +86,27 @@ efreet_xml_new(const char *file)
Efreet_Xml *xml = NULL;
int size, fd = -1;
char *data = MAP_FAILED;
struct stat st;
if (!file) return NULL;
if (!ecore_file_exists(file)) return NULL;
size = ecore_file_size(file);
if (size <= 0) goto efreet_error;
fd = open(file, O_RDONLY);
if (fd == -1) goto efreet_error;
if (fstat(fd, &st) < 0) goto efreet_error;
/* let's make mmap safe and just get 0 pages for IO erro */
eina_mmap_safety_enabled_set(EINA_TRUE);
data = mmap(NULL, size, PROT_READ, MAP_SHARED, fd, 0);
data = mmap(NULL, st.st_size, PROT_READ, MAP_SHARED, fd, 0);
if (data == MAP_FAILED) goto efreet_error;
error = 0;
size = st.st_size;
xml = efreet_xml_parse(&data, &size);
if (!xml || error) goto efreet_error;
munmap(data, size);
munmap(data, st.st_size);
close(fd);
return xml;