enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

From: Bluezery <ohpowel@gmail.com> 

Subject: [E-devel] [ecore_file] Check a return value of
ecore_con_url_get()

_ecore_file_download_curl() does not check return value of  even if
ecore_con_url_get(), it can be failed.
I add a simple error checking.
Please review this patch.



SVN revision: 64795
This commit is contained in:
Bluezery 2011-11-06 06:14:31 +00:00 committed by Carsten Haitzler
parent 192139c55e
commit 483abf1e07
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
legacy/ecore/src/lib/ecore_file/ecore_file_download.c
View File

@ -369,7 +369,15 @@ _ecore_file_download_curl(const char *url, const char *dst,
job->progress_cb = progress_cb;
_job_list = eina_list_append(_job_list, job);
ecore_con_url_get(job->url_con);
if (!ecore_con_url_get(job->url_con))
{
ecore_con_url_free(job->url_con);
_job_list = eina_list_remove(_job_list, job);
fclose(job->file);
free(job->dst);
free(job);
return NULL;
}
return job;
}