enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

ecore_ipc: coverity issue - you cannot return without free 

Summary: The allocated memory is not released before return.

Lost track of the CID.

Test Plan: Run static analysis tool such as prevent

Reviewers: raster, cedric

Reviewed By: cedric

Subscribers: cedric, seoz

Differential Revision: https://phab.enlightenment.org/D1746

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This commit is contained in:
Shinwoo Kim 2014-12-12 04:05:36 +01:00 committed by Cedric BAIL
parent f3e342b5ba
commit 4c1b5a5e30
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/ecore_ipc/ecore_ipc.c
View File

@ -1275,11 +1275,13 @@ _ecore_ipc_event_client_data(void *data EINA_UNUSED, int ev_type EINA_UNUSED, vo
}
if ((max < 0) || (msg.size <= max))
{
Eina_Bool need_free = EINA_FALSE;
if (msg.size > 0)
{
buf = malloc(msg.size);
if (!buf) return ECORE_CALLBACK_CANCEL;
memcpy(buf, cl->buf + offset + s, msg.size);
need_free = EINA_TRUE;
}
if (!cl->delete_me)
{
@ -1298,8 +1300,10 @@ _ecore_ipc_event_client_data(void *data EINA_UNUSED, int ev_type EINA_UNUSED, vo
ecore_event_add(ECORE_IPC_EVENT_CLIENT_DATA, e2,
_ecore_ipc_event_client_data_free,
NULL);
need_free = EINA_FALSE;
}
}
if (need_free) free(buf);
}
cl->prev.i = msg;
offset += (s + msg.size);