enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

ecore: properly handle children destruction in Efl.BooleanModel. 

The children removal event is happening on the parent model, so access
values directly.

T8358

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10623
This commit is contained in:
Cedric BAIL 2019-11-07 16:08:30 -08:00 committed by Marcel Hollerbach
parent 600163320b
commit 560db39577
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/ecore/efl_boolean_model.c
View File

@ -258,11 +258,11 @@ _child_removed(void *data, const Efl_Event *event)
Eina_Iterator *it;
Eina_Array updated;
if (!pd->parent) return;
if (!pd->values) return;
eina_array_step_set(&updated, sizeof (Eina_Array), 8);
it = eina_hash_iterator_data_new(pd->parent->values);
it = eina_hash_iterator_data_new(pd->values);
EINA_ITERATOR_FOREACH(it, v)
{
Efl_Boolean_Model_Storage_Range *lookup;
@ -276,7 +276,7 @@ _child_removed(void *data, const Efl_Event *event)
{
unsigned char lower_mask = (((unsigned char)1) << (ev->index & 0x7)) - 1;
unsigned char upper_mask = (~(((unsigned char)1) << (ev->index & 0x7))) & (~lower_mask);
unsigned char offset = (ev->index - lookup->offset) >> 3;
uint16_t offset = (ev->index - lookup->offset) >> 3;
uint16_t byte_length = lookup->length >> 3;
// Manually shift all the byte in the buffer