enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

elm: Fix potential leak in cv request add 

Summary: CID 1405809

Reviewers: zmike, cedric, bu5hm4n

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10174
This commit is contained in:
Lauro Moura 2019-10-13 23:34:32 -03:00
parent 431d62d095
commit 8686e14dc9
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/lib/elementary/efl_ui_collection_view.c
View File

@ -1783,14 +1783,13 @@ _efl_model_child_removed(void *data, const Efl_Event *event)
Efl_Model_Children_Event *ev = event->info;
MY_DATA_GET(data, pd);
Eina_List *requests = NULL;
Efl_Ui_Collection_Request *request = NULL;
#ifdef VIEWPORT_ENABLE
Eina_List *requests = NULL;
unsigned int i;
#endif
unsigned int upper_end;
long length;
unsigned int count;
uint64_t request_length;
// FIXME: later optimization, instead of reloading everyone, we could actually track index and self
// update would be more efficient, but it is also more tricky
@ -1855,11 +1854,13 @@ _efl_model_child_removed(void *data, const Efl_Event *event)
notify_manager:
#endif
requests = _request_add(requests, &request, ev->index, EINA_TRUE);
request->length = upper_end - ev->index;
request_length = upper_end - ev->index;
if (request->length > 0)
if (request_length > 0)
{
Efl_Ui_Collection_Request *request = NULL;
requests = _request_add(requests, &request, ev->index, EINA_TRUE);
request->length = request_length;
requests = eina_list_append(requests, request);
requests = _batch_request_flush(requests, data, pd);
}