enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

elm_list/genlist/gengrid: don't unselect items when moving the mouse out of them 

this seems wrong since it's using smart object geometry to determine
event-based positioning within an edje object. considering it from a user pov,
it definitely is wrong because why would you deselect items based on mouse
movement?

ref D2622
ref da81eff897

@fix
This commit is contained in:
Mike Blumenkrantz 2017-06-23 17:43:58 -04:00
parent 7b4e9f5d77
commit 990a9d485d
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/elementary/elm_gengrid.c
View File

@ -743,7 +743,7 @@ _item_mouse_move_cb(void *data,
}
}
}
else if (ELM_RECTS_POINT_OUT(x, y, w, h, ev->cur.canvas.x, ev->cur.canvas.y) &&
else if (it->down && ELM_RECTS_POINT_OUT(x, y, w, h, ev->cur.canvas.x, ev->cur.canvas.y) &&
!sd->reorder_it )
{
ELM_SAFE_FREE(it->long_timer, ecore_timer_del);

2
src/lib/elementary/elm_genlist.c
View File

@ -3871,7 +3871,7 @@ _item_mouse_move_cb(void *data,
_item_unselect(it);
}
}
else if (ELM_RECTS_POINT_OUT(x, y, w, h, ev->cur.canvas.x, ev->cur.canvas.y) &&
else if (it->down && ELM_RECTS_POINT_OUT(x, y, w, h, ev->cur.canvas.x, ev->cur.canvas.y) &&
!sd->reorder_it)
{
ELM_SAFE_FREE(it->long_timer, ecore_timer_del);

2
src/lib/elementary/elm_list.c
View File

@ -1622,7 +1622,7 @@ _mouse_move_cb(void *data,
}
}
}
else if (ELM_RECTS_POINT_OUT(x, y, w, h, ev->cur.canvas.x, ev->cur.canvas.y))
else if (sd->mouse_down && ELM_RECTS_POINT_OUT(x, y, w, h, ev->cur.canvas.x, ev->cur.canvas.y))
{
ELM_SAFE_FREE(it->long_timer, ecore_timer_del);
if (!sd->was_selected)