enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

evas_object_smart: enhance logic checking clipper visibility 

Summary:
If current clipper object is equal to previous clipper object,
then the value of visible (or alpha) is same, because it is same object.

But there is a case that current visible value is different with
previous visible, when clipper object is same.

I added this patch to cover above case to draw childern of map.
See following flow.

  evas_render_mapped
    > if (_evas_render_has_map(obj) && !_evas_render_can_map(obj))
      > if (!changed) changed = evas_object_smart_changed_get(obj);

The evas_object_smart_changed_get returned FALSE, even though
current visible value is different with previous one in the same
clipper object.

Reviewers: raster, Hermet, herb, jsuya

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12250
This commit is contained in:
Shinwoo Kim 2021-03-03 16:44:28 +09:00 committed by Hermet Park
parent 91f07de890
commit 9da41a50cb
1 changed files with 21 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/lib/evas/canvas/evas_object_smart.c
View File

@ -1377,12 +1377,27 @@ evas_object_smart_changed_get(Evas_Object_Protected_Data *obj)
return EINA_FALSE;
//b. Object clipper visibility
if ((obj->prev->clipper && obj->cur->clipper) &&
((!obj->prev->clipper->cur->visible &&
!obj->cur->clipper->cur->visible) ||
((obj->prev->clipper->cur->color.a == 0) &&
(obj->cur->clipper->cur->color.a == 0))))
return EINA_FALSE;
if (obj->prev->clipper && obj->cur->clipper)
{
if (obj->prev->clipper != obj->cur->clipper)
{
/* check between prev clipper and current clipper */
if ((!obj->prev->clipper->cur->visible &&
!obj->cur->clipper->cur->visible) ||
((obj->prev->clipper->cur->color.a == 0) &&
(obj->cur->clipper->cur->color.a == 0)))
return EINA_FALSE;
}
else
{
/* check between prev value and current value of clipper */
if ((!obj->cur->clipper->prev->visible &&
!obj->cur->clipper->cur->visible) ||
((obj->cur->clipper->prev->color.a == 0) &&
(obj->cur->clipper->cur->color.a == 0)))
return EINA_FALSE;
}
}
if (!obj->clip.clipees)
{