enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

ctxpopup: Add return value check 

Summary:
Using elm_widget_theme_object_set without checking return value.
so add return value check and log message

Test Plan: N/A

Reviewers: herb, cedric, Hermet

Reviewed By: Hermet

Subscribers: Hermet, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D7072
This commit is contained in:
junsu choi 2018-09-21 19:29:57 +09:00 committed by Hermet Park
parent 331bd33036
commit 9f2d1ae6ca
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/elementary/elc_ctxpopup.c
View File

@ -1060,7 +1060,9 @@ _elm_ctxpopup_efl_canvas_group_group_add(Eo *obj, Elm_Ctxpopup_Data *priv)
//Background
priv->bg = edje_object_add(evas_object_evas_get(obj));
elm_widget_theme_object_set(obj, priv->bg, "ctxpopup", "bg", "default");
if (!elm_widget_theme_object_set(obj, priv->bg, "ctxpopup", "bg", "default"))
CRI("ctxpopup(%p) failed to set theme [efl/ctxpopup/bg/default]!", obj);
edje_object_signal_callback_add
(priv->bg, "elm,action,click", "*", _bg_clicked_cb, obj);
evas_object_smart_member_add(priv->bg, obj);