enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

efl_ui_position_manager_grid: honor NULL objects 

its sometimes possible that there is a NULL object returned by the batch
call. We should not just access the NULL element. Additionally, if NULL
was returned during visibility setting, we need to set visibility here.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9827
This commit is contained in:
Marcel Hollerbach 2019-09-03 10:55:40 +02:00
parent 36eff7ed82
commit a26efaeb57
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/lib/elementary/efl_ui_position_manager_grid.c
View File

@ -302,8 +302,12 @@ _position_items_vertical(Eo *obj EINA_UNUSED, Efl_Ui_Position_Manager_Grid_Data
{
_place_grid_item(&geom, pd, x, y);
}
efl_gfx_entity_geometry_set(obj_buffer[buffer_id].entity, geom);
Efl_Gfx_Entity *item = obj_buffer[buffer_id].entity;
if (item)
{
efl_gfx_entity_geometry_set(item, geom);
efl_gfx_entity_visible_set(item, EINA_TRUE);
}
}
}
@ -369,7 +373,12 @@ _position_items_horizontal(Eo *obj EINA_UNUSED, Efl_Ui_Position_Manager_Grid_Dat
{
_place_grid_item(&geom, pd, x, y);
}
efl_gfx_entity_geometry_set(obj_buffer[buffer_id].entity, geom);
Efl_Gfx_Entity *item = obj_buffer[buffer_id].entity;
if (item)
{
efl_gfx_entity_geometry_set(item, geom);
efl_gfx_entity_visible_set(item, EINA_TRUE);
}
}
}