enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 1 Projects Releases Wiki Activity

elementary: Fix potential resource leak 

If we fail to allocate memory for savedtypes.types here, then the
"known" array would end up leaking. Defer creation of 'known' array
until after savedtypes.types is allocated, this way we don't leak.

Fixes CID1363216

Signed-off-by: Chris Michael <cp.michael@samsung.com>
This commit is contained in:
Chris Michael 2016-09-26 14:01:15 -04:00
parent 65367a4a07
commit a8ba4c28fb
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/elementary/elm_cnp.c
View File

@ -3477,7 +3477,6 @@ _wl_dnd_enter(void *data EINA_UNUSED, int type EINA_UNUSED, void *event)
ev = event;
known = eina_array_new(5);
available = ecore_wl2_offer_mimes_get(ev->offer);
free(savedtypes.types);
@ -3486,9 +3485,12 @@ _wl_dnd_enter(void *data EINA_UNUSED, int type EINA_UNUSED, void *event)
savedtypes.types = malloc(sizeof(char *) * savedtypes.ntypes);
if (!savedtypes.types) return EINA_FALSE;
known = eina_array_new(5);
for (i = 0; i < eina_array_count(available); i++)
{
savedtypes.types[i] = eina_stringshare_add(eina_array_data_get(available, i));
savedtypes.types[i] =
eina_stringshare_add(eina_array_data_get(available, i));
if (savedtypes.types[i] == text_uri)
{
savedtypes.textreq = 1;