From b2193b6fd3b603e6d8f331c90a976023318f1c0c Mon Sep 17 00:00:00 2001 From: Sebastian Dransfeld Date: Thu, 19 Jan 2012 00:36:20 +0000 Subject: [PATCH] eina: Add FIXME SVN revision: 67310 --- legacy/eina/src/lib/eina_mmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/legacy/eina/src/lib/eina_mmap.c b/legacy/eina/src/lib/eina_mmap.c index 45898187e2..7929f0ec67 100644 --- a/legacy/eina/src/lib/eina_mmap.c +++ b/legacy/eina/src/lib/eina_mmap.c @@ -164,6 +164,9 @@ eina_mmap_safety_enabled_set(Eina_Bool enabled) sa.sa_sigaction = _eina_mmap_safe_sigbus; sa.sa_flags = SA_RESTART | SA_SIGINFO; sigemptyset(&sa.sa_mask); + /* FIXME: This is rubbish. We return EINA_FALSE whether sigaction + * fails or not. And we never set mmap_safe, so we always hit this + * code path. */ if (sigaction(SIGBUS, &sa, NULL) == 0) return EINA_FALSE; /* setup of SIGBUS handler failed, lets close zero page dev and fail */ close(_eina_mmap_zero_fd);