From e565e989eee5846bc121ddff80ca75c3642d3427 Mon Sep 17 00:00:00 2001 From: Daniel Kolesa Date: Mon, 20 Apr 2020 14:19:26 +0200 Subject: [PATCH] eolian: only warn instead of erroring on unused imports --- src/lib/eolian/database_check.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/lib/eolian/database_check.c b/src/lib/eolian/database_check.c index 02a8de84db..96ea24d984 100644 --- a/src/lib/eolian/database_check.c +++ b/src/lib/eolian/database_check.c @@ -212,10 +212,9 @@ _check_constant(const Eolian_Constant *v, Eina_Hash *depset, Eina_Hash *chash) _check_expr(v->value, depset); } -static Eina_Bool +static void _check_unit(const Eolian_Unit *unit) { - Eina_Bool ret = EINA_TRUE; Eina_Hash *depset = eina_hash_pointer_new(NULL); /* collect all real dependencies of the unit */ @@ -253,13 +252,11 @@ _check_unit(const Eolian_Unit *unit) { eolian_state_log(unit->state, "%s: unused dependency %s", unit->file, cunit->file); - ret = EINA_FALSE; } } eina_iterator_free(citr); eina_hash_free(depset); - return ret; } static Eina_Bool @@ -301,10 +298,7 @@ database_check(const Eolian_State *state) Eina_Iterator *itr = eolian_state_units_get(state); const Eolian_Unit *unit; EINA_ITERATOR_FOREACH(itr, unit) - { - if (!_check_unit(unit)) - ret = EINA_FALSE; - } + _check_unit(unit); eina_iterator_free(itr); /* namespace checks */