enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

efl_ui_focus_manager_calc: reduce the amount of list operations 

it appears that the calculation of the unordered elements can be done a
lot easier here, when checking in the initial for loop for the right
parent safes us two more list walk later on.

Additionally, if all elements in this chain have the right parent, and
the amount of elements is the same as the parent has, then this list can
be used as a full replacement.

Differential Revision: https://phab.enlightenment.org/D7330
This commit is contained in:
Marcel Hollerbach 2018-11-21 20:57:32 +01:00
parent 976a33e36a
commit e661c4acc3
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/lib/elementary/efl_ui_focus_manager_calc.c
View File

@ -683,19 +683,21 @@ _efl_ui_focus_manager_calc_update_order(Eo *obj, Efl_Ui_Focus_Manager_Calc_Data
tmp = eina_hash_find(pd->node_hash, &o);
if (!tmp) continue;
if (T(tmp).parent != pnode) continue;
node_order = eina_list_append(node_order, tmp);
}
not_ordered = _set_a_without_b(T(pnode).children, node_order);
trash = _set_a_without_b(node_order, T(pnode).children);
node_order_clean = _set_a_without_b(node_order, trash);
eina_list_free(node_order);
eina_list_free(trash);
eina_list_free(T(pnode).children);
T(pnode).children = eina_list_merge(node_order_clean, not_ordered);
if (eina_list_count(node_order) == eina_list_count(T(pnode).children))
{
eina_list_free(T(pnode).children);
T(pnode).children = node_order;
}
else
{
not_ordered = _set_a_without_b(T(pnode).children, node_order);
eina_list_free(T(pnode).children);
T(pnode).children = eina_list_merge(node_order, not_ordered);
}
return;
}