enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 3 Projects Releases Wiki Activity

From: Bluezery <ohpowel@gmail.com> 

Subject: [E-devel]  [Patch][ecore_con] Fix return value checking
Date: Tue, 3 Jan 2012 10:01:17 +0900

Hi,

There is invalid return value checking of curl_multi_perform() in ecore_con_url.
Because CURLM_CALL_MULTI_PERFORM is also not  CURLM_OK,
CURLM_CALL_MULTI_PERFORM checking  should precede CURLM_OK checking.
It's simple fix. Please review this

-- 
BRs,
Kim.


SVN revision: 66771
This commit is contained in:
Bluezery 2012-01-03 03:58:48 +00:00 committed by Mike Blumenkrantz
parent 221db402f5
commit fcdec47f13
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
legacy/ecore/src/lib/ecore_con/ecore_con_url.c
View File

@ -1555,18 +1555,18 @@ _ecore_con_url_idler_handler(void *data __UNUSED__)
CURLMcode ret;
ret = curl_multi_perform(_curlm, &still_running);
if (ret != CURLM_OK)
if (ret == CURLM_CALL_MULTI_PERFORM)
{
DBG("Call multiperform again");
return ECORE_CALLBACK_RENEW;
}
else if (ret != CURLM_OK)
{
ERR("curl_multi_perform() failed: %s", curl_multi_strerror(ret));
_ecore_con_url_curl_clear();
ecore_timer_freeze(_curl_timeout);
return ECORE_CALLBACK_RENEW;
}
if (ret == CURLM_CALL_MULTI_PERFORM)
{
DBG("Call multiperform again");
return ECORE_CALLBACK_RENEW;
}
_ecore_con_url_info_read();
if (still_running)