Commit Graph

104 Commits

Author SHA1 Message Date
Carsten Haitzler 1c34083001 lets... use our return value shall we? <- THATS the missing icons bug
i was telling you about!



SVN revision: 54776
2010-11-22 09:47:36 +00:00
Sebastian Dransfeld 027c174f9d Find icons in cache
SVN revision: 54616
2010-11-16 21:50:53 +00:00
Sebastian Dransfeld e4c39fa555 export depcreated user dir
SVN revision: 54581
2010-11-16 10:32:01 +00:00
Sebastian Dransfeld 2849f58ca9 Remove duplicate code, mark strict spec
SVN revision: 54579
2010-11-16 08:28:52 +00:00
Sebastian Dransfeld e8ce2014b0 TODO++
SVN revision: 54574
2010-11-15 21:07:05 +00:00
Sebastian Dransfeld bc9f811710 remove duplicate code, and mark strict spec
SVN revision: 54572
2010-11-15 21:04:42 +00:00
Sebastian Dransfeld 7545e54203 Let efreet icon return const
We return a pointer to an internal cache, so no need to do strdup. I we
implement a cache, the pointer will be a return from a mmap'ed file, so
no need to do strdup.

A bit late to do an API break, but must be done.

SVN revision: 54372
2010-11-09 20:15:55 +00:00
Cedric BAIL 5cec7beb53 * efreet: little speedup for icon lookup.
But really you should not call it as it will call stat for
	every path it guess an icon could be in. For example, elementary_test
	Toolbar 5 trigger 41132 call to stat on random place on your harddrive.


SVN revision: 54339
2010-11-08 18:09:25 +00:00
Sebastian Dransfeld 1a12537dfd delay deletion of non valid themes
We need to delay deletion of non valid themes until all possible search
dirs are scanned. In Ubuntu 10.10 XDG_DATA_DIRS lists /usr/local/share
before /usr/share, so when searching for hicolor /usr/local/share is
dropped as a valid dir although it exists as it does not contain an
index.theme file.

SVN revision: 53882
2010-10-25 20:20:41 +00:00
Lucas De Marchi 67771ee617 Fix common misspellings
Following misspellings were fixed:

acheive->achieve
appart->apart
isnt->isn't
succesfully->successfully
taht->that



SVN revision: 51987
2010-09-08 11:27:59 +00:00
Lucas De Marchi 5a8a8c9014 Convert (hopefully) all comparisons to NULL
Apply badzero.cocci, badnull.coci and badnull2.cocci

This should convert all cases where there's a comparison to NULL to simpler
forms. This patch applies the following transformations:

code before patch               ||code after patch
===============================================================

return a == NULL;                 return !a;

return a != NULL;                 return !!a;

func(a == NULL);                  func(!a);

func(a != NULL);                  func(!!a);

b = a == NULL;                    b = !a;

b = a != NULL;                    b = !!a;

b = a == NULL ? c : d;            b = !a ? c : d;

b = a != NULL ? c : d;            b = a ? c : d;


other cases:

a == NULL                         !a
a != NULL                         a




SVN revision: 51487
2010-08-21 13:52:25 +00:00
Cedric BAIL ba22eb6af8 * efreet: less warning by Albin Tonnerre.
SVN revision: 51247
2010-08-17 12:03:10 +00:00
Sebastian Dransfeld 2dc15f4d89 formatting
SVN revision: 51137
2010-08-15 19:54:19 +00:00
Sebastian Dransfeld b001a8968e Fix theme passed to efreet_icon_cache_add
Just pass NULL, no need for NULL theme

SVN revision: 51136
2010-08-15 19:54:08 +00:00
Joerg Sonnenberger 607e5d4b9b From: Joerg Sonnenberger <joerg@britannica.bec.de>
Subject: [E-devel] [PATCH] efreet and icon loading

Hi all,
attached patch fixes two issues:

(1) If using a non-default prefix, share/pixmaps should be checked
before the hard-coded /usr/share/pixmaps fallback. This basically
restores symmetry with the other cases like share/icons.

(2) Do a fallback lookup if the theme is not valid or faked. This can
happen if only hicolor is installed and e17 decides to use Tango.
Before, e.g. gimp's icon wasn't picked up because the short cut was too
early.



SVN revision: 51124
2010-08-15 03:01:55 +00:00
Cedric BAIL a6645cb746 * eina: fix eina array threadsafe version.
Also add iterator and accessor ability to walk threadsafely.
	Rename EINA_EACH to EINA_EACH_CB to match other callback cast.


SVN revision: 51000
2010-08-11 14:32:30 +00:00
Sebastian Dransfeld 03f82b7d73 Fix clearing of theme cache
SVN revision: 50825
2010-08-04 21:01:09 +00:00
Sebastian Dransfeld 80c2d94afd Check NULL return
SVN revision: 50821
2010-08-04 19:15:38 +00:00
Lucas De Marchi 0a4617ae38 FORMATTING
* Remove vim modelines:
 find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
 find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;

* Remove leading blank lines:
 find . -name '*.[cxh]' -exec sed -i '/./,$!d'

If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0



SVN revision: 50816
2010-08-04 16:57:32 +00:00
Sebastian Dransfeld 2ccf1a156d Remove fake_null try 2
SVN revision: 50807
2010-08-04 12:23:00 +00:00
Carsten Haitzler 1837b63b38 ummmm revert. crash crash crash.
SVN revision: 50789
2010-08-03 21:32:45 +00:00
Sebastian Dransfeld eba0c34bf9 Remove unneeded fake_null theme
SVN revision: 50788
2010-08-03 20:46:56 +00:00
Sebastian Dransfeld c623230e98 Remove unneeded eina_hash_del
We already checked that this value isn't in the hash.

SVN revision: 50787
2010-08-03 20:46:46 +00:00
Sebastian Dransfeld b197b55abc Check return NULL
SVN revision: 50786
2010-08-03 20:46:36 +00:00
Sebastian Dransfeld 08e9824c6e check return value from NEW
SVN revision: 50784
2010-08-03 19:31:44 +00:00
Sebastian Dransfeld 99673bb0a8 fix malloc calls
check return value and remove unneeded sizeof(char)

SVN revision: 50783
2010-08-03 19:31:34 +00:00
Sebastian Dransfeld 78f80647ea use eina hash set
SVN revision: 50494
2010-07-25 20:28:21 +00:00
Sebastian Dransfeld d4eb19a520 efreet: formatting
SVN revision: 48946
2010-05-17 19:45:20 +00:00
Hannes Janetzek 61df60e3bb get min/max size only for scalable icons
SVN revision: 48924
2010-05-16 21:11:21 +00:00
Hannes Janetzek 3ac99ef29b fix ret_size used unitialized
Threshold is fallback for type
calc min/max dir size for threshold only once


SVN revision: 48923
2010-05-16 21:02:52 +00:00
Sebastian Dransfeld fc031b899d efreet: better variable naming
SVN revision: 48920
2010-05-16 18:42:43 +00:00
Sebastian Dransfeld f827867a22 efreet: prefer downsizing
SVN revision: 48919
2010-05-16 18:42:33 +00:00
Sebastian Dransfeld 31fa5a1e1d efreet: use exponential scale for icon size search
fd.o spec wants us to use linear distance for icon size search. But
f.ex. when searching for a 128px icon, and the available is 48px and
256px, 256px would be preferable as 256/128 is 2 and 128/48 is 2.67

SVN revision: 48918
2010-05-16 18:41:56 +00:00
Sebastian Dransfeld 8cde10890b efreet: Don't remove/add stuff already in list
eina_list_promote_list to prepend data already in list.

SVN revision: 48898
2010-05-15 18:38:50 +00:00
Hannes Janetzek af2471c7bc remove svg from default types.
make efreet_icon_extensions prepended a type when it already is in list


SVN revision: 48895
2010-05-15 17:55:41 +00:00
Hannes Janetzek 82b89cea6b add FIXME
SVN revision: 48893
2010-05-15 16:57:28 +00:00
Hannes Janetzek 85dbd6d844 search for svg icons
SVN revision: 48891
2010-05-15 16:24:58 +00:00
Sebastian Dransfeld 31f73712f3 efreet: stringshare
SVN revision: 47668
2010-04-01 19:41:03 +00:00
Sebastian Dransfeld d99f80aff7 Fix compiler warnings
Found when compiling with --enable-tests and --enable-coverage

SVN revision: 46746
2010-03-01 21:43:59 +00:00
Sebastian Dransfeld f72d4f9342 Eet cache for efreet desktop
SVN revision: 46726
2010-03-01 18:16:32 +00:00
Sebastian Dransfeld cb4af1da03 Don't add already existing paths to theme
SVN revision: 45883
2010-02-04 20:02:56 +00:00
Sebastian Dransfeld 291c525a42 Remove raster's stupid cache
And just disable cache limit on the already existing cache.

SVN revision: 45881
2010-02-04 20:02:33 +00:00
Sebastian Dransfeld 0423e1ea99 Formatting
SVN revision: 45865
2010-02-04 09:12:35 +00:00
Sebastian Dransfeld d3419db6cd Ecore_Str.h -> Eina
SVN revision: 45741
2010-01-30 22:13:16 +00:00
Sebastian Dransfeld af22e351b2 Fix compiler warnings
SVN revision: 45199
2010-01-15 20:51:23 +00:00
Christopher Michael 56ec4c946f When using snprintf or fgets, etc, do not use PATH_MAX directly as the size
of the variable...use sizeof() compiler directive (lots of these).

Do not free 'realpath' in efreet_menu if we are going to try and print out
it's value.

If we find 'realpath' in the merged_menus hash, and we are going to return,
then free the realpath variable.



SVN revision: 44699
2009-12-23 20:55:23 +00:00
Vincent Torri 285297dcdd * API break: _shutdown() functions return an int, now
* simplify a bit and fix init/shutdown functions



SVN revision: 42996
2009-10-10 06:19:13 +00:00
Vincent Torri 1403d26dce remoove unused variables
SVN revision: 42877
2009-10-04 22:28:12 +00:00
Hannes Janetzek 6a9f924640 patch from dfjoerg: search also pixmap dirs for icons
SVN revision: 42875
2009-10-04 21:55:13 +00:00
Cedric BAIL 05126826a3 * efreet: Use eina_log.
Patch from Matthieu.


SVN revision: 42599
2009-09-21 16:36:29 +00:00