Commit Graph

217 Commits

Author SHA1 Message Date
Avi Levin fa8f786d44 back 2015-03-16 15:55:32 +02:00
Vitalii Vorobiov 3c925a1ea6 Edje: Edje_Edit - code style fix accoring to Coding Convention
Oops!
According to Coding Convention it should be like that:
...
>>> function forward declaration/prototype should be a single line;
>>> function definition should have the return at one line, then function name starts at next line, column 0;
...
2015-02-24 13:16:11 +02:00
Vitalii Vorobiov 54b090b0af Edje: Edje_Edit - setter and getter for min param of TABLE/BOX parts
Add new functions for set and get whether
minimum size's of the box are equal to the minimum vertical or horizontal size
of the items or not.

@feature
2015-02-24 12:36:25 +02:00
Vitalii Vorobiov 34c8d3a52d Edje: new set/get API omogeneous, paddings and align for BOX/TABLE in Edje Edit
Those include such functions like:
> edje_edit_state_table_homogeneous_set/get (function for TABLE only)
> edje_edit_state_container_padding_get
(container means that functions both for TABLE and BOX)
> edje_edit_state_container_align_get (also for TABLE and BOX)

@feature
2015-02-19 16:57:17 +02:00
Vitalii Vorobiov 87a5388919 edje: Edje_Edit - functions to edit layouts of BOX parts
New functions for setting such BOX's params like primary and fallback layouts:
> edje_edit_state_box_layout_set
> edje_edit_state_box_layout_get
> edje_edit_state_box_alt_layout_set
> edje_edit_state_box_alt_layout_get

@feature
2015-02-13 19:08:40 +02:00
Vitalii Vorobiov b552cfb50b edje: edje_edit - fix group source generation of box params
Need to generate such params of box like align, padding, min and layouts
(both primary and alternative).

@fix
2015-02-13 18:43:04 +02:00
Vitalii Vorobiov eaad731abe edje: edje_edit - fix group source generation of item 'weight' param
@fix
2015-02-13 18:42:14 +02:00
Vitalii Vorobiov 1d4e8c2f1d Edje: edje_edit - fix Segmentation Fault on new BOX part
After adding new part (with type BOX) there was a SIGSEV because
of structure that wasn't initialized.

@fix
2015-02-09 18:58:26 +02:00
Vitalii Vorobiov bac07e79ce Edje: edje_edit - abort Recursive Reference in edje_edit_part_source_set
It is unable to do recursive reference such as:
>   Having group A with GROUP part that has group B as source.
>   Having group B with GROUP part that has group A as source.
Here we have a loop that is not allowed by edje_cc, so edje_edit also need
to check this case.

@fix
2015-02-02 11:37:20 +02:00
Vitalii Vorobiov 60b1f44fdf edje: Edje_Edit - fix setting NULL into string pointer
Some of edje_edit functions allows to set up NULL instead of string,
but by using _edje_if_string_free() function it should set variable into NULL,
so previous data won't appear anymore.

@fix
2015-01-28 16:40:09 +02:00
Andrii Kroitor 56d75b755f edje: Edje_Edit - fix memory leak in edje_edit_image_usage_list_get
Summary:
freeing iterator when necessary

@fix

Reviewers: Hermet, seoz, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1868

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-01-14 14:57:02 +01:00
Mike Blumenkrantz 3ada34f2b3 edje shadow warning--
added in c501f2ce

ref D1768
2015-01-06 14:56:39 -05:00
Cedric BAIL bc34291e67 edje: Edje_Edit - add Proxy to Edje_Part_Collection_Directory_Entry initializatoin.
Summary:
Add proxy while init Edje_Part_Collection_Directory_Entry at edje_edit_group_add and edje_edit_group_alias_add.

@fix

@fix

Reviewers: Hermet, seoz, cedric, raster

Subscribers: reutskiy.v.v

Projects: #efl

Differential Revision: https://phab.enlightenment.org/D1846

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-01-06 12:43:03 +01:00
Cedric BAIL a5183ee424 edje: Edje_Edit - add API for renaming of image.
Reviewers: Hermet, raster, seoz, cedric

@feature

Subscribers: reutskiy.v.v

Projects: #efl

Differential Revision: https://phab.enlightenment.org/D1830

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-01-05 10:54:11 +01:00
Cedric BAIL 93da127573 edje: Edje_Edit - remake deletion and replacing of strings
Summary: Add new function for replacing string with using eina_stringshare_replace() and change _edje_if_string_free() to setup passed string to NULL.

@fix

Reviewers: raster, Hermet, seoz, cedric

Reviewed By: cedric

Subscribers: reutskiy.v.v

Projects: #efl

Differential Revision: https://phab.enlightenment.org/D1835

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-01-05 10:52:59 +01:00
ChunEon Park 3f9d952774 Edje_Edit: Add sound samples into generated code for the group.
Summary:
Include sound samples, that uses in programs of this group in collections block.
@fix

Reviewers: cedric, Hermet, raster, reutskiy.v.v

Projects: #efl

Differential Revision: https://phab.enlightenment.org/D1824
2014-12-29 12:01:21 +09:00
ChunEon Park 671b04faee edje/edje_edit: remove unrelated call 2014-12-26 10:21:32 +09:00
Andrii Kroitor 4d0695d284 edje: fix memory leak in edje_edit_source_generate.
Reviewers: cedric, seoz, Hermet, raster, reutskiy.v.v

@fix

Reviewed By: reutskiy.v.v

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1821

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-12-25 21:57:57 +01:00
Mykyta Biliavskyi eae8a62009 edje: add tween images into generated code for the group.
Summary:
Include images, that uses as tweens in parts in Edje_Edit.
@fix

Reviewers: raster, Hermet, reutskiy.v.v, cedric

Reviewed By: reutskiy.v.v, cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1819

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-12-25 21:51:25 +01:00
Vyacheslav Reutskiy 2eebeb8b61 edje: edje_edit - add getter/setter for anti_alias attribute 2014-12-24 11:17:03 +00:00
ChunEon Park 382c41e42d edje: support anti_alias option
set anti_alias in part section.
default is enabled.

part { name: "test";
   type: XXX;
   anti_alias: 0;
   ...
}

@feature
2014-12-24 16:29:49 +09:00
Kateryna Fesyna 56a8f13e5c edje: Edje_Edit - add generation of 'filter' parameter of program
Reviewers: raster, Hermet, cedric

@feature

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1749

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-12-12 04:37:45 +01:00
Andrii Kroitor d2d35a66b4 edje: Edje_Edit - add API for program actions PLAY_SAMPLE and PLAY_TONE
Summary:
Added initialisation, deletion, getters and setters for following
programs fields: sample_name, speed, channel, tone_name, duration.

@feature

Reviewers: cedric, seoz, Hermet

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1753

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-12-12 04:33:30 +01:00
Maksym Volodin c501f2ce11 edje: Edje_Edit - generate alias parameter for 'parts' block.
Summary: add alias parameter to code generation.

@feature

Reviewers: raster, Hermet, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1768

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-12-12 04:20:21 +01:00
Maksym Volodin 4abdd758f0 edje: Edje_Edit - generate missed properties of 'text' block
Summary:
missed souce, text-source, repch, size_range, style are added.
TODO is added for filter property.

Reviewers: Hermet, raster, cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1754

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-12-10 03:52:52 +01:00
Maksym Volodin f83d23a327 edje: Edje_Edit - generate 'perspective' block
Summary: Adds focal and zplane perspective to the part when generating an EDC.

Reviewers: Hermet, raster, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1742

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-12-09 03:13:56 +01:00
Kateryna Fesyna 2f8121d66e edje: Edje_Edit - add generation of missed properties of 'image' block.
Summary: add generation of missed parameters: scale_hint, border_scale and border_scale_by.

Reviewers: Hermet, cedric, raster

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1741

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-12-09 03:13:56 +01:00
Kateryna Fesyna cccd1b25d4 edje: add formating for floating point numbers in EDC.
Summary:
this commit contains calculation of format string for floating point numbers in order to print them with at least one symbol after point. (For example: 'relateve: 1.0 0.45;')
@fix

Reviewers: cedric, Hermet, raster, reutskiy.v.v

Reviewed By: reutskiy.v.v

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1653

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-11-14 07:03:25 +01:00
Kateryna Fesyna 35ac38e880 edje: fix wrong generation of 'minmul' and 'text.min' parameters in EDC.
Summary:
minmul: add check of 'minmul.have' value and fix check on default vales of minmul (0.0 0.0 -> 1.0 1.0)
min: delete quotation marks from 'w' and 'h' values

@fix

Reviewers: Hermet, raster, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1658

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-11-14 06:58:25 +01:00
Kateryna Fesyna f5d5071210 edje: Edje_Edit - add generation of 'limits' parameter of group in EDC.
Summary: the generation of limits of group is added with this commit.

@feature

Reviewers: Hermet, cedric, raster

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1659

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-11-14 06:53:58 +01:00
Kateryna Fesyna 8ceef8c6ca edje: Edje_Edit - fix segfault on copying state of IMAGE part with twins
Summary:
The copying of state of IMAGE part with twins caused the sefmentation fault due to the extra memory freing in _edje_edit_part_state_copy() that is deleted with this commit.
The data that is freed was previously copied from the structure of state 'from' and freeing of this data leads to freeing data of 'from' part.
Later, on copying of tweens to 'to' state array of tweens appears segmentation fault because we try to access freed data of 'from' state.

@fix

Reviewers: cedric, Hermet, raster, seoz

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1636

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-11-06 06:18:38 +01:00
Kateryna Fesyna 41ea6e81d6 edje: Edje_Edit - fix segfaults on restacking of text parts with set 'text_source'.
Summary:
This commit fixes segfault on restacking text parts with set 'text_source'
that is caused by wrong updaiting of 'text_source' IDs on restacking of parts due to typo.

@fix

Reviewers: Hermet, seoz, raster, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1646

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-11-06 06:04:43 +01:00
Vyacheslav Reutskiy 890ad5dd95 edje: edje_edit - fix posible resource leak
Fixes: https://phab.enlightenment.org/T1760

@fix
2014-10-27 10:28:25 +00:00
Vyacheslav Reutskiy 4d7c0fe3d9 edje: edje_edit - don't unlick(NULL)
Summery: fix, posible to delete file by 'NULL' path (T1760)

@fix
2014-10-27 09:21:45 +00:00
Kateryna Fesyna f8db9a85fb edje: Edje_Edit - fix edje_edit_state_aspect_pref_set() function to setup Source and None aspect preferences
Summary:
This commit fixes check of passed value of aspect preference in edje_edit_state_aspect_pref_set() because it ignores None and Sorce values.
@fix

Reviewers: reutskiy.v.v, Hermet, raster, cedric

Reviewed By: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1542

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-10-20 17:30:57 +02:00
Maksym Volodin 9eb1093424 edje: Edje_Edit - add state alloc for PROXY part.
Summary:
To allow edje_edit_state_add work properly for PROXY part, EDIT_ALLOC_POOL for PROXY is added.
@fix

Reviewers: Hermet, seoz, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1545

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-10-18 13:48:51 +02:00
Kateryna Fesyna dad54f4f75 edje: Edje_Edit - fix edje_edit_image_usage_list_get() to return usage list with images with USER compression.
Summary:
add recalculating of image id in edje_edit_image_usage_list_get() to fix wrong behavior of this function when the image has USER compression.

@fix

Reviewers: Hermet, cedric, raster, reutskiy.v.v

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1547

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-10-18 13:47:30 +02:00
Igor Gala 7366caab1a edje: Edje_Edit - get the source name of the sample
@feature

Reviewers: cedric, Hermet, seoz, raster, reutskiy.v.v

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1546

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-10-18 13:44:30 +02:00
Vitalii Vorobiov d8955625ce Edje_Edit: creating new hash in global data if it is not created yet
Summary: edje_edit_data_add doesn't work if loaded EDJ file doesn't contain
any data items. It can't add new data item to emptry (NULL) hash.
Now, if there is no data in EDJ yet (so hash is empty), by adding new data it
will create hash and after that will add new data.

@fix
2014-10-13 16:57:08 +03:00
Tom Hacohen a7560dbc61 Eo: Change eo_add/del/unref behaviour.
Before this change eo_add() used to create an object with 1 ref, and if
the object had a parent, a second ref.
Now, eo_add() always returns an object with 1 ref, and eo_add_ref()
    preserves the old behaviour (for bindings).

eo_unref now un-parents if refcount is 0, and eo_del() is an alias for
eo_unref (will change to be a way to ensure an object is dead and goes
        to zombie-land even if still refed).
2014-09-25 17:38:45 +01:00
Igor Gala 6baada490e edje: Edje_Edit - get the buffer with sound's data
Summary:
add opportunity get the buffer with sound data for certain sound
from the given edje object. It is needed to play some sound with logic API.
@feature

Reviewers: Hermet, raster, seoz, reutskiy.v.v, NikaWhite, cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1422

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-22 14:59:27 +02:00
Andrii Kroitor d4f92b987f edje: Edje_Edit: fixing text properties setting
Summary:
edje_edit_state_text_source_set shouldn't replace existing text.
edje_edit_state_text_set should update text in other parts, that are using given part as text.text_source

Reviewers: seoz, Hermet, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1463

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-22 14:59:27 +02:00
Andrii Kroitor 51a5f852c2 edje: Edje_Edit: add missing part type checks
Summary: added necessary type checks before using typedata

Reviewers: seoz, Hermet, cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1464

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-22 14:59:27 +02:00
Andrii Kroitor 520809864d edje: Edje_Edit - add edje_edit_program_transition_state_set
Summary:
Set parts into intermediate state of programs transition.
0.0 represents the start state, 1.0 - the final state. Other values will set
parts to an intermediate state taking into account programs transition type.

Reviewers: seoz, Hermet, cedric

Reviewed By: cedric

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1435

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-12 23:04:53 +02:00
Andrii Kroitor 38561202bf edje: Edje_Edit - add edje_edit_program_stop_all
Summary:
Stops all running programs. If any program has "after" field its value
will be ignored.

Reviewers: cedric, seoz, Hermet

Subscribers: cedric, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D1433

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2014-09-12 23:00:52 +02:00
Stefan Schmidt a7fb8cd7fe edje_edit: Use eina_file_mkstemp() to avoid problems with umask
CID 1039613
2014-09-11 11:55:49 +02:00
Stefan Schmidt debb51e5df edje_edit: Check return of _edje_part_description_find_byname
If this retruns NULL we would do a NULL deref some lines below. Better check.

CID 1222458 1222457
2014-09-04 15:09:17 +02:00
Stefan Schmidt ffd1031d2b edje_edit: Another instance where we need to check the return of eet_list
Return could be NULL so check here before derefenrcing ent.

CID 1224764
2014-09-04 14:44:33 +02:00
Stefan Schmidt 703d179eb6 edje_edit: Check return value of eet_list() to avoid NULL dereference.
We check eet_list elsewhere and it might retrun NULL. Don't just hope
keys will never be NULL. Check it.

CID 1232733
2014-09-04 14:20:56 +02:00
Stefan Schmidt cfba724a37 edje_edit: Check return of _edje_edit_edje_file_save and close files if we fail
We check the retrun of _edje_edit_edje_file_save everywhere else and should do
here as well.

CID 1224759
2014-09-04 11:28:33 +02:00