Commit Graph

60 Commits

Author SHA1 Message Date
Elyes HAOUAS 3e7f317313 Fix typos
Fix some typos

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D12015
2020-06-25 09:03:05 +02:00
Elyes HAOUAS 0a0bba64c7 Get rid of trailing whitespaces (6 / 14)
Remove whitespaces
Differential Revision: https://phab.enlightenment.org/D12004
2020-06-23 10:29:37 +02:00
Hermet Park 2663dceaf1 Revert "edje: code refactoring for readibility."
This reverts commit 7fb47fc064.

subsequential revert for previous one.

90a89d1ab2b5d23b29ad0f2680b77b5ba7f56b42.
2018-06-21 19:33:41 +09:00
Hermet Park 7fb47fc064 edje: code refactoring for readibility.
collection.part is too ambigious, since group has parts as well.
Normally we regard it as "name" (of group) instead of part.
2018-06-07 17:53:12 +09:00
Derek Foreman 1982046315 edje: Pass extra signal data to program_run
Summary: Depends on D6114

Reviewers: zmike, cedric

Reviewed By: zmike

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D6115
2018-05-08 12:26:13 -05:00
Jean-Philippe Andre 46001cde38 edje: Remove use of smart clipped data
This removes dependency on a legacy structure.
Edje object does not change the smart data, unlike evas box and grid.
2017-09-13 09:57:05 +09:00
Carsten Haitzler 432b9b1dcd edje - add embryo echo command for debugging
finally add one...

@feature
2017-08-05 14:47:25 +09:00
Mike Blumenkrantz 4c431c8b9c edje: add set_pointer_mode() to embryo functions
this should probably be a description-level property
2017-06-09 20:06:48 -04:00
Jee-Yong Um 57c14f1c55 edje: fix cached edje modification issue
Summary:
_edje_part_***_set/get (for mouse_events, repeat_events, ignore_flags, mask_flags)
overwrite cached edje value. These behaviors affect all edje object added after
these changes, and result in not intended.

@fix

Reviewers: jpeg, cedric

Subscribers: akanad, woohyun

Differential Revision: https://phab.enlightenment.org/D4362

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2017-02-07 15:14:54 -08:00
Bruno Dilly 65723a190a edje: clean erroneous documentation
Not implemented functions
2016-12-21 23:03:33 -02:00
Bruno Dilly 9bc9fde90e edje: add function on embryo to control focus
Add set_focus(part_id) and unset_focus().
Both functions accept an optional argument "seat_name".
If not provided default seat will be assumed.
2016-12-21 23:03:33 -02:00
Carsten Haitzler 8c28a70b43 Revert "edje edje_embryo: use strncpy()."
This reverts commit 06bd8dcf33.

just dismiss in coverity if the code is not actually wrong
2016-09-22 08:31:00 +09:00
Hermet Park 06bd8dcf33 edje edje_embryo: use strncpy().
This change is not meaningful but avoids an annoying coverity detection.
2016-09-21 15:03:11 +09:00
Carsten Haitzler 419f84907b edje - fix missing vector field frees, copies, handling etc.
it seems vector type parts were not handled all that well. we had at
least one mem leak with the vector mempool never being freed... so i
filled in various missing points where vector parts were not being
handled right.

@fix
2016-08-21 11:30:45 +09:00
Jinyong Park 471a328ea0 edje_embryo: add function to know swallow has object
Summary:
Using edc script, there is no way to know evas object is set on swallow part or not.
So, to know that, some elm widget send signal and save some information to edc variables when object is set on swallow part.
I think it is helpful to make better edc script.

@feature

Reviewers: herb, cedric, raster, id213sin, jpeg

Reviewed By: jpeg

Subscribers: jpeg

Differential Revision: https://phab.enlightenment.org/D4176
2016-08-16 16:14:21 +09:00
Carsten Haitzler 1d6a58cfc9 edje - save memory on edje parts as a lot of over-allocation was done
so ... Edje_Calc_Params was huge ... like about 200 bytes. every part
in every live edje object got one of these in addtion to real part
struct info etc. ... so really every part was probably consuming
300-500 bytes or so... crazy. so i made a lot of the data now optional
so only the minimum required is allocated now which cuts down about 110
or even 120 bytes per part, depending. 100 bytes was needed for 3d
node parts even though almsot no parts are 3d node parts... the image
and text data was 30-40 bytes so we consumed 100 even if we only used
30-40... so this cuts that done and puts in polace calc param cleanup
funcs everywhere they are needed to clean up this extra allocated data.

i also reduced this even more by maping pointers to req_drag, map and
physics and clip_to fields in another extension struct cutting
down another 28/52 bytes on most parts (in  return for an added
4/8 bytes - on 32/64bit accordingly).

in elementary_test this saves about ~300kb of ram for just having the
etst run and displaying (peak memory measuremment). so massif says
10.6M -> 10.3M.

@optimize
2016-08-15 09:21:08 +09:00
Carsten Haitzler 1d0b500fa8 edje - reduce memory footrpint by dlopening ephysics on demand
this saves about another 80Kb or so in dirty pages by only loading
ephysics when needed. This removed ephysics and bullet library dirty
pages from the process space. this is another patch to address T4227.

@fix
2016-08-01 19:11:39 +09:00
Jean-Philippe Andre cdc8d15a5c edje: Add missing 'break' in edje_embryo switch
Fixes CID: 1352521 1352522 1352523 1352524 1352525

See 4ed9b8325
2016-07-13 15:34:17 +09:00
Jee-Yong Um 4ed9b83258 edje_embryo: add box attributes support to set_state_val()
Summary: Add box attributes support to set_state_val().

Reviewers: raster, cedric

Reviewed By: cedric

Subscribers: jpeg

Differential Revision: https://phab.enlightenment.org/D3734

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2016-03-04 16:09:51 -08:00
Mike Blumenkrantz 2cf1f0e6e3 edje: clear pending programs upon calling stop_programs_on()
pending programs have not started yet, so they are not directly attached
to the part. failing to remove them results in unexpected behavior from programs

ref 71ce70bc3f

@fix
2016-02-19 13:24:30 -05:00
Shinwoo Kim 1aafaca172 Edje: enhance embryo stack broken error message
Summary: Enhance embry stack broken error message

Test Plan: Make a run_program run a script

Reviewers: raster, zmike, jpeg

Reviewed By: jpeg

Subscribers: cedric, seoz, jpeg

Differential Revision: https://phab.enlightenment.org/D3528
2016-01-13 14:50:58 +09:00
Vivek Ellur abe131d1d7 edje_embryo: Fix null dereference issue
Summary:
Fix Coverity issue ID 1299026

Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>

Reviewers: cedric, raster

Reviewed By: raster

Subscribers: raster, cedric

Differential Revision: https://phab.enlightenment.org/D3218
2015-12-23 19:12:07 +09:00
Andrii Kroitor d595149178 edje: fix internal colorclass field
Summary:
Its value is never modified directly and should not be modifiled by mistake
in future.

@fix

Reviewers: Hermet, raster, reutskiy.v.v, cedric

Reviewed By: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D3104

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-09-23 12:34:22 -07:00
Jee-Yong Um 815ebc0b0e edje_embryo: add methods to handle event flags.
Summary:
Add embryo methods that change the state
whether Edje_Part will handle Evas_Event or not.

Reviewers: Hermet, woohyun, cedric

Reviewed By: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D2807

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-08-04 17:34:30 +02:00
Daniel Kolesa 9d4e9f1788 edje: fix extra parens warning with clang 2015-06-29 14:19:57 +01:00
Jee-Yong Um ef491e697e edje: implement methods for mouse_events with edje_part for Edje Embryo script.
Summary:
In edje_embryo.c, there are the list for supported methods in script.
However, methods listed from line 175 to 188 don't exist actually.
This patch implements 4 methods among them.
   set_mouse_events(part_id, ev)
   get_mouse_events(part_id)
   set_repeat_events(part_id, rep)
   get_repeat_events(part_id)

Reviewers: Hermet, woohyun, cedric

Reviewed By: cedric

Subscribers: cedric, Hermet

Differential Revision: https://phab.enlightenment.org/D2766

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-06-25 17:21:09 +02:00
Jee-Yong Um 4baea66956 edje_embryo: correct type mismatching in get_geometry() method
Summary:
get_geometry() method calls edje_object_part_geometry_get() internally,
and the type of its arguments is Evas_Coord. (typedef'ed integer)
However, comment says that method require Float type as its arguemnts,
and get_geometry() initializes Evas_Coord variables as 0.0.
This patch corrects type mismatching and comment.

@fix

Reviewers: Hermet

Subscribers: cedric, Hermet

Differential Revision: https://phab.enlightenment.org/D2754
2015-06-25 13:38:25 +09:00
Chris Michael 38698de564 edje: Fix Coverity CID1299026 and CID1299027: Explicit null dereference
Summary: Coverity reports that this potentially is passing a NULL
pointer to strcmp. As the GETSTR macro Can possible return NULL we
should be checking that return before passing it to strcmp.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-06-18 10:30:45 -04:00
Mike Blumenkrantz 172a0ccf0c edje: reformat all C files
this has been unreadable for years due to the french tabber.
2015-06-08 14:43:00 -04:00
Chris Michael a9e7dbf282 edje: Remove unused variables
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-05-18 10:13:07 -04:00
kumar navneet 4db130a680 edje: add set_state_anim API to embryo script.
Summary:
Issue: Current embryo script do not provide any mechanism to set transition type in animation
Solution: A new API set_state_anim is added.

Signed-Off by: Kumar Navneet <k.navneet@samsung.com>
Signed-Off by: Shilpa Singh <shilpa.singh@samsung.com>

Test Plan: A test edc (embryo_set_state_anim.edc) is added to edje examples to test set_state_anim API.

Reviewers: shilpasingh, raster, cedric

Reviewed By: cedric

Subscribers: poornima.srinivasan, cedric

Differential Revision: https://phab.enlightenment.org/D2470

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-05-18 11:04:11 +02:00
kumar navneet c38e477364 set_tween_state_anim API added.
Summary:
Issue: Current embryo script do not provide any mechanism to set transition type in animation, by default supports only linear
e.g: set_tween_state API
Solution: To not break backward compatibility, a new API set_tween_state_anim is added in which we can even specify type of transition required.

Signed-Off by: Kumar Navneet <k.navneet@samsung.com>
Signed-Off by: Shilpa Singh <shilpa.singh@samsung.com>

Test Plan: A test edc (embryo_tween_anim.edc) is added to edje examples to test set_tween_state_anim API.

Reviewers: raster, cedric, shilpasingh, Hermet

Reviewed By: shilpasingh

Subscribers: poornima.srinivasan, SubodhKumar, rajeshps, cedric, govi

Differential Revision: https://phab.enlightenment.org/D2344
2015-05-18 15:22:02 +09:00
katpavalli dca95fb45a edje: support translation on static strings in edc.
Summary:
   Internationalisation of the static text specified as part of the edc is implemented.
   Problem: Static text when specified in the edc, remains unchanged when the system language is changed.
   Solution: Language support is provided even for the static strings in the edc.

Test Plan:
   Test code to test this implementation is done as part of efl/src/examples/edje/edje-text.c and efl/src/examples/edje/text.edc
   Compile the code with the below  command
   edje_cc -md <dir path>/efl/src/examples/edje/ text.edc && gcc -o edje-text edje-text.c `pkg-config --libs --cflags ecore-evas edje evas ecore`
   ./edje-text

   1) change the language of the system using the command
      export LANGUAGE=hi
      ./edje.text

      Not the text Loading gets displayed in hindi language

   2) change the language of the system using the command
      export LANGUAGE=ta
      ./edje.text

      Not the text Loading gets displayed in tamil language

   3) change the language of the system using the command
      export LANGUAGE=en
      ./edje.text

      Not the text Loading gets displayed in english language
As the number of .mo files in the /edje folder can be increased, those many languages can be supported

Reviewers: cedric, shilpasingh

Reviewed By: shilpasingh

Subscribers: cedric, rajeshps, govi, poornima.srinivasan

Differential Revision: https://phab.enlightenment.org/D2336

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
2015-05-14 18:41:47 +02:00
Jean-Philippe Andre e88fe439f0 Edje embryo: Fix invalid check for get_state_val (text str)
@fix
2015-04-29 13:38:58 +09:00
zmike 71ce70bc3f edje embryo stop_program() should stop pending actions
ACTION_STOP already does this

@fix
2014-09-04 21:08:08 -04:00
Amitesh Singh 17e2c4bc06 edje embryo: Now supports get_anim_pos_map
Summary:
works just like ecore_animator_pos_map().

@feature

Reviewers: seoz, Hermet, cedric, raster

Subscribers: cedric, seoz

Differential Revision: https://phab.enlightenment.org/D1211
2014-07-23 14:31:52 +09:00
Mike Blumenkrantz 939f2eea7f edje now has the group.script_recursion flag for permitting unsafe embryo recursion
this is enabled for all scripts within a group, and it should only be used if you:

1) know what you are doing

2) know why this is unsafe (T905)

@feature
2014-04-25 10:52:15 -04:00
Mike Blumenkrantz cefebd4921 edje now alerts the user to its failure when running recursive embryo programs 2014-04-21 10:05:26 -04:00
Yossi Kantor 2be615916a Eolian: Integration of Edje and Edje Edit 2014-03-24 08:14:30 +02:00
Tae-Hwan Kim 3061a706c4 Add new PLUGIN_RUN action type and new plugins.plugin handlers 1. If external library is commerical source and not opensource, we cannot include/build the library within edje. 2. If external library does not use general encodable sources, we...
Summary:
...cannot encode those things into edje.

In our case, we need vibration when longpressed. But those files are not
audio or image and cannot be encoded into edje. Also, this library is not
opensource so should not be linked directly with edje.
So we should call vibration API by using this plug-in.

Reviewers: raster, cedric, seoz, Hermet

CC: cedric

Differential Revision: https://phab.enlightenment.org/D588
2014-03-20 13:00:21 +09:00
Carsten Haitzler db1990020a edje - feature - add channel types for sounds and ability to mute them
this adds a new feature to be able to assign a sample to a given
"type" of audio channel, and then to be able to mute these from code.
2014-02-09 19:08:12 +09:00
zmike c3ece04211 edje embryo reset timer should probably call the reset function 2014-02-03 18:23:50 -05:00
zmike 0ee6327035 edje embryo now supports reset_timer()
works the same as ecore_timer_reset()
2014-02-03 17:19:31 -05:00
Vyacheslav Reutskiy 641d823cbb edje: edje_calc - update _edje_part_description_find
Add to fuction prototype new param: Eina_Bool approximation.
If need exact matching state name and value set EINA_FALSE to
'approximate'. In other cases used EINA_TRUE.

Reviewers: cedric, raster, seoz

CC: cedric

Differential Revision: https://phab.enlightenment.org/D400

Signed-off-by: Cedric BAIL <cedric.bail@samsung.com>
2013-12-23 10:47:32 +09:00
Otavio Pontes afd8a238d1 Adding the cubic-bezier curve to edje transitions
Summary: Adding an option to use a cubic-bezier curve in edje transitions.

Reviewers: Sachiel, cedric, raster

Reviewed By: raster

CC: raster

Differential Revision: https://phab.enlightenment.org/D319
2013-12-02 15:02:40 +09:00
ChunEon Park c28f08a477 edje - use Eina_Bool. 2013-11-21 13:00:55 +09:00
Jaehyun Cho 73cab19a78 [edje_embryo] Fix play_sample's parameter count check
play_sample function requires 2 parameters however it checks parameter count as 1.
2013-08-28 07:53:57 +09:00
Mike Blumenkrantz 4ea0e29c6f add embryo params for proxy src visible/clip
hermet please look at these, they don't seem to work right for some reason
2013-05-31 15:28:57 +01:00
ChunEon Park f87c050342 edje - indent fix. 2013-05-31 16:53:04 +09:00
Mike Blumenkrantz f224eaae11 add embryo fill support for proxy parts 2013-05-09 10:26:40 +01:00