a4f3074f9c
elm: Removed unnecessary null check for ecore_timer_del,
...
ecore_animator_del, and ecore_job_del.
As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
2014-01-21 23:18:16 +09:00
068c9a095f
toolbar: Do not check ev->string for Return key and react on space key.
...
space key works as same as Return key.
2014-01-21 19:58:10 +09:00
3379c124df
all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
...
There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
2014-01-21 11:08:29 +02:00
5e46f2ff6d
toolbar: Check whether icon is null before sending signal
...
There are warnings when icon is null since rELM4c3e23de9e46.
2014-01-14 21:46:27 +09:00
fd5c046dfe
elm: Changed __UNUSED__ to EINA_UNUSED.
2014-01-06 23:33:57 +09:00
16f687b87a
multibuttonentry, genlist, layout, toolbar: Fixed dereference of null
...
pointers which were reported by clang builg.
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-XZo1hW.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-isAlRt.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-8Ascv8.html#EndPath
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-gBkVuE.html#EndPath
2014-01-06 23:26:46 +09:00
2942212cb3
toolbar: Fixed dead assignment reported by clang build.
...
https://build.enlightenment.org/job/nightly_elm_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-05-1/report-0ipfss.html#EndPath
2014-01-06 23:14:14 +09:00
e63dd3110a
elm: Unified eina critical manro to CRI.
...
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
2013-12-26 13:03:55 +09:00
6d71a23c3a
elm lib: removed all the unnecessary empty lines.
...
being pedantic.
2013-12-15 06:18:35 +09:00
88a8c46af3
ctxpopup, player, slideshow, spinner, toolbar, video: internal refactoring of smart event routines.
...
Now most of smart events codes look consistent.
2013-11-13 10:29:30 +09:00
5567837cf5
button,check,colorselector,diskselector,flipselector,image,radio,toolbar: fixed formatting of smart_event functions before working on it.
...
Now they look more consistent.
2013-11-13 09:54:37 +09:00
2f1e1554e5
Changed Eo class names to be consistent.
...
All the class names are now of the format: Elm_Type_Subtype_Extra
2013-11-07 11:44:22 +00:00
d22076681b
elm: Fixed formatting about smart_event check for code consistency.
...
- Made it look clearer.
- Removed unnecessary local variables.
- Keep the code sequence consistent.
2013-10-28 23:30:12 +09:00
Jaehyun Cho
db2d711d64
[elm_widget] Enable not to add resize object to or delete resize object from sub object when the resize object is set.
...
Summary: Add one more argument, 'Eina_Bool sub_object' to elm_widget_resize_object_set. If the argument, 'sub_object' is set as EINA_TRUE, the new resize object is added to the sub object and the previous resize object is deleted from the sub object.
Reviewers: Hermet, seoz
CC: Jaehyun_Cho, seoz, raster
Differential Revision: https://phab.enlightenment.org/D265
2013-10-17 01:19:40 +09:00
e82477ab29
elm_toolbar.c: adopted ELM_WIDGET_DATA_GET_OR_RETURN macro.
2013-10-05 17:15:58 +09:00
29af5e1e43
elementary: update to new eo_parent_get/set API.
2013-09-25 13:34:27 +09:00
d461a8be05
elementary/widgets - set parents before widget constructs their body.
...
This avoids unnecessary multiple setups when obj and subobj has connected.
2013-08-27 14:19:19 +09:00
c5b0d63838
fixed documentation for consistency. Gets -> Get.
...
Occurance of Get is super much higher than Gets.
So change Gets to Get for consistency.
2013-08-22 05:24:46 +09:00
Carsten Haitzler
59e8bc5a35
Fix elm to use key not keyname (so xmodmap works)
2013-07-31 15:16:41 +09:00
c47ef1b7fe
[access] use proper name _elm_access_info_get(); not _elm_access_object_get(); to get access information
2013-07-31 12:57:49 +09:00
7bbcf8a271
elm_toolbar.c: check reorder_from at the start of _items_change. reorder_from is used here and there.
...
this fixes dereference before null issue which was spotted by coverity. CID 1039999.
2013-07-06 12:26:59 +09:00
32affd3725
added callback call "scroll", "scroll,anim,start", "scroll,anim,stop", "scroll,drag,start", "scroll,drag,stop"
...
in toolar widget.
2013-07-03 13:57:17 +09:00
6cf684f02a
elm: added more "focused" and "unfocused" documentations.
...
genlist, hover, index, list, map, photocam, progressbar, radio, scroller, slider, slideshow, spinner, toolbar, win.
2013-06-10 14:13:55 +09:00
8bfdbd2ba6
elm: all the focusable widget now emits "focused" and "unfocused" smart callbacks.
...
1. documentations, NEWS, and ChangeLog will be updated later after some more test.
2. need to check entry.
2013-06-07 01:13:37 +09:00
4355c54715
elm_toolbar.c: ELM_SAFE_FREE adoption.
...
I splited ELM_SAFE_FREE refactoring patches. One commit per each file as recommended.
For the detail, please refer 3072dab12f12fe83fb5a628d15efd5cded11787f.
2013-05-29 21:08:50 +09:00
5f053bf79a
elm: refactoring. use more ELM_FREE_FUNC.
2013-05-23 15:54:49 +09:00
5eda949b8f
[toolbar] fixed code for verification(ecore_job_add)
...
make a pair for job event, check the event is alive before adding event.
2013-05-22 16:55:23 +09:00
ac25946a19
elm: introduce ELM_FREE_FUNC for code quality enhancement.
...
There are pros and cons but this
1. reduces human mistakes.
2. enhances readability.
3. enhances code quality.
4. removes future bug.
5. was adopted from enlightenment.
This is not all. I will work on enhancing elementary more and more.
2013-05-22 02:24:02 +09:00
Carsten Haitzler
df9f486bdb
toolbar needs to be able to adjust better to layout
...
as part of 1.8 review... elm toolbar really should add some signals so
theme can adjust better.
2013-05-10 16:53:34 +09:00
c929b33052
elementary: properly sanitize headers order.
2013-05-03 16:07:06 +09:00
187d6bf8de
Elementary: replace eo_data_get for objects data referencing.
2013-05-01 11:04:09 +03:00
7edc0d056e
elm_toolbar.c: refactoring. reuse api return value.
2013-04-30 00:50:35 +09:00
8e85586ebe
elementary/toolbar - fix toolbar item clip problem on reordering items.
2013-04-29 18:35:32 +09:00
ff10726141
elementary/ctxpopup, hoversel, naviframe, multibuttonentry, popup, diskselector, list, menu, segment_control, toolbar - support widget item language change
2013-04-23 20:30:15 +09:00
cb86345c1d
Scroll to highlighted item in toolbar. This is related to ed93aa20588633d36bfcdf6e3b093923be65f4d8.
2013-04-16 21:06:11 +09:00
633be421a5
[Toolbar] Add the feature for key events.
2013-04-15 14:34:15 +09:00
ba4dbce9d9
elm: enhance eina_list_free usages. use EINA_LIST_FREE if needed.
2013-04-10 20:28:35 +09:00
74b3eed5fd
elm: print the error message inside elm_widget_sub_object_add().
...
1. Do not need to print the same error message from all the widget codes.
2. Even though elm_widget_sub_object_add() can be used internally, there should be no error message at all.
Elm devs should fix it beforehand.
So it looks ok to print the error message in elm_widget_sub_object_add() to force elm devs to fix it.
3. Got additional code cleanups.
2013-04-03 11:28:53 +09:00
9636ed621c
Remove warning in toolbar
2013-03-21 15:14:23 +09:00
47e280d21b
toolbar: fix icon size not being initalized.
2013-03-20 11:57:22 +09:00
d75cb616da
Change usage of eo_do_super to the new prototype.
2013-03-18 16:15:12 +00:00
c9534bab25
toolbar: Use snprintf for elm,number,item buffer handling
...
Avoid potential buffer overflow
Signed-off-by: Daniel Willmann <d.willmann@samsung.com>
2013-03-18 12:13:50 +00:00
e9313c9525
Fix the toolbar cannot be unselected when it's mode is ELM_OBJECT_SELECT_MODE_ALWAYS.
2013-03-08 17:21:38 +09:00
ea9fe742a0
[access][toolbar] use proper access activate callback
2013-03-07 21:33:26 +09:00
8ed79613c5
Add edje_object_message_signal_process before edje_object_size_min_restricted_calc.
...
If the min size is changed by edje signal in edc, the the function should be called before the calculation.
This commit is related to 40dc2a25c72103c3b01620830e1bde964f96b2fa
2013-03-05 16:47:07 +09:00
621775dad2
Revert this commit to fix the problem by the other method.
...
Revert "Small bug. In some case, the box cannot be proper size."
This reverts commit ca95166f9a8cb7db8c1557d75f444d76772b2176.
2013-03-05 16:27:44 +09:00
962b965563
Typo. Sync a variable name with others
2013-03-05 14:49:29 +09:00
312d0217a0
An internal layout error, on a widget set, is a CRITICAL error.
2013-03-01 23:04:31 -03:00
844b5805ff
elementary/widget - don't handle tthe resize objects in widget infrastructure. Acutally these resize objects are sub objects so we don't need to care them separately. This caused overhead in some cases(ie, theme change)
...
SVN revision: 83990
2013-02-16 13:39:59 +00:00
2a4a111289
Add the reorder effect in Toolbar.
...
SVN revision: 83936
2013-02-15 05:37:53 +00:00
Daniel Juyung Seo
Yakov Goldberg
Ryuan Choi
Daniel Juyung Seo
Tom Hacohen
Jaehyun Cho
Cedric Bail
ChunEon Park
Daniel Juyung Seo
Carsten Haitzler
Shinwoo Kim
Hosang Kim
Daniel Zaoui
Jaehwan Kim
Daniel Willmann
Gustavo Lima Chaves
Jaehwan Kim