Commit Graph

36 Commits

Author SHA1 Message Date
Cedric BAIL 77851c1891 ethumb: fix race condition and memory leak.
NOTE: that's a first obvious patch thanks to Gustavo reviews.
More work needed, but some decision should be discussed first.


SVN revision: 62265
2011-08-09 20:36:28 +00:00
Christopher Michael d39b302cee Ethumb: Add a bunch of UNUSED where needed.
SVN revision: 61622
2011-07-23 23:12:55 +00:00
Cedric BAIL 0408408e2a ethumb: fix various source of misusage.
SVN revision: 60760
2011-06-28 14:35:21 +00:00
Cedric BAIL 563fbf97f2 eina: update Eina_Refcount API to please Tasn.
SVN revision: 60592
2011-06-22 14:04:09 +00:00
Cedric BAIL 191c79c9e1 ethumb: break API to fix race condition during cancel.
SVN revision: 59846
2011-05-31 16:14:26 +00:00
Cedric BAIL c958177e51 ethumb: use Eina_Refcount.
SVN revision: 59039
2011-04-29 16:09:45 +00:00
Cedric BAIL 88745904b4 ethumb: cache exists result.
SVN revision: 59017
2011-04-28 17:00:13 +00:00
Cedric BAIL bcef93caba ethumb: make exists client API async.
Ethumb_Client now use Ecore_Thread with this patch.

TODO:
	* cache exists requests (client side).
	* cache generate requests (server side).



SVN revision: 58977
2011-04-27 18:06:42 +00:00
Chidambar Zinnoury 0f4ce94ecf ethumb: automagically orient thumbnails based on:
- metadata contained in files (EXIF only currently) - default active;
 - orientation given by the caller against pixel data orientation.
 Code is based on els_icon.

 Next is to add that through dbus.

 Open question: if orientation is specified, do we need to save the thumbnail in a different folder?


SVN revision: 52465
2010-09-19 17:07:35 +00:00
Rafael Antognolli 94540f3b5b Changing Ethumb license from LGPL3 to LGPL2.
Making this change to be in agreement with some other EFL libraries
under LGPL.



SVN revision: 52275
2010-09-14 23:02:45 +00:00
Sebastian Dransfeld a82e7511aa make clang happy
SVN revision: 45197
2010-01-15 20:51:01 +00:00
Jonathan Atton 3cadaace4f Ethumb: test if unique_name is not null, If I kill the daemon right after it is started, I have a segv. This patch fix it.
SVN revision: 43971
2009-11-25 12:43:27 +00:00
Vincent Torri 4d7149ffb1 fix DLL creation on Windows
SVN revision: 43495
2009-11-06 18:27:56 +00:00
Gustavo Sverzut Barbieri acc688873b logging: remove trailing \n
SVN revision: 42546
2009-09-17 14:31:29 +00:00
Gustavo Sverzut Barbieri bea73e88bd Ethumb improvements and more docs.
make some types unsigned int to better represent what they will
contain, fix dbus api to match so.



SVN revision: 42545
2009-09-17 14:05:04 +00:00
Gustavo Sverzut Barbieri 4be6ac7921 enable "make doc", improve doxygen support for client library.
Some methods are missing and the in-process thumbnail needs to be
done, the documentation is almost the same as the client, so I really
appreciate someone else do it :-)



SVN revision: 42541
2009-09-17 06:08:10 +00:00
Gustavo Sverzut Barbieri 5dc1e3900f more docs
SVN revision: 42538
2009-09-17 05:17:12 +00:00
Gustavo Sverzut Barbieri 97645fe7bc API BREAK: Fix Ethumb API to be more EFL-like
* Callbacks were named to help Vala bindings.
 * All callbacks get 'void *data' as first argument, always.
 * All async methods get free_data parameters and call them also on disconnect()
 * queue_remove() renamed to generate_cancel() to be more clear.
 * queue_clear() renamed tp generate_cancel_call() to be more clear.



SVN revision: 42445
2009-09-12 18:23:05 +00:00
Gustavo Sverzut Barbieri 992936af22 Update to match new EINA init/shutdown.
SVN revision: 42301
2009-09-06 22:23:04 +00:00
Gustavo Sverzut Barbieri e229b25826 loggify ethumb.
remove debug_level options as it is better handled by EINA_LOG_LEVELS
and EINA_LOG_LEVEL variables, for example:

  EINA_LOG_LEVEL=3 EINA_LOG_LEVELS=ethumb:4,ethumb_client=1

will show debug for ethumb (lib), just errors (no warnings) for
ethumb_client library and everything else shows "info".



SVN revision: 42261
2009-09-04 19:27:12 +00:00
Rafael Antognolli ffe70c5e07 Fix some memory handling issues:
* Ethumb_Client now calls free_data on clear() and queue_remove().
* disconnect() doesn't call clear() anymore.
* disconnect() free pending calls correctly.



SVN revision: 41377
2009-07-17 04:28:41 +00:00
Gustavo Sverzut Barbieri 473f5ea563 remove -Wextra warnings.
SVN revision: 41370
2009-07-16 21:49:14 +00:00
Gustavo Sverzut Barbieri c6b4e69225 zero pointers before failing.
SVN revision: 41347
2009-07-15 04:44:15 +00:00
Rafael Antognolli 26a3abe8ef Making ethumb_client_connect always call the connected_cb.
Now the callback is called even when it fails to create a get_name_owner
request.



SVN revision: 41323
2009-07-13 22:08:00 +00:00
Rafael Antognolli 31fc2b0dfa Added support to creating animated thumbnails from videos.
These thumbnails are generated using an edje template. Each thumbnail is
an edje file, that has a group called "movie/thumb"
The thumbnail can be animated by receiving a signal "animate" or "animate_loop"
(the last one being a loop animation that calls itself when finished), and
the animate_loop program can be stopped by receiving a signal "animate_stop".
The transition time is set based on the time of the animation (that is set
by the call ethumb_video_time_set()).



SVN revision: 41322
2009-07-13 19:38:17 +00:00
Rafael Antognolli 116c7d3266 Fixed wrong usage of dbus.
This was also the problem causing ethumb generated callback on the client
library always return with success=1 (see ticket #337).



SVN revision: 41287
2009-07-09 19:26:16 +00:00
Rafael Antognolli f9b765ec1c Added support to set quality and compress level.
SVN revision: 41286
2009-07-09 19:16:02 +00:00
Rafael Antognolli 5dc0fa41ef Added support to free_data callbacks.
Some functions that require callbacks and data passed to them now can
receive a free_data callback as argument too.



SVN revision: 41285
2009-07-09 19:14:29 +00:00
Rafael Antognolli 8f9dc79021 Fixed wrong usage of eina_list_remove_list on Ethumb_Client.
SVN revision: 41284
2009-07-09 19:11:57 +00:00
Viktor Kojouharov fca7b4aa43 return -1 on error instead
SVN revision: 40971
2009-06-08 15:44:43 +00:00
Viktor Kojouharov 06437b0e33 make the generated callback receive the thumb path and key
SVN revision: 40969
2009-06-08 15:29:52 +00:00
Gustavo Sverzut Barbieri b7d1bed838 start service by name requires one more parameter (flags).
The dbus api has a "flags" parameter that is now unused but may be in
future, it was missing and dbus was giving method mismatch.

I forgot to commit this but changed Ethumb_Client, then Viktor "fixed"
it by reverting such change. Now going back to my code and adding "0"
as flag.



SVN revision: 40968
2009-06-08 14:32:17 +00:00
Viktor Kojouharov e5ca756ffe fix the use of e_dbus_start_service_by_name
prevent id_count from being 0


SVN revision: 40963
2009-06-08 08:47:56 +00:00
Gustavo Sverzut Barbieri 19ebe43a04 start dbus service by its name if it's not up.
we still guess it was up and try to get its name, if not possible then
try to start it and then get is name.

another way to do it would be to always request start and just then
get its name and just then start to listen to NameOwnerChanged. But
the current way is good enough and should save some roundtrips for
good cases (server is up).



SVN revision: 40955
2009-06-07 21:20:37 +00:00
Gustavo Sverzut Barbieri 76d4b16942 move bit flags to end, use bitfield.
SVN revision: 40954
2009-06-07 20:47:28 +00:00
Rafael Antognolli aac69a080f Added ethumbd (ethumb).
ethumbd is a server waiting for requests of thumbnails via dbus. A client
library is also provided, avoiding dbus burocracy (and with an API similar
to ethumb).



SVN revision: 40899
2009-06-04 21:21:43 +00:00