Commit Graph

8 Commits

Author SHA1 Message Date
Lucas De Marchi aa31434d1f edbus: Remove useless defines
These values are used only using they directly are more meaninful than
those defines.



SVN revision: 80966
2012-12-14 16:28:55 +00:00
José Roberto de Souza 00e6dac1ac edbus: Fix bug found in refactored banshee example
Refactor edbus_signal_handler_add() so internal signal handlers don't
set the connection free callback. This fixes the bug in which
EDBus_Connection was freeing the signal handler of EDBus_Conenction_Name

==22814== Invalid read of size 4
==22814==    at 0x40564B0: edbus_signal_handler_del (edbus_signal_handler.c:278)
==22814==    by 0x4040E65: _edbus_connection_name_unref (edbus_core.c:507)
==22814==    by 0x404106B: edbus_connection_name_owner_monitor (edbus_core.c:520)
==22814==    by 0x4055F63: _edbus_signal_handler_clean (edbus_signal_handler.c:217)
==22814==    by 0x40564F8: edbus_signal_handler_del (edbus_signal_handler.c:279)
==22814==    by 0x4043088: _edbus_connection_unref (edbus_core.c:1045)
==22814==    by 0x404352F: edbus_connection_unref (edbus_core.c:1105)
==22814==    by 0x80498AA: main (banshee.c:233)
==22814==  Address 0x44bea48 is 0 bytes inside a block of size 72 free'd
==22814==    at 0x402C06C: free (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==22814==    by 0x4056118: _edbus_signal_handler_del (edbus_signal_handler.c:249)
==22814==    by 0x4056401: edbus_signal_handler_unref (edbus_signal_handler.c:272)
==22814==    by 0x4056503: edbus_signal_handler_del (edbus_signal_handler.c:280)
==22814==    by 0x4043088: _edbus_connection_unref (edbus_core.c:1045)
==22814==    by 0x404352F: edbus_connection_unref (edbus_core.c:1105)
==22814==    by 0x80498AA: main (banshee.c:233)
==22814==
CRI<22814>: src/lib/edbus_signal_handler.c:278 edbus_signal_handler_del() *** Eina Magic Check Failed !!!
    Input handle has already been freed!
    *** NAUGHTY PROGRAMMER!!!
    *** SPANK SPANK SPANK!!!
    *** Now go fix your code. Tut tut tut!

Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 80686
2012-12-11 19:50:01 +00:00
José Roberto de Souza 4327109500 edbus: Refactor edbus_connection_name
Simplifications on "monitor" of NameOwnerChanged
Life cycle tied with refcount, objs, and name_owner_changed list.

Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 80684
2012-12-11 19:49:46 +00:00
José Roberto de Souza d5dab6de7b edbus: Handle 'unref signal handler inside of own callback' with ref and unref
This way is much simpler and doesn't generate many events when main loop
is quit inside of a signal handler callback.

Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 80683
2012-12-11 19:49:42 +00:00
José Roberto de Souza 06439a3ee8 edbus: Add edbus_signal_handler_match_extra_vset
Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 77095
2012-09-26 18:16:34 +00:00
Lucas De Marchi 3cf6418906 edbus: Reduce variable scope and add const where it's
due



SVN revision: 77006
2012-09-21 22:44:11 +00:00
José Roberto de Souza 49ea849059 edbus: Fix memory leak in
edbus_signal_handler_match_extra_set()

And allow values == "" in match_extra_set()

Patch by: José Roberto de Souza  <zehortigoza@profusion.mobi>



SVN revision: 77004
2012-09-21 22:43:58 +00:00
Lucas De Marchi 5934eb6788 Add new edbus library, aka e_dbus v2
SVN revision: 76775
2012-09-17 20:41:05 +00:00