On Thu, Sep 20, 2012 at 8:06 PM, Zbigniew Kosinski <z.kosinski@samsung.com> wrote:
> Hello,
>
> Right now efreet_shutdown function doesn't return values below 0.
>
> In my opinion, efreet_mime_shutdown function should behave in the same way
> as efreet_shutdown.
>
> I have prepared patch proposal to prevent decrementing init counter below 0.
>
> Please take a look at attached file.
>
> BR,
>
> Zbigniew Kosinski
SVN revision: 76921
Some efreet APIs do not check input parameters. So I add checking by
using EINA_SAFETY_ON_XXX().
ISO/IEC statndards says that "If an argument to a function has an
invalid value, behavior is undefined" . But this is just for the
primitive functions such as libc. I think that parameter checking is
needed in at least EFL exported APIs to prevent run-time abnormal
behavior.
EINA_SAFTETY_ON_XXX are better than "if (xxx) return" because it gives
error message and can be maintainable.
Patch by Bluezery, modified by me
SVN revision: 71366
We return a pointer to an internal cache, so no need to do strdup. I we
implement a cache, the pointer will be a return from a mmap'ed file, so
no need to do strdup.
A bit late to do an API break, but must be done.
SVN revision: 54372
* Remove vim modelines:
find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;
* Remove leading blank lines:
find . -name '*.[cxh]' -exec sed -i '/./,$!d'
If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0
SVN revision: 50816
of the variable...use sizeof() compiler directive (lots of these).
Do not free 'realpath' in efreet_menu if we are going to try and print out
it's value.
If we find 'realpath' in the merged_menus hash, and we are going to return,
then free the realpath variable.
SVN revision: 44699
Efreet_Mime did not match last set of magics for given mime-type due to
missing check after the loop. This bug was partially masked by the
problem fixed in my previous patch.
By: Mikhail Gusarov
SVN revision: 41305
Hello,
I've fixed a bug in parsing magic file in Efreet_Mime: if some magic
rule has a subrule with non-zero depth, then the 0 depth is used instead
for subrule. This led to nonsense like all .xml documents matched as
application/docbook+xml.
By: Mikhail Gusarov
SVN revision: 41304
The pointer type is really confusing, it was expecting pointer to
pointer what is really weird.
Cedric just added a stringshared variant that should be as fast
(removing the strcmp()) and is the api one would expect.
This fix a long standing bug I introduced (sorry!) when added the
cache, but it was bit hard to hit as if you didn't find a collision
you'd be adding to cache and never finding it. But I recently started
to use icons on desktop and for some weird reason the PDF icons
started to show in TAR :-P
SVN revision: 41113
* fix compilation on Windows XP (not sure that Windows CE port is needed...)
note that, as ecore_exe is not available on Windows, some code have
been disables for that platform in src/lib/efreet_desktop.c. Also, a new Evil
version should be used (not in svn yet)
The compilation on Windows is needed for Ewl (icon and mime)
SVN revision: 40257
Daniel Juyung Seo
Cedric BAIL
Sebastian Dransfeld
Vincent Torri
Carsten Haitzler
Mike Blumenkrantz
Christopher Michael
Gustavo Sverzut Barbieri
Lucas De Marchi
Massimiliano Calamelli
Hannes Janetzek
David Walter Seikel