Sebastian Dransfeld
8554a0c23b
free data on realloc error
...
SVN revision: 50779
2010-08-03 19:30:53 +00:00
Massimiliano Calamelli
465a55b467
Leak-- using the macro
...
SVN revision: 50763
2010-08-03 11:44:55 +00:00
Sebastian Dransfeld
4b221c3936
Check return value for realloc
...
SVN revision: 50753
2010-08-02 20:43:09 +00:00
Sebastian Dransfeld
31c6799a7e
goto not needed anymore with alloca
...
SVN revision: 50496
2010-07-25 20:38:28 +00:00
Sebastian Dransfeld
78f80647ea
use eina hash set
...
SVN revision: 50494
2010-07-25 20:28:21 +00:00
Sebastian Dransfeld
230461d56b
free data on error
...
SVN revision: 50493
2010-07-25 20:25:51 +00:00
Sebastian Dransfeld
b76d9490dc
Fix errors reported by clang
...
SVN revision: 50492
2010-07-25 20:25:40 +00:00
Lucas De Marchi
2a84379ba9
Remove unneeded code with notnull.cocci script
...
The notnull.cocci script from Coccinelle finds places where you check if a
variable is NULL, but it's known not to be NULL. The check can be safely
removed. For example, this code would be caught by notnull:
if (!var) return;
if (var && var->fld) { ... }
It's needless to check again if var is not NULL because if it's in fact NULL,
it would have returned on the previous "if". This commit removes all the
trivial places where this pattern happens. Another patch will be generated for
the more complex cases.
SVN revision: 50241
2010-07-14 02:05:47 +00:00
Christopher Michael
4f972b800b
Move Efreet (and associated headers) to own dir.
...
SVN revision: 50143
2010-07-09 06:28:29 +00:00
Sebastian Dransfeld
bcb8744bc0
formatting
...
SVN revision: 49840
2010-06-25 01:44:30 +00:00
Sebastian Dransfeld
51c6fc3785
formatting
...
SVN revision: 49839
2010-06-25 01:38:50 +00:00
Cedric BAIL
55524b4e87
* efreet: remove warning due to change in Ecore API.
...
SVN revision: 49831
2010-06-24 16:17:45 +00:00
Sebastian Dransfeld
a392e677a7
flock -> fcntl
...
SVN revision: 49650
2010-06-11 21:48:33 +00:00
Vincent Torri
5a8135174a
missing headers
...
SVN revision: 49545
2010-06-06 19:45:16 +00:00
Carsten Haitzler
0d773a63a0
version for efreet
...
SVN revision: 49282
2010-05-29 08:30:06 +00:00
Sebastian Dransfeld
cf894cab2e
fix double free
...
eina_hash_del calls free callback, so we don't need to free the data
ourselves.
SVN revision: 49247
2010-05-28 09:25:16 +00:00
Sebastian Dransfeld
d4eb19a520
efreet: formatting
...
SVN revision: 48946
2010-05-17 19:45:20 +00:00
Hannes Janetzek
61df60e3bb
get min/max size only for scalable icons
...
SVN revision: 48924
2010-05-16 21:11:21 +00:00
Hannes Janetzek
3ac99ef29b
fix ret_size used unitialized
...
Threshold is fallback for type
calc min/max dir size for threshold only once
SVN revision: 48923
2010-05-16 21:02:52 +00:00
Sebastian Dransfeld
f7b9de9595
efreet: formatting
...
SVN revision: 48921
2010-05-16 19:36:42 +00:00
Sebastian Dransfeld
fc031b899d
efreet: better variable naming
...
SVN revision: 48920
2010-05-16 18:42:43 +00:00
Sebastian Dransfeld
f827867a22
efreet: prefer downsizing
...
SVN revision: 48919
2010-05-16 18:42:33 +00:00
Sebastian Dransfeld
31fa5a1e1d
efreet: use exponential scale for icon size search
...
fd.o spec wants us to use linear distance for icon size search. But
f.ex. when searching for a 128px icon, and the available is 48px and
256px, 256px would be preferable as 256/128 is 2 and 128/48 is 2.67
SVN revision: 48918
2010-05-16 18:41:56 +00:00
Carsten Haitzler
8bbc3b9024
gaaaaah! fix buf - paths were "wrong" - thus matching failed. man i see some
...
expensive ops going on with lots of strcmping.
SVN revision: 48917
2010-05-16 17:11:38 +00:00
Sebastian Dransfeld
8cde10890b
efreet: Don't remove/add stuff already in list
...
eina_list_promote_list to prepend data already in list.
SVN revision: 48898
2010-05-15 18:38:50 +00:00
Hannes Janetzek
af2471c7bc
remove svg from default types.
...
make efreet_icon_extensions prepended a type when it already is in list
SVN revision: 48895
2010-05-15 17:55:41 +00:00
Hannes Janetzek
82b89cea6b
add FIXME
...
SVN revision: 48893
2010-05-15 16:57:28 +00:00
Hannes Janetzek
85dbd6d844
search for svg icons
...
SVN revision: 48891
2010-05-15 16:24:58 +00:00
Hannes Janetzek
db8de25e56
allow trashing of files which are not on home partition
...
SVN revision: 48885
2010-05-15 07:51:49 +00:00
Sebastian Dransfeld
dc91f4ebbf
efreet: make sure we flush new dirs
...
SVN revision: 48812
2010-05-13 18:31:41 +00:00
Hannes Janetzek
1a49327928
make all strings returned by efre_mime_type_get stringshared
...
SVN revision: 48641
2010-05-05 20:55:14 +00:00
Sebastian Dransfeld
5be72adc7d
efreet: TODO++
...
SVN revision: 48429
2010-04-29 18:16:15 +00:00
Sebastian Dransfeld
b5caf6ce1b
efreet: fix #534
...
SVN revision: 48110
2010-04-18 20:04:09 +00:00
Albin Tonnerre
1dde324c33
[E-devel] [PATCH] Efreet: move efreet_desktop_cache_create out of
...
the path
This binary is just an internal helper, and isn't expected to be run by
anything but efreet. Therefore, let's emphasize this and keep it out of
the path by installing it in PACKAGE_LIB_DIR/efreet/
Signed-off-by: Albin Tonnerre <lutin@debian.org>
By: Albin Tonnerre <albin.tonnerre@gmail.com>
SVN revision: 48085
2010-04-17 20:19:35 +00:00
Sebastian Dransfeld
a384141abc
efreet: Check return value from opendir
...
SVN revision: 48081
2010-04-17 18:39:13 +00:00
Carsten Haitzler
ca87bc3349
how about if opendir fails... we dont try and walk the dir? :)
...
SVN revision: 48047
2010-04-16 02:20:56 +00:00
Sebastian Dransfeld
3d71b07fc7
TODO--
...
SVN revision: 48040
2010-04-15 19:43:02 +00:00
Sebastian Dransfeld
9460f8ed3e
efreet: use convenience func
...
One func to add monitor, func checks for duplicate monitor and uses
realpath
SVN revision: 48038
2010-04-15 19:38:01 +00:00
Sebastian Dransfeld
80e3b951fa
efreet: listen for changes recursivly
...
SVN revision: 48036
2010-04-15 19:21:23 +00:00
Sebastian Dransfeld
1488a1889d
efreet: better naming
...
SVN revision: 48035
2010-04-15 19:21:13 +00:00
Sebastian Dransfeld
37e39a6834
efreet: better naming
...
SVN revision: 48034
2010-04-15 19:21:03 +00:00
Sebastian Dransfeld
2df0141340
efreet: better naming
...
SVN revision: 48033
2010-04-15 19:20:51 +00:00
Sebastian Dransfeld
1560298337
efreet: better naming
...
SVN revision: 48032
2010-04-15 19:20:41 +00:00
Sebastian Dransfeld
1446a1a819
efreet: reorganize
...
SVN revision: 48031
2010-04-15 19:20:31 +00:00
Sebastian Dransfeld
42415580c2
efreet: group EAPI int's and init 0
...
SVN revision: 48030
2010-04-15 19:20:18 +00:00
Sebastian Dransfeld
078fd2fd91
efreet: remove old code
...
SVN revision: 48029
2010-04-15 19:20:09 +00:00
Sebastian Dransfeld
bb7b272b18
efreet: better naming
...
SVN revision: 48028
2010-04-15 19:19:59 +00:00
Sebastian Dransfeld
28f67a86d7
efreet: formatting
...
SVN revision: 48027
2010-04-15 19:19:48 +00:00
Sebastian Dransfeld
1870180db1
efreet: and add file
...
SVN revision: 48026
2010-04-15 18:24:48 +00:00
Sebastian Dransfeld
6b1bb18738
efreet: split desktop command to separate file
...
SVN revision: 48025
2010-04-15 18:23:42 +00:00
Sebastian Dransfeld
84f6110ff1
TODO++
...
SVN revision: 48003
2010-04-14 19:39:36 +00:00
Sebastian Dransfeld
e8883033a2
efreet: Listen to new cache dirs
...
SVN revision: 47795
2010-04-06 18:50:26 +00:00
Sebastian Dransfeld
95d6e3390f
efreet: reorder init
...
SVN revision: 47794
2010-04-06 18:36:25 +00:00
Sebastian Dransfeld
c6ec14606e
efreet: TODO++
...
SVN revision: 47791
2010-04-06 18:35:54 +00:00
Sebastian Dransfeld
113b0254a8
efreet: listen for changes in desktop files
...
SVN revision: 47790
2010-04-06 18:35:45 +00:00
Sebastian Dransfeld
973965f165
efreet: TODO++
...
SVN revision: 47788
2010-04-06 18:35:18 +00:00
Sebastian Dransfeld
b58df70245
efreet: more doc
...
SVN revision: 47737
2010-04-03 18:48:57 +00:00
Sebastian Dransfeld
9e6c9f7335
efreet: check load time on all desktop structs
...
SVN revision: 47736
2010-04-03 18:46:58 +00:00
Sebastian Dransfeld
bc4bc7ce81
efreet: Check whether cached version is latest.
...
SVN revision: 47735
2010-04-03 18:46:47 +00:00
Sebastian Dransfeld
7c3818fb1d
efreet: Always update cache if not read from eet
...
SVN revision: 47734
2010-04-03 18:46:37 +00:00
Sebastian Dransfeld
1122ed6c56
efreet: Don't update cache if we don't mean to
...
SVN revision: 47733
2010-04-03 18:46:27 +00:00
Sebastian Dransfeld
12a341ff2f
efreet: rename fd for lock
...
SVN revision: 47732
2010-04-03 18:46:17 +00:00
Sebastian Dransfeld
3c3e999ad7
efreet: mkpath once
...
SVN revision: 47731
2010-04-03 18:46:07 +00:00
Sebastian Dransfeld
3c595b9408
efreet: Add cache update func
...
SVN revision: 47730
2010-04-03 18:45:57 +00:00
Sebastian Dransfeld
0407d84a9a
efreet: rename lock file
...
SVN revision: 47729
2010-04-03 18:45:46 +00:00
Iván Briano
13265370a5
Don't screw the still used len variable, and remove unnecessary hash_del (we didn't find the entry at the beginning, no point trying to delete it)
...
SVN revision: 47726
2010-04-03 16:26:03 +00:00
Sebastian Dransfeld
31f73712f3
efreet: stringshare
...
SVN revision: 47668
2010-04-01 19:41:03 +00:00
Sebastian Dransfeld
2dbd820242
efreet: merge
...
SVN revision: 47666
2010-04-01 19:39:42 +00:00
Sebastian Dransfeld
3b546516c3
efreet: fancy alloca include in common header
...
SVN revision: 47664
2010-04-01 19:32:41 +00:00
Sebastian Dransfeld
5d368823ba
efreet: move file local data to .c file
...
SVN revision: 47663
2010-04-01 19:32:29 +00:00
Sebastian Dransfeld
ede5ac01f6
efreet: remove strdup, use alloca
...
SVN revision: 47662
2010-04-01 19:32:19 +00:00
Sebastian Dransfeld
127982f44c
efreet: remove strdup, use alloca
...
SVN revision: 47661
2010-04-01 19:32:10 +00:00
Sebastian Dransfeld
48ecf5383b
efreet: fix compiler warning
...
SVN revision: 47660
2010-04-01 19:32:00 +00:00
Sebastian Dransfeld
e30468b362
efreet: stringshare
...
SVN revision: 47659
2010-04-01 19:31:49 +00:00
Sebastian Dransfeld
9464e87d74
efreet: stringshare
...
SVN revision: 47658
2010-04-01 19:31:38 +00:00
Sebastian Dransfeld
4501c577e3
efreet: stringshare
...
SVN revision: 47657
2010-04-01 19:30:13 +00:00
Carsten Haitzler
d9d11ba836
fixme-- ... my bad! looking at wrong fn! :)
...
SVN revision: 47598
2010-03-30 12:44:37 +00:00
Sebastian Dransfeld
6d00dc126b
efreet: use alloca for local dynamic buffer
...
SVN revision: 47597
2010-03-30 12:22:15 +00:00
Sebastian Dransfeld
1b6662b2e9
efreet: remove strdup
...
SVN revision: 47596
2010-03-30 12:22:05 +00:00
Sebastian Dransfeld
a44f87390d
efreet: benefit from stringshare
...
SVN revision: 47595
2010-03-30 12:21:55 +00:00
Sebastian Dransfeld
c2db2c4258
efreet: stringshare
...
SVN revision: 47594
2010-03-30 12:21:44 +00:00
Sebastian Dransfeld
40a5c9a155
efreet: stringshare
...
SVN revision: 47593
2010-03-30 12:21:33 +00:00
Sebastian Dransfeld
72a79471d5
remove strdup
...
SVN revision: 47592
2010-03-30 12:21:23 +00:00
Sebastian Dransfeld
ac18d14316
efreet: benefit from stringshare
...
Since both values are stringshared, we can use direct comparison.
SVN revision: 47591
2010-03-30 12:21:12 +00:00
Sebastian Dransfeld
1063df8b9e
efreet: stringshare
...
SVN revision: 47590
2010-03-30 12:20:55 +00:00
Sebastian Dransfeld
6da3c6846d
efreet: stringshare
...
SVN revision: 47588
2010-03-30 11:07:19 +00:00
Sebastian Dransfeld
592ebdcb5b
efreet: stringshare
...
SVN revision: 47587
2010-03-30 11:07:07 +00:00
Sebastian Dransfeld
c06492ded0
efreet: stringshare
...
SVN revision: 47586
2010-03-30 11:06:56 +00:00
Carsten Haitzler
d3de8d9f1d
hmm - avoid crash for now, but bitch loudly
...
SVN revision: 47581
2010-03-30 05:29:49 +00:00
Carsten Haitzler
76b3bed05e
comment++
...
SVN revision: 47577
2010-03-30 05:15:33 +00:00
Sebastian Dransfeld
3db40c0d97
efreet: fix strdup + stringshare
...
SVN revision: 47568
2010-03-29 20:14:43 +00:00
Sebastian Dransfeld
44aea1a452
efreet: Remove unneeded flag
...
SVN revision: 47544
2010-03-28 20:36:37 +00:00
Sebastian Dransfeld
5e33a5798f
Remove unneeded TOOD
...
SVN revision: 47542
2010-03-28 20:36:11 +00:00
Sebastian Dransfeld
d075ee43c2
efreet: Always run cache update on init
...
SVN revision: 47537
2010-03-28 19:31:14 +00:00
Sebastian Dransfeld
d8bde974e6
efreet: Add variable to prevent cache update
...
SVN revision: 47536
2010-03-28 18:54:25 +00:00
Sebastian Dransfeld
3806dd7a2c
efreet: Track old caches
...
SVN revision: 47519
2010-03-27 20:53:52 +00:00
Sebastian Dransfeld
fa732e43f6
efreet: fix function name
...
SVN revision: 47515
2010-03-27 19:58:54 +00:00
Sebastian Dransfeld
053190d2f4
sync cache reload between desktop and util
...
SVN revision: 47513
2010-03-27 19:58:33 +00:00
Sebastian Dransfeld
534519db27
init util alongside rest of efreet
...
Used to be separate as util had different requirements than base efreet,
and util had high memory usage. No longer the case.
SVN revision: 47510
2010-03-27 19:57:47 +00:00
Sebastian Dransfeld
a870815d90
print dangling references
...
SVN revision: 47509
2010-03-27 19:57:33 +00:00
Sebastian Dransfeld
6990198493
Add comments
...
SVN revision: 47473
2010-03-26 05:33:37 +00:00
Sebastian Dransfeld
a86ec92bc9
Add listener for cache updates
...
SVN revision: 47471
2010-03-26 05:33:12 +00:00
Sebastian Dransfeld
7bbc5e82ba
Remove unneeded code
...
SVN revision: 47470
2010-03-26 05:33:00 +00:00
Sebastian Dransfeld
4e8ebec3f6
efreet_menu.c: Fix compiler warning
...
SVN revision: 47469
2010-03-26 05:29:15 +00:00
Sebastian Dransfeld
ef2cb7ab02
Add func to read a .desktop file from disk
...
SVN revision: 47250
2010-03-15 19:57:57 +00:00
Sebastian Dransfeld
a4c63dd80d
formatting
...
SVN revision: 47245
2010-03-15 19:10:51 +00:00
Sebastian Dransfeld
985b7e395a
Fix realpath usage
...
Always use realpath before interacting with the efreet_desktop_cache,
else it wont be consistent.
SVN revision: 47244
2010-03-15 19:08:22 +00:00
Cedric BAIL
ddbeb0581c
* efreet: Prevent crash due to freed desktop still in cache.
...
SVN revision: 47235
2010-03-15 13:46:45 +00:00
Sebastian Dransfeld
2f7f718185
Fix?? segv
...
For some peculiar reason, using ecore_file_realpath here screws with
efreet_menu.
SVN revision: 47224
2010-03-14 20:48:52 +00:00
Sebastian Dransfeld
d47cdf8288
fix memleak
...
Free hash and data pointer when using eet, but not lists
SVN revision: 47183
2010-03-13 19:14:35 +00:00
Sebastian Dransfeld
2104d71164
shutdown eina after last stringshare del
...
SVN revision: 47181
2010-03-13 19:05:11 +00:00
Sebastian Dransfeld
277365fe1c
Don't free data at all from eet
...
SVN revision: 47179
2010-03-13 18:35:48 +00:00
Sebastian Dransfeld
09dcca28de
stringshare
...
SVN revision: 47178
2010-03-13 18:35:39 +00:00
Sebastian Dransfeld
eb8fa05ff3
When using Eina_List, need to return list
...
SVN revision: 47177
2010-03-13 18:35:29 +00:00
Sebastian Dransfeld
c07e3969ce
stringshare
...
SVN revision: 47176
2010-03-13 18:34:30 +00:00
Sebastian Dransfeld
f3b42c4b05
Hi,
...
I discover a memory leak (an invalid free) in efreet after running some
of the test programs.
Mathieu
SVN revision: 47136
2010-03-11 18:36:31 +00:00
Sebastian Dransfeld
424f67585e
formatting
...
SVN revision: 46960
2010-03-07 20:34:41 +00:00
Sebastian Dransfeld
30c305288f
Fix problem with orig_path and rp
...
We have orig_path, it is set by rp. Only problem is that it was set
after efreet_desktop_read so the error handler would work as it should.
Wrong solution. So now we set orig_path to NULL, so we always can free
rp.
SVN revision: 46880
2010-03-04 21:54:33 +00:00
Carsten Haitzler
33ec010a36
errrr - how about we have a orig_path for a new desktop file eh? there's a
...
brilliant idea!
SVN revision: 46859
2010-03-04 01:00:06 +00:00
Sebastian Dransfeld
76d630dcc0
TODO
...
SVN revision: 46848
2010-03-03 22:11:06 +00:00
Sebastian Dransfeld
22a691b5e9
Assign rp to orig_path after last goto error
...
This will fix the double free problem
SVN revision: 46841
2010-03-03 20:13:13 +00:00
Sebastian Dransfeld
7a07bed86c
Clarify difference between _get and _new
...
efreet_desktop_get for long living cached structs, efreet_desktop_new
for shortlived non cached.
SVN revision: 46840
2010-03-03 19:42:38 +00:00
Sebastian Dransfeld
afb2a67c50
Create func to get name for cache dirs file
...
SVN revision: 46834
2010-03-03 12:29:09 +00:00
Sebastian Dransfeld
755e118e2c
Allow non existing cache file
...
SVN revision: 46833
2010-03-03 12:28:59 +00:00
Sebastian Dransfeld
b5e9acd3da
formatting
...
SVN revision: 46832
2010-03-03 12:28:49 +00:00
Sebastian Dransfeld
a1205c588c
rename function
...
SVN revision: 46831
2010-03-03 12:28:40 +00:00
Sebastian Dransfeld
d07a67ad63
Store unknown .desktop file dirs
...
SVN revision: 46829
2010-03-03 12:28:21 +00:00
Christopher Michael
4177422a6b
Temporary stop-gap for E17 crashing when Applications menu is trying to
...
show.
(I know, not an ideal fix, but I don't know the code well enough...and
this is better than everyone's desktop dying.)
SVN revision: 46810
2010-03-03 02:24:26 +00:00
Sebastian Dransfeld
6d10aea822
Use realpath to clean path
...
SVN revision: 46801
2010-03-02 20:07:41 +00:00
Sebastian Dransfeld
d99f80aff7
Fix compiler warnings
...
Found when compiling with --enable-tests and --enable-coverage
SVN revision: 46746
2010-03-01 21:43:59 +00:00
Vincent Torri
1b9235aa1f
fix autotools stuff
...
SVN revision: 46737
2010-03-01 20:16:15 +00:00
Sebastian Dransfeld
8b0e9907b6
Empty cache is probable, so don't check for it
...
SVN revision: 46736
2010-03-01 19:58:23 +00:00
Sebastian Dransfeld
9eda1bb218
TODO++
...
SVN revision: 46731
2010-03-01 19:05:59 +00:00
Sebastian Dransfeld
f72d4f9342
Eet cache for efreet desktop
...
SVN revision: 46726
2010-03-01 18:16:32 +00:00
Sebastian Dransfeld
7c1420c73b
Use MAP_FAILED constant
...
SVN revision: 46174
2010-02-14 21:22:06 +00:00
Sebastian Dransfeld
6f2038b6e7
Create path to file if not exists
...
Fixes bug #513
SVN revision: 45990
2010-02-08 19:27:58 +00:00
Sebastian Dransfeld
cb4af1da03
Don't add already existing paths to theme
...
SVN revision: 45883
2010-02-04 20:02:56 +00:00
Sebastian Dransfeld
291c525a42
Remove raster's stupid cache
...
And just disable cache limit on the already existing cache.
SVN revision: 45881
2010-02-04 20:02:33 +00:00
Sebastian Dransfeld
0423e1ea99
Formatting
...
SVN revision: 45865
2010-02-04 09:12:35 +00:00
Sebastian Dransfeld
d3419db6cd
Ecore_Str.h -> Eina
...
SVN revision: 45741
2010-01-30 22:13:16 +00:00
Sebastian Dransfeld
96a20ffd91
Update to spec 1.1
...
%n, %N, %d and %D is deprecated, and version is string
SVN revision: 45532
2010-01-24 21:21:27 +00:00
Sebastian Dransfeld
6833eadf64
/usr/local/share should also be in XDG_DATA_DIRS
...
SVN revision: 45496
2010-01-23 18:55:27 +00:00
Sebastian Dransfeld
04edba1123
Be less strict
...
Prefer system set menu_file.
Try harder to find -merged dirs which matches the current menu.
SVN revision: 45265
2010-01-17 18:57:49 +00:00
Sebastian Dransfeld
4b33d2e4aa
remove ecore_data function
...
SVN revision: 45264
2010-01-17 18:56:48 +00:00
Sebastian Dransfeld
362ef26c2d
remove Ecore_Data
...
SVN revision: 45218
2010-01-16 13:43:28 +00:00
Christopher Michael
7c0e622466
Make efreet compile again.
...
SVN revision: 45206
2010-01-16 05:22:24 +00:00
Sebastian Dransfeld
0903a5be95
Add ()
...
SVN revision: 45200
2010-01-15 20:51:34 +00:00
Sebastian Dransfeld
af22e351b2
Fix compiler warnings
...
SVN revision: 45199
2010-01-15 20:51:23 +00:00
Massimiliano Calamelli
bc2a1db660
Added two missing inclusions of limits.h, fix build in NetBSD5
...
SVN revision: 45026
2010-01-10 22:42:34 +00:00
David Walter Seikel
060ec41809
Make it compile again.
...
SVN revision: 44905
2010-01-05 02:15:41 +00:00
Gustavo Sverzut Barbieri
1979834385
PATH_MAX checks and fixes, by Lutin.
...
SVN revision: 44900
2010-01-04 23:11:15 +00:00
Christopher Michael
56ec4c946f
When using snprintf or fgets, etc, do not use PATH_MAX directly as the size
...
of the variable...use sizeof() compiler directive (lots of these).
Do not free 'realpath' in efreet_menu if we are going to try and print out
it's value.
If we find 'realpath' in the merged_menus hash, and we are going to return,
then free the realpath variable.
SVN revision: 44699
2009-12-23 20:55:23 +00:00
Iván Briano
52468a9940
Fix to new Ecore API
...
SVN revision: 43685
2009-11-13 23:59:46 +00:00
Davide Andreoli
a59b9655b2
*Efreet_Ini: Add a new API call:
...
EAPI void efreet_ini_key_unset(Efreet_Ini *ini, const char *key);
With this you can remove keys from ini files
SVN revision: 43245
2009-10-24 09:23:51 +00:00
Davide Andreoli
c9533023ad
Efreet_ini: remove ending withespaces
...
SVN revision: 43244
2009-10-24 09:02:56 +00:00
Carsten Haitzler
ccec2fb8a4
fix xml init - called multilpe times, has no count for init + shutdown.
...
SVN revision: 43222
2009-10-23 00:01:15 +00:00
Vincent Torri
285297dcdd
* API break: _shutdown() functions return an int, now
...
* simplify a bit and fix init/shutdown functions
SVN revision: 42996
2009-10-10 06:19:13 +00:00
Cedric BAIL
703fb37368
* efreet: Prevent div by zero.
...
SVN revision: 42940
2009-10-07 12:57:13 +00:00
Vincent Torri
1403d26dce
remoove unused variables
...
SVN revision: 42877
2009-10-04 22:28:12 +00:00
Vincent Torri
4c05580f59
cleanup
...
SVN revision: 42876
2009-10-04 22:27:03 +00:00
Hannes Janetzek
6a9f924640
patch from dfjoerg: search also pixmap dirs for icons
...
SVN revision: 42875
2009-10-04 21:55:13 +00:00
Cedric BAIL
05126826a3
* efreet: Use eina_log.
...
Patch from Matthieu.
SVN revision: 42599
2009-09-21 16:36:29 +00:00
Davide Andreoli
5f6ba77546
Don't segfault if 'icon' is null
...
SVN revision: 42490
2009-09-14 20:18:25 +00:00
Carsten Haitzler
0b8f43494a
moe enume typedefs together. typedef before enum is bad for some compilrs...
...
like g++.. or suncc... dod so in all headers anyay for consistency
SVN revision: 42477
2009-09-14 00:38:59 +00:00
Hannes Janetzek
51fd74a36f
efreet_mime add fallback check for executables
...
SVN revision: 42474
2009-09-14 00:28:51 +00:00
Gustavo Sverzut Barbieri
992936af22
Update to match new EINA init/shutdown.
...
SVN revision: 42301
2009-09-06 22:23:04 +00:00
Vincent Torri
2e38151ed8
formatting
...
SVN revision: 42084
2009-08-29 05:29:05 +00:00
Gustavo Sverzut Barbieri
85c2e25399
have efreet to match x-generic as well, requested by jeffdameth.
...
SVN revision: 41907
2009-08-21 03:03:59 +00:00
Gustavo Sverzut Barbieri
4faa46cab3
Efreet_Mime: bugfix for magic matching.
...
Efreet_Mime did not match last set of magics for given mime-type due to
missing check after the loop. This bug was partially masked by the
problem fixed in my previous patch.
By: Mikhail Gusarov
SVN revision: 41305
2009-07-11 14:26:53 +00:00
Gustavo Sverzut Barbieri
9aef9f5eca
Efreet_Mime: fix subrules with non-zero depth.
...
Hello,
I've fixed a bug in parsing magic file in Efreet_Mime: if some magic
rule has a subrule with non-zero depth, then the 0 depth is used instead
for subrule. This led to nonsense like all .xml documents matched as
application/docbook+xml.
By: Mikhail Gusarov
SVN revision: 41304
2009-07-11 14:23:36 +00:00
Gustavo Sverzut Barbieri
eac66d4e5a
proper cleanup of efreet_desktop_command.
...
Efreet API is BRAIN NUTS, some stuff you're supposed to release (list)
and others are up to the callback to release.
Okay, I broke e17 trying to fix efreet tests. API is so inconsistent
that its own test was wrong. I'm reverting my change and fix the test,
but this is bad.
SVN revision: 41133
2009-06-20 19:07:31 +00:00
Vincent Torri
b9d313774f
* Allow some tests to pass on Windows. Just for the fun
...
* More important, allow to manage correctly the icons with
efreet on Windows. It works with Tango (and ewl, now)
SVN revision: 41130
2009-06-20 16:18:17 +00:00
Gustavo Sverzut Barbieri
44d66495ca
more valgrind fixes on efreet.
...
SVN revision: 41121
2009-06-20 06:50:01 +00:00
Gustavo Sverzut Barbieri
3871aed422
free some leaks reported by valgrind in src/bin tests.
...
SVN revision: 41117
2009-06-20 06:19:48 +00:00
Gustavo Sverzut Barbieri
ebeee4b5ce
we use lists, need to init/shutdown eina_list or we get segvs.
...
SVN revision: 41115
2009-06-20 05:53:26 +00:00
Gustavo Sverzut Barbieri
adf5c3553e
use new stringshared hash, pointer was being misused since api is confusing.
...
The pointer type is really confusing, it was expecting pointer to
pointer what is really weird.
Cedric just added a stringshared variant that should be as fast
(removing the strcmp()) and is the api one would expect.
This fix a long standing bug I introduced (sorry!) when added the
cache, but it was bit hard to hit as if you didn't find a collision
you'd be adding to cache and never finding it. But I recently started
to use icons on desktop and for some weird reason the PDF icons
started to show in TAR :-P
SVN revision: 41113
2009-06-19 15:00:38 +00:00
Vincent Torri
54b27e4edc
* DATADIR is used in a Windows directory. Use PACKAGE_DATA_DIR instead
...
* useless Evil.h inclusion
SVN revision: 41084
2009-06-17 16:07:29 +00:00
Carsten Haitzler
2cf2ffd88b
patch from dfjoerg - fix prefix handling for eet.
...
SVN revision: 41031
2009-06-14 20:13:58 +00:00
Carsten Haitzler
e50d237d83
more patches...
...
SVN revision: 40669
2009-05-15 11:47:39 +00:00
Massimiliano Calamelli
31c77f7844
Added #define _POSIX_HOST_NAME_MAX for OSes that don't know it (NetBSD in detail)
...
SVN revision: 40444
2009-04-28 15:49:45 +00:00
Mike Frysinger
81b053c046
include Ecore.h for ecore_exe_run prototype
...
SVN revision: 40431
2009-04-28 05:39:22 +00:00
Carsten Haitzler
ae44cac932
revert patch - no-undefined already there.
...
SVN revision: 40319
2009-04-23 04:07:59 +00:00
booleanlabel
51dc49dbee
From: booleanlabel@gmail.com
...
cygwin fixes.
SVN revision: 40301
2009-04-23 01:09:01 +00:00
Vincent Torri
c634a197b4
fix eina_list_remove use
...
SVN revision: 40263
2009-04-21 08:09:39 +00:00
Vincent Torri
361f682833
typo
...
SVN revision: 40260
2009-04-21 06:16:19 +00:00
Vincent Torri
1bf086809e
* move header files in efree_provate.h to the source files
...
* fix compilation on Windows XP (not sure that Windows CE port is needed...)
note that, as ecore_exe is not available on Windows, some code have
been disables for that platform in src/lib/efreet_desktop.c. Also, a new Evil
version should be used (not in svn yet)
The compilation on Windows is needed for Ewl (icon and mime)
SVN revision: 40257
2009-04-20 23:20:40 +00:00
Carsten Haitzler
ce5a59b7e5
lutin... release soname patch. verbose svn soname used right now
...
SVN revision: 40131
2009-04-17 10:01:45 +00:00
Luis Felipe Strano Moraes
37ff2edaff
Cleanup of clang's static analyzer warnings for efreet.
...
SVN revision: 40114
2009-04-16 17:45:57 +00:00
Vincent Torri
45e1663dab
* fix pkg-config requirements
...
* fix a bit the autotools
SVN revision: 39754
2009-03-27 11:29:20 +00:00
Vincent Torri
312a4365b8
fix header files
...
SVN revision: 39752
2009-03-27 11:14:21 +00:00
Cedric BAIL
8a8b4ca2d1
* efreet: On STRICT_SPEC don't handle efreet_menu_file.
...
SVN revision: 39732
2009-03-26 18:02:17 +00:00
Cedric BAIL
81ee186382
* efreet: Use the right macro for the cast.
...
SVN revision: 39731
2009-03-26 17:56:51 +00:00
Cedric BAIL
7e6af0a5c1
* efreet: Remove ecore_dlist from Efreet.
...
SVN revision: 39730
2009-03-26 17:54:50 +00:00
Carsten Haitzler
34822db882
menu segv fix! my bad! overzealous freeing
...
SVN revision: 39653
2009-03-23 13:16:10 +00:00
Vincent Torri
908a722bfa
more leak fixes
...
SVN revision: 39650
2009-03-23 12:19:31 +00:00
Carsten Haitzler
ddb11ee846
leaks--! this code is riddled with leaks! really really bad!
...
SVN revision: 39647
2009-03-23 10:27:54 +00:00
Vincent Torri
a7dfd144ac
formatting
...
SVN revision: 39643
2009-03-23 04:58:31 +00:00
Gustavo Sverzut Barbieri
122566bac4
fix efreet signedness issues.
...
char is unsigned on ARM and other platforms, force some types to be
signed as they can hold negative values.
By: Albin Tonnerre
SVN revision: 39610
2009-03-21 17:00:55 +00:00
Carsten Haitzler
9e5c641263
and somewhere.. someone broke system settings and efreet hashes of categories!
...
SVN revision: 39570
2009-03-19 04:29:31 +00:00
Sebastian Dransfeld
5378f8d4d6
Check whether the found item is a directory.
...
SVN revision: 39524
2009-03-17 13:42:21 +00:00
Gustavo Sverzut Barbieri
ba1e67fcd8
Add LRU to mime icons cache.
...
This should really remove unused items that would age forever in the
last, forcing old but not so to be evicted before them.
Fortunately it was not so complex to add, and should wait just 3
pointers more of space per node.
SVN revision: 39350
2009-03-03 22:38:21 +00:00
Gustavo Sverzut Barbieri
200c92f82a
efreet mime types icon cache.
...
This cache is very simple and should work fine when system does not
change, it keeps a direct association of mime-types and found icons,
remembering theme and icon size. Search is very fast since it uses
stringshared strings and thus direct pointer comparison in hash
search. We could optimize it even more if we assumed stringshared
strings to come in, so no need to eina_stringshare_add() (which is a
hash per se), using just eina_stringshare_ref().
Cache population is limited to compile-time value and just values
older than a given threshold are deleted. I do not keep a LRU explicit
list, so you might have some old but unused items always alive. I
don't find this too bad, sure it will consume more memory, but will
not hurt performance. We can change this to purge all expired items by
not checking for number of items to remove, removing all that match.
Next I plan to find out a good way to cache and speed up file->mime
discovery. I plan to do auto-generated state-machine to match
extensions, so you don't need to check the same extension character
more than once. Example:
Input: bla.edc
Extensions: edc edj eps png bmp
It would first try to match against 'e', 'p' and 'b'. It will match
'e' and then check for 'd' (edc or edj) or 'p' (eps). It will match
'd' and then check for 'c' or 'j'. This will reduce number of
comparisons considerably.
As I'm running out of time (4am, not much time left on this month), I
could use some help here.
SVN revision: 39343
2009-03-03 07:20:21 +00:00
Gustavo Sverzut Barbieri
ab2e35127f
Fix most compiler & clang warnings.
...
Left warnings regarding signed and unsigned comparison since
eina_list_count() returns unsigned, can use a cast in this return, but
not big deal for now.
By: Luis Felipe Strano Moraes & myself.
SVN revision: 39260
2009-02-26 22:35:38 +00:00
Cedric BAIL
452695bd6c
* efreet: Fix opening file.
...
SVN revision: 39246
2009-02-26 16:14:22 +00:00
Gustavo Sverzut Barbieri
2bcea93a7c
Fix port to eina_list.
...
* efreet_desktop_command_build(): should consider the first
run. Before had a "first" toggle variable, which vanished with eina
port. I changed it to do {} while (), making it work again.
* exec string is already freed by callback (in e_exec.c), to keep old
behavior, just free the list with eina_list_free(). Just pay
attention to ecore_list and double check if they had a free
function set or not. If it didn't, then we should not free nodes!
SVN revision: 39228
2009-02-26 03:56:21 +00:00
Carsten Haitzler
7646b3e4af
fix custom icon dirs api so u CAN add to the icon dirs!
...
SVN revision: 39226
2009-02-26 03:46:35 +00:00
Cedric BAIL
7e64baf165
* efreet: Prevent crash when no Efreet_Desktop are found.
...
SVN revision: 39214
2009-02-25 17:40:40 +00:00
Cedric BAIL
0b41f0e138
* efreet: Fix previously broken efreet cache.
...
SVN revision: 39211
2009-02-25 16:46:51 +00:00
Cedric BAIL
6978e98dc6
* estickies,
...
* etk,
* PROTO/exalt,
* E-MODULES-EXTRA/diskio,
* E-MODULES-EXTRA/drawer,
* E-MODULES-EXTRA/penguins,
* E-MODULES-EXTRA/slideshow,
* E-MODULES-EXTRA/mail,
* E-MODULES-EXTRA/forecasts,
* E-MODULES-EXTRA/iiirk,
* E-MODULES-EXTRA/places,
* e,
* ewl,
* ecore,
* elitaire,
* entrance,
* e_dbus,
* efreet: Here we go, move from Ecore_List to Eina_List.
NOTE: This patch is huge, I did test it a lot, and I hope nothing is
broken. But if you think something change after this commit, please
contact me ASAP.
SVN revision: 39200
2009-02-25 11:03:47 +00:00
Gustavo Sverzut Barbieri
24328d9738
Fix problems reported by some C++ compilers.
...
SVN revision: 38975
2009-02-09 01:11:27 +00:00
Carsten Haitzler
b00bae1d92
a really simple hash cache for icon finds - this massively makes stuff faster
...
for app dialogs etc. yes - it uses ram. thats next - make it leaner on ram
usage. its simple enough now where that shouldnt be a problem.
SVN revision: 38839
2009-01-29 07:36:58 +00:00
Cedric BAIL
35540b3a3b
This commit is huge. I did test it a lot on my computer, and it run fine here.
...
But is so big i fear i could have broken some piece of code. So report any wrong
behaviour to me (cedric on #edevelop).
So moving e17 and efreet to eina_hash. With a little efreet API break so they
must come together.
SVN revision: 38185
2008-12-17 15:33:43 +00:00
Sebastian Dransfeld
1de2e74d74
Adding missing Name entry in efreet_menu.
...
Add fix from Massimiliano Calamelli.
SVN revision: 38153
2008-12-15 20:23:24 +00:00
Sebastian Dransfeld
82c1c80632
Only save menu element name if it exists.
...
SVN revision: 38131
2008-12-13 21:00:49 +00:00
Gustavo Sverzut Barbieri
d5f5e6eb55
src/bin/ stuff uses it, so these symbols must be exported.
...
SVN revision: 37634
2008-11-14 20:22:03 +00:00
Sebastian Dransfeld
b41023437d
Remove warning by adding parentheses.
...
SVN revision: 37167
2008-10-26 20:05:46 +00:00
Sebastian Dransfeld
b439133578
Don't compile in unused code.
...
SVN revision: 37166
2008-10-26 20:05:34 +00:00
Carsten Haitzler
1065c6298a
support setting the default menu explicitly.
...
SVN revision: 37098
2008-10-25 15:06:31 +00:00
Cedric BAIL
02bf306fdd
Remove macro provided by Eina.
...
SVN revision: 36863
2008-10-20 16:34:59 +00:00
Cedric BAIL
01befd2b67
Switch ecore_strings to eina_stringshare.
...
SVN revision: 36676
2008-10-15 14:48:03 +00:00
Cedric BAIL
b6a71c63e6
Make efreet depend on eina. No change in the code yet, so just fix your build system and no bug must show up.
...
SVN revision: 36625
2008-10-13 16:00:19 +00:00
Carsten Haitzler
0e1ee5edb7
add null theme check
...
SVN revision: 35658
2008-08-25 09:14:13 +00:00
Sebastian Dransfeld
77cb8587de
define (void *)-1 as a macro
...
SVN revision: 35574
2008-08-19 06:32:40 +00:00
Sebastian Dransfeld
bfb18778e2
Pass icon size as unsigned int.
...
SVN revision: 35490
2008-08-14 20:48:41 +00:00
Sebastian Dransfeld
e52e71e475
Do atoi only once for each query.
...
SVN revision: 35489
2008-08-14 20:02:07 +00:00
Sebastian Dransfeld
7ee9598bd2
Make the icon cache work for efreet_icon_list_find.
...
SVN revision: 35488
2008-08-14 19:47:48 +00:00
Sebastian Dransfeld
25c29b62a3
ignore missing icons for 5 seconds.
...
SVN revision: 35480
2008-08-14 16:59:41 +00:00
Davide Andreoli
71e9fe89e9
Move Efreet_Uri stuff on the proper file. We can now use this in e instead of the internal one.
...
SVN revision: 35312
2008-08-03 00:07:17 +00:00
Dan Sinclair
5c0aaab8f1
- cleanups
...
SVN revision: 35309
2008-08-02 22:09:04 +00:00
Davide Andreoli
f438c7eb9a
* Fix Doxy warnings
...
SVN revision: 35307
2008-08-02 21:48:44 +00:00
Sebastian Dransfeld
e909810628
remove uneeded variable.
...
SVN revision: 35245
2008-07-29 18:55:41 +00:00
Sebastian Dransfeld
31c9bed503
Reduce the needed amount of ecore_strlcpy.
...
SVN revision: 35244
2008-07-29 18:52:27 +00:00
Miculcy Brian
cf33734edf
enable failback when empty localisation string are found
...
SVN revision: 35184
2008-07-22 13:30:25 +00:00
Sebastian Dransfeld
018b1cae14
FDO Trash.
...
SVN revision: 35129
2008-07-16 19:45:12 +00:00
Sebastian Dransfeld
2daf954148
Fix single quouting, patch from ���������� ����������
...
SVN revision: 35013
2008-07-06 14:06:31 +00:00
Carsten Haitzler
43821d36e4
* add efreet garbage data check
...
* remove printfs that clutter output
* add efreet file type check - only parse regular files
* chekc mmap returns correctly for MAP_FAILED results
* edje has some stubs for adding script-only objecvts - but nothing useful
right now
SVN revision: 34689
2008-05-29 02:00:04 +00:00
Dan Sinclair
cecac6f9d6
- add comments
...
- fix formatting
SVN revision: 34512
2008-05-08 14:22:21 +00:00
Carsten Haitzler
69a1a1a2e0
slackdood seems to report creating new apps is broken. this may be it.
...
SVN revision: 34508
2008-05-08 07:11:48 +00:00
Dan Sinclair
3322ce3b12
- deal with blank lines outside the invalid file checks
...
- this fixes the warning about a missing = sign
- you can have a blank value set on a key
- this fixes the warnings about invalid key=value pairs
- formatting changes
SVN revision: 34496
2008-05-07 04:14:45 +00:00
Dan Sinclair
3624e4e923
- if we can't parse the INI file we can't set ini->data so return NULL
...
instead of an invalid ini file
SVN revision: 34493
2008-05-07 03:04:58 +00:00
Dan Sinclair
74b5878da7
- fix warnings
...
SVN revision: 34490
2008-05-07 02:16:50 +00:00
Cedric BAIL
14a01955ef
Switch efreet_ini_parse to use mmap instead of fopen. Small speed improvements and little code cleanup.
...
FIXME: If people wonder we are loosing 50% of efreet time inside ecore_hash_* and ecore_string_*.
SVN revision: 34482
2008-05-06 15:56:40 +00:00
Carsten Haitzler
9e6e6a86e2
efreet segv maker removed. bad unescaping causing segvs! fixxored.
...
SVN revision: 34445
2008-05-03 09:25:43 +00:00
Sebastian Dransfeld
b495b19470
formatting
...
SVN revision: 34212
2008-04-07 05:52:45 +00:00
Carsten Haitzler
ec51ff71c6
1. stop doing unaligned memory accesses - htons() on a pointer to some
...
arbitrary point...
2. use int not long - long will be 64bit on 64bit platforms, but 32bit almost
everywhere (yes in theory it may not - but in practice, it won't - long
though will vary).
SVN revision: 34211
2008-04-06 23:02:54 +00:00
Dan Sinclair
a81974fe1f
- patch from Michael <sECuRE+e17 at twice-irc dot de> to fix possible mem
...
leak in efreet_desktop
SVN revision: 34050
2008-03-18 04:01:41 +00:00
Sebastian Dransfeld
0fdd25e671
TODO++
...
SVN revision: 33833
2008-02-24 19:20:08 +00:00
Sebastian Dransfeld
cbe6386bc4
Fix callback to match changed function prototype.
...
SVN revision: 33831
2008-02-24 19:12:49 +00:00
Carsten Haitzler
e6694ca7b4
fix doxy
...
SVN revision: 33798
2008-02-20 15:39:03 +00:00
Carsten Haitzler
d522fc9e09
return the void pointer return val from the run cb - not just 1 or 0 :) a
...
superset here...
SVN revision: 33793
2008-02-20 04:10:02 +00:00