add API eina_file_path_is_absolute() #37

New Issue

vtorri · 2023-09-27T12:32:18-07:00

vtorri commented

2023-09-27 12:32:18 -07:00

$ git grep path_is_absolute
lib/eina/eina_file_win32.c:   return !evil_path_is_absolute(path);
lib/eina/eina_prefix.c:# include <evil_private.h> /* path_is_absolute realpath dladdr */
lib/eina/eina_prefix.c:   return evil_path_is_absolute(path);
lib/elementary/efl_ui_image.c:_path_is_absolute(const char *path)
lib/elementary/efl_ui_image.c:_path_is_absolute(const char *path)
lib/elementary/efl_ui_image.c:   if (_path_is_absolute(name))
lib/elementary/efl_ui_image_zoomable.c:_path_is_absolute(const char *path)
lib/elementary/efl_ui_image_zoomable.c:_path_is_absolute(const char *path)
lib/elementary/efl_ui_image_zoomable.c:   if (_path_is_absolute(name))
lib/elementary/elm_icon.c:_path_is_absolute(const char *path)
lib/elementary/elm_icon.c:_path_is_absolute(const char *path)
lib/elementary/elm_icon.c:   if (_path_is_absolute(name))
lib/elementary/elm_prefs.c:        if (!evil_path_is_absolute(file)) /* relative */
lib/evas/canvas/evas_font_dir.c:# include <evil_private.h> /* evil_path_is_absolute */
lib/evas/canvas/evas_font_dir.c:   if (evil_path_is_absolute(path)) return 1;
lib/evas/file/evas_path.c:# include <evil_private.h> /* evil_path_is_absolute */
lib/evas/file/evas_path.c:   if (evil_path_is_absolute(path)) return 1;
lib/evil/evil_util.c:evil_path_is_absolute(const char *path)
lib/evil/evil_util.h:EVIL_API int evil_path_is_absolute(const char *path);

and

$ git grep eina_file_path_relative
lib/eina/eina_file_common.c:   if (eina_file_path_relative(path))
lib/eina/eina_file_common.h:Eina_Bool eina_file_path_relative(const char *path);
lib/eina/eina_file_posix.c:eina_file_path_relative(const char *path)
lib/eina/eina_file_win32.c:eina_file_path_relative(const char *path)

I think that an API like eina_file_path_is_absolute() in eina_file_common.c should factorize a bit the code

``` $ git grep path_is_absolute lib/eina/eina_file_win32.c: return !evil_path_is_absolute(path); lib/eina/eina_prefix.c:# include <evil_private.h> /* path_is_absolute realpath dladdr */ lib/eina/eina_prefix.c: return evil_path_is_absolute(path); lib/elementary/efl_ui_image.c:_path_is_absolute(const char *path) lib/elementary/efl_ui_image.c:_path_is_absolute(const char *path) lib/elementary/efl_ui_image.c: if (_path_is_absolute(name)) lib/elementary/efl_ui_image_zoomable.c:_path_is_absolute(const char *path) lib/elementary/efl_ui_image_zoomable.c:_path_is_absolute(const char *path) lib/elementary/efl_ui_image_zoomable.c: if (_path_is_absolute(name)) lib/elementary/elm_icon.c:_path_is_absolute(const char *path) lib/elementary/elm_icon.c:_path_is_absolute(const char *path) lib/elementary/elm_icon.c: if (_path_is_absolute(name)) lib/elementary/elm_prefs.c: if (!evil_path_is_absolute(file)) /* relative */ lib/evas/canvas/evas_font_dir.c:# include <evil_private.h> /* evil_path_is_absolute */ lib/evas/canvas/evas_font_dir.c: if (evil_path_is_absolute(path)) return 1; lib/evas/file/evas_path.c:# include <evil_private.h> /* evil_path_is_absolute */ lib/evas/file/evas_path.c: if (evil_path_is_absolute(path)) return 1; lib/evil/evil_util.c:evil_path_is_absolute(const char *path) lib/evil/evil_util.h:EVIL_API int evil_path_is_absolute(const char *path); ``` and ``` $ git grep eina_file_path_relative lib/eina/eina_file_common.c: if (eina_file_path_relative(path)) lib/eina/eina_file_common.h:Eina_Bool eina_file_path_relative(const char *path); lib/eina/eina_file_posix.c:eina_file_path_relative(const char *path) lib/eina/eina_file_win32.c:eina_file_path_relative(const char *path) ``` I think that an API like `eina_file_path_is_absolute()` in eina_file_common.c should factorize a bit the code

vtorri commented

2023-12-25 23:39:28 -08:00

fixed in 8272318d71

fixed in 8272318d71b9a1817e77c3317b48bcd84326be52

vtorri closed this issue

2023-12-25 23:39:44 -08:00

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: enlightenment/efl#37