enlightenment/efl
enlightenment
/
efl
8
7
Fork 14
Code Issues 13 Pull Requests 6 Projects Releases Wiki Activity

WIP: Solve meson warnings and deprecations #47

Draft
dimmus wants to merge 14 commits from dimmus/efl:devs/dimmus/meson into master
pull from: dimmus/efl:devs/dimmus/meson
merge into: enlightenment:master
Conversation 2 Commits 14 Files Changed 38 +5 -1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 44b009c129 - Show all commits

6
src/lib/eina/meson.build
View File

@ -361,7 +361,11 @@ if unwind.found()
endif
#for the case that the iconv library is not part of libc but rather libiconv or smth. like that
iconv = dependency('iconv', required: false)
if meson.version().version_compare('>=0.60')
iconv = dependency('iconv', method: 'auto')
else
iconv = dependency('iconv', required: false)
eschwartz commented 2023-12-05 06:05:56 -08:00
Review
Copy Link

If you're looking up iconv in both sides of the branch, what's the point? Just use dependency('', required: false) to get a null dependency.

If you're looking up iconv in both sides of the branch, what's the point? Just use `dependency('', required: false)` to get a null dependency.
dimmus commented 2023-12-05 06:43:13 -08:00
Review
Copy Link

It is a try to fight with the warning:
* 0.60.0: {'dep 'iconv' custom lookup'}

It is a try to fight with the warning: ` * 0.60.0: {'dep 'iconv' custom lookup'}`
eschwartz commented 2023-12-05 07:47:03 -08:00
Review
Copy Link

The thing is that you are still hitting the bad codepath for older versions of meson...

The thing is that you are still hitting the bad codepath for older versions of meson...
dimmus commented 2023-12-05 09:14:49 -08:00
Review
Copy Link

Would be very appreciated if you could provide a link to the example with the novel meson coding approach.

Would be very appreciated if you could provide a link to the example with the novel meson coding approach.
endif
if iconv.found() == false
iconv = cc.find_library('iconv', required: false)
endif