Commit Graph

413 Commits

Author SHA1 Message Date
Jean-Philippe Andre f7622dffe3 fix build with a build dir 2017-09-04 12:10:59 +09:00
zmike 32c53b57e4 use spacebar for toggling play/pause in player view 2017-05-19 13:44:21 -04:00
zmike cf2057ae96 avoid crash when showing bg tooltip if callback is reached unexpectedly 2016-10-05 18:20:32 -04:00
zmike 00af2f5fbe lock overlay to visible while a menu is open 2016-10-05 18:20:32 -04:00
zmike 6a402bdab4 add some connected checks in empdd methods
ensure mpd functions don't crash when null connection object is passed
2016-08-12 13:35:11 -04:00
Mike Blumenkrantz 8cfc6f6553 ensure empd_song_item exists before trying to show it on list change 2016-06-17 12:08:05 -04:00
Mike Blumenkrantz 4ce1ea622d handle case where new songs are inserted to the middle of the list
math++++
2016-06-17 12:07:22 -04:00
Mike Blumenkrantz f35a5f247e add safety abort() for items added without a header since this is a bug 2016-06-17 12:06:36 -04:00
Mike Blumenkrantz 37ecf51b45 use detected insert point as header if it has no subitems during queue handler
fixes an issue where deleting an album could accidentally append new songs without
any header item
2016-06-17 12:02:23 -04:00
Mike Blumenkrantz 024fcefe0f use detected insert point as header during update if no parent item exists
fixes crash when updating the last album in the queue
2016-06-10 11:51:50 -04:00
Mike Blumenkrantz 251376703b ensure parent item exists before using parent data during queue item delete
this is not true during window deletion
2016-05-28 13:12:22 -04:00
Mike Blumenkrantz d2ce216f6d handle case where metadata fails to return an image object to bg_add on update 2016-05-28 11:28:44 -04:00
Mike Blumenkrantz de9c5b31c5 make ctrl+wheel album skipping more accurate when wrapping first<->last item
fixes awkward case where trying to skip to the previous album from the last album
in the queue would go to the first album
2016-05-28 11:27:58 -04:00
Mike Blumenkrantz a83e832aeb ensure song item headers are accurately detected when calculating insert point 2016-05-02 18:15:30 -04:00
Mike Blumenkrantz 3f5dda8e9c hide filesystem search entry when all text has been deleted 2016-04-30 14:42:15 -04:00
Mike Blumenkrantz 08ee5e766b ensure a header song item is used when inserting a new header song item
fixes blank items after deletion
2016-04-30 14:28:44 -04:00
Mike Blumenkrantz 1e8a11ad2f reject non-printable characters when beginning filesystem search
#okra
2016-04-01 14:56:31 -04:00
Mike Blumenkrantz 39bc858b20 handle incremental queue version updating in the ui
this removes a number of workarounds related to deleting items from the queue
and significantly improves ui responsiveness when editing the queue

ref T3147
2016-02-06 21:09:57 -05:00
Mike Blumenkrantz 86f5a0324e automatically update queue list headers when an item is removed
this is done manually in a few places but it's much more convenient
to enforce policy in the delete callback
2016-02-06 21:08:53 -05:00
Mike Blumenkrantz 8db5763d08 ensure that clipboard pastes are handled asynchronously
if more status calls occur before the queue updates, the clipboard
data would be erroneously consumed here, preventing the operation from
succeeding (and ruining the queue)
2016-02-06 21:05:30 -05:00
Mike Blumenkrantz 1daabc4f2b don't show total track count in tooltip if track number is larger than total
this isn't a totally accurate method of showing the track count, so at least
be less obvious about it in cases where it's flagrantly wrong
2016-02-06 21:03:54 -05:00
Mike Blumenkrantz ba50156ec4 add signal/handling for managing queue list changes using incremental updates
this is a significantly more lightweight method of updating the current queue
after any changes have been made, allowing clients to perform updates on only
part of the current queue instead of receiving the entire thing in a giant
chunk any time a change occurs
2016-02-06 21:01:39 -05:00
Mike Blumenkrantz 4db0a19dd3 trigger empdd status pings immediately in more method calls
this greatly improves ui responsiveness
2016-02-06 21:00:36 -05:00
Mike Blumenkrantz f501bb4542 convert array usage in empdd to lists 2016-02-06 20:59:55 -05:00
Mike Blumenkrantz fd7ae69962 exit without crashing when empdd is run manually with --option
fix T2591
2015-11-24 21:32:19 -05:00
Mike Blumenkrantz 912accae99 add ctrl+Delete keybind on player view to delete current album 2015-11-06 17:27:06 -05:00
Mike Blumenkrantz 3a149bc52c break out ranged queue list deletion into util function 2015-11-06 17:26:08 -05:00
zmike 5d1baba0aa allow enter key to activate first selected item in player view 2015-09-16 18:11:58 -04:00
zmike 2157ed3e66 force updates on current song info display when queue list updates
should improve handling when metadata for current song is changed
2015-09-08 22:33:22 -04:00
Mike Blumenkrantz 9ada1350ea trigger login box on failure to gather mpd host info on startup 2015-09-06 22:30:34 -04:00
Mike Blumenkrantz 71427769de explicitly attempt to start empdd from empc on startup
this fixes autoconnection on more pedantic systems: gentoo doesn't
seem to need it, yet fedora does?

by making StartServiceByName the first call, it's easier to know if
empdd needs a connect() method call and then to send it before any
other method calls so that startup remains smooth behind the scenes
2015-09-06 22:21:20 -04:00
Mike Blumenkrantz 5cd08a5df9 allow empdd to start up without connection info
in the case of being started by dbus, no environment variables are
available, so making a connection based on the usual MPD_* variables
will be impossible; instead, ensure that the daemon can idle peacefully
while doing nothing until someone attempts to connect it
2015-09-06 22:21:20 -04:00
Mike Blumenkrantz 627050e55f break out dbus popup of doom into separate function for reuse 2015-09-06 22:21:20 -04:00
zmike e893b6cbc1 fix prev_album skip action when activating during the first album
this should wrap back to the last album, not repeatedly skip to the
first album
2015-08-17 19:51:16 -04:00
zmike 8eafb3e56e block Delete current song deletion if not in player view 2015-07-12 15:17:17 -04:00
Mike Blumenkrantz 6ae5d03f82 delete key on player view deletes current song 2015-06-08 08:01:27 -04:00
zmike 88a10f3497 refresh current filesystem's realized items after completing a url paste
should fix race condition when attempting to load the pasted/saved url
out of the cache immediately after the paste
2015-04-16 08:50:38 -04:00
zmike b5f571087e export empd_queue_length for use in modules 2015-04-15 22:12:55 -04:00
zmike 2a580715ed use int for empd_song_track
a song can have a track == 0, which results in multiple "empc,bg,changed" signal
callbacks being added, which ruins cover animations
2015-04-11 11:43:30 -04:00
zmike 5889bf4551 force layout recalc before completing cover animation
this will end up being a big recalc since it has to handle a newly-swallowed
object, so it's better to complete it before starting the next animation to
ensure that no frames get dropped
2015-04-10 10:29:40 -04:00
zmike 3c5caf9f7e always show filesystem add/refresh buttons again after entry hide 2015-04-07 18:44:47 -04:00
zmike eec74c14b0 remove straggler edje file reloading code 2015-04-07 18:44:46 -04:00
Mike Blumenkrantz 7e2b1a47ab block filesystem entry activation for invalid key presses
mainly filtering backspace \b
2015-03-10 13:56:57 -04:00
Mike Blumenkrantz 38fffbd489 don't unexpectedly block entry shortcuts when filesystem entry is visible 2015-03-10 13:38:23 -04:00
Mike Blumenkrantz 7aea5c7a21 attempt to disable awful giant blue focus rectangles
ref T2193
2015-03-09 17:30:03 -04:00
Mike Blumenkrantz 37e4f02850 ensure correct button/back state on filesystem layout when hiding entry 2015-03-09 17:06:55 -04:00
Mike Blumenkrantz 11592116f5 fix BackSpace keyname in filesystem entry key handler 2015-03-09 16:57:43 -04:00
Mike Blumenkrantz fd566329eb filesystem entry receives focus now to fix backspace+compose functionality 2015-03-09 16:57:41 -04:00
Mike Blumenkrantz 514c60df50 disable focus on filesystem gengrid while entry is active 2015-03-09 16:54:58 -04:00
Mike Blumenkrantz fd4ae8f791 pressing enter while filesystem entry is active now activates current item 2015-03-09 16:54:58 -04:00