Commit Graph

173 Commits

Author SHA1 Message Date
Hermet Park 514708d908 get rid of unstable eolian usage - 3,
Now it works, yet has some issues.
2019-08-18 03:08:50 +09:00
Hermet Park 5c52175885 get rid of unstable eolian usage - 2,
Now it's buildable but still not working properly.
2019-08-18 03:07:31 +09:00
Hermet Park 08a9678c1b edc_editor: fix compile warnings.
rearrange data size to avoid possible data overflow.
2019-02-28 13:45:09 +09:00
Hermet Park 42dec185fa edc_editor: polishing code.
put EINA_UNUSED flags for unused parameters.
2019-02-28 13:28:49 +09:00
Hermet Park 60e51fccbe edc_editor: don't access the danling edit object. 2019-02-28 13:26:59 +09:00
YeongJong Lee 973440ef04 edc_editor: Fix the linenumber scrolling
Summary:
Editor line number is scrollable horizontally
This patch fix the line number scrolling

ref T4276

Test Plan:
1. Open enventor
2. Scroll the scrollerbar horizontally in edc_editor
3. check that the line number entry is fixed

Reviewers: Jaehyun_Cho

Maniphest Tasks: T4276

Differential Revision: https://phab.enlightenment.org/D4901
2017-11-30 22:40:14 +09:00
Jaehyun Cho bb012c843e Revert "edc_editor: Prevent auto-scrolling by scroller"
This reverts commit b13596ac2c.

The auto-scroll issue has been fixed by efl update without this patch.
2017-11-24 10:23:12 +09:00
YeongJong Lee b13596ac2c edc_editor: Prevent auto-scrolling by scroller
Summary:
scroller had auto-scroll properties.
In detail, when the content of scroller have focus, the scroller scroll top-left
position of the content.

But enventor does not want to auto-scroll.
This prevent it.

Ref : 44e40c7c5e4549e78008eb7b74b6ab1b7e1fcf9d

Test Plan:
1. Open enventor basic template
2. Scroll down
3. click edc_editor

Reviewers: Jaehyun_Cho, cedric

Reviewed By: cedric

Subscribers: jpeg, cedric

Differential Revision: https://phab.enlightenment.org/D4930
2017-07-10 20:33:34 +09:00
YeongJong Lee 324454b3cb goto: fix scroll issue
Summary:
Add scroller_region_show method.

fix https://phab.enlightenment.org/T4416

Test Plan:
1. Run enventor
2. Open goto window using shortcut key(<Ctrl> + <l>)
3. type line number
4. check the scroller scroll correctly

Reviewers: Jaehyun_Cho, Hermet

Reviewed By: Jaehyun_Cho

Differential Revision: https://phab.enlightenment.org/D4619
2017-02-02 10:44:01 +09:00
Jaehyun Cho d796f89805 edc_editor: Fix not to append candidate slider values after error code.
When error code is saved, cursor moves to the error code.

This cursor position change causes that candidate slider values are
appended after error code because cursor position moved to error code.
This patch restores cursor position to candidate keyword.

As a result, candidate slider values are always appended after candidate
keyword.
2016-11-25 16:02:17 +09:00
Hermet Park 9504c8a634 edc_editor: fix memory leaks.
evas_textblock_cursor_content_get() requires free the returned data.
2016-08-27 23:25:24 +09:00
Hermet Park cab3e34fa4 editor/parser: fix memory leaks detected by valgrind. 2016-08-27 16:26:41 +09:00
Hermet Park a0b9d4e911 edc_editor: rewrite 5ea2c05dec
We found a side effect from that patch. So rewrite it with an other approach.
It's a hackish but no idea except it :(
2016-08-25 17:22:47 +09:00
Hermet Park 5ea2c05dec edc_editor: fix syntax color issue.
Some cases, the edc editor can't apply syntax color
when it opens a new edc file.

we can cover this scanerio by trying  syntax color logic again
until it's succeed.

@T4275
2016-08-24 16:40:18 +09:00
Hermet Park c45c13d8bc cleanup unused warning. 2016-08-24 12:53:11 +09:00
Hermet Park 1e5ae3db45 stablize unstable worker threads.
Still there are unsafe thread functions that access invalid memory.
fix all of them.
2016-08-23 08:05:14 +09:00
Taehyub Kim f0ab0ec9a9 edc_parser: move the functions in utils which are find_part and find_group to the edc_parser
Summary:
move hte functions in utils which are find_part and find_group to the edc_parser
since it is right way

Test Plan:
1. launch enventor
2. move cursor on part name in text view
3. press F3 key
4. check it works well

Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D4240
2016-08-19 12:56:21 +09:00
Taehyub Kim 7e1a4c00a7 edc_editor: add NULL checking in edit_cursor_double_clicked_cb
Summary:
add NULL checking in edit_cursor_double_clicked_cb
@fix

Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D4234
2016-08-17 22:29:31 +09:00
Taehyub Kim bc5a7b3c36 edc_editor: support to jump to the part define
Summary: add the new feature to jump to the part define

Test Plan:
1. launch enventor
2. click mouse right button on "relative to" part name in text view
3. check selection is on the part define

Reviewers: Hermet, NikaWhite, bowonryu, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Tags: #enventor

Differential Revision: https://phab.enlightenment.org/D4167
2016-08-16 22:00:01 +09:00
Hermet Park 5836cc702a edc_edit: code refactoring.
just internal function name change.
2016-08-15 15:00:37 +09:00
Hermet Park 65267ba2fd file tab: stablizing file switching behavior.
There are still corner case bugs.

one is issued by unsafe thread working
and the other one is group switching.

fixed all in all.
2016-08-12 04:00:17 +09:00
Jean-Philippe Andre 3af6ede5e5 clang: Fix warnings and compilation errors
enventor wouldn't compile with clang. Also, it would print
a lot of warnings.
2016-08-10 15:17:41 +09:00
Hermet Park 780cf89dcc edc_editor: fix missing shortcut key updation. 2016-08-08 23:59:52 +09:00
Hermet Park b3afcc4810 file_browser: stabilizing switching main edc file function. 2016-08-08 23:58:08 +09:00
Hermet Park b663b04096 edc_editor: add missing null out. 2016-08-05 16:34:20 +09:00
Hermet Park 1a9d5dcba7 edc_editor: one more thread safe code.
This patch is another same fix to e24efc9c7e.
2016-08-04 20:45:42 +09:00
Jaehyun Cho a4b07dad96 edc_editor: Fix to remove focus highlight on template selection button.
This patch is temporary patch to remove focus highlight on template
selection button of new file open. (enventor -t)
Without this patch, en_edit cannot get focus because its visibility is
set with false.
2016-08-04 20:14:40 +09:00
Hermet Park c5f59c63b8 edc_editor: fix a potential error.
Terminate redoundo instance after edc editor private resources are removed.
Redoundo has a entry delete callback, and it frees the redoundo private memory there.

But, if a redoundo instance is removed before entry delete callback is called,
invalid memory access will be happened.

Acutally this's broken memory.

So prevent this scenario by correcting function call order.

@fix
2016-08-04 19:10:21 +09:00
Hermet Park 43cfa31a14 edc_editor: show an image on cursor "images.image" 2016-08-03 16:39:26 +09:00
Hermet Park af4ec62a1b edc_editor: ++secure code.
just in case, if the animator is called after ed instance is removed.
2016-08-03 00:38:03 +09:00
Hermet Park 3db26261f7 multi-file: support syntax_colors.
a# Please enter the commit message for your changes. Lines starting
2016-07-27 15:37:46 +09:00
Hermet Park 0462d04c0d multi-file: support quick jump (F5)
if you press F5 on "#include xxxx" line,
Enventor will open that include file.

Conflicts:
	src/lib/edc_parser.c
2016-07-22 16:19:46 +09:00
Hermet Park 32bcf8b985 multi-file: allow to open an empty file. 2016-07-21 20:59:54 +09:00
Hermet Park eda850d9db multi-file: support edc navigator. 2016-07-21 20:53:13 +09:00
Hermet Park 505ea04e28 edc_editor: removed unused var. 2016-07-21 17:31:17 +09:00
Hermet Park 4b8f989090 multi-file: re-implemented item grouping infra.
Changed item concept that only one item can represent the enventor object.
I'd thought multiple editors of Enventor could be active at the same time,
but it brought Enventor Lib has over-concept feature,
because Enventor App doesn't support it so far.
2016-07-07 20:34:42 +09:00
Hermet Park d6f61c9963 multi-file: consolidate bodies. 2016-07-07 18:42:13 +09:00
Hermet Park 65a0e198da fix a side effect that missed a main item focus.
this is introduced from c59be9cf1b.
2016-07-07 16:49:14 +09:00
Hermet Park c59be9cf1b multi-file: ++implementation.
1. make it work with template insert feature.
2. dissmiss inactivated item's view sync callbacks.
2016-07-07 16:21:03 +09:00
Hermet Park 0384f50f01 multi-file: find the first group when edc item has a focus.
This properly switchs a current focused item view on realtime.
That means, when user switch files, it will display the first group
view in a new selected file.
2016-07-07 12:03:53 +09:00
Hermet Park 193ec29fa0 multi-file: support live editor.
Additional implementation.
Now it works for live editing.
2016-07-04 17:53:54 +09:00
Hermet Park 6780f25ad4 multi-file: redoundo implemtation.
Still a lots of changes required... >.<
2016-07-04 15:09:26 +09:00
Hermet Park 4353d98bac multi-file: make multi files work for auto completion. 2016-07-04 13:07:24 +09:00
Hermet Park e4896f1090 multi-file: ++implementation.
Now it works on search/replace.

API changes.
Below object APIs replaced with item APIs.

enventor_object_text_get()
enventor_object_text_insert()
enventor_object_selection_get()
enventor_object_cursor_pos_get()
enventor_object_cursor_pos_set()
enventor_object_select_none()
enventor_object_select_region_set()
enventor_object_syntax_color_partial_apply()
enventor_object_syntax_color_full_apply()
2016-07-02 17:32:11 +09:00
Hermet Park 5e8d2e518d fixed all compile warning stuff. 2016-07-02 14:09:42 +09:00
Hermet Park e93ab43319 ++ multi file editing feature implementation. 2016-07-01 23:59:17 +09:00
Hermet Park e61cfb6124 file_tab: add a partial implmentation. 2016-06-29 20:28:11 +09:00
Taehyub Kim 4f4da34c9b edc_editor: rearrange selected part to be placed in center
Summary:
When we search the word or click part in live edit view and edc navigator,
The corresponding name in text view is selected, but it is not center align.
So I make it center align when the word is selected.

@T3326

Test Plan:
1. launch enventor
2. open search window
3. input any word in script
4. click ok forward button
5. check selection part if it is placed in center
6. click a part in live edit view
7. check selection part if it is placed in center
8. click a part name in edc navigator
9. check selection part if it is placed in center

Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu

Differential Revision: https://phab.enlightenment.org/D4059
2016-06-20 13:10:36 +09:00
Hermet Park 234b1926fc Revert "temporary change for release v0.9.0"
This reverts commit 847e84b12d.

enventor v0.9.0 was released.
2016-06-06 17:32:37 +09:00
Hermet Park 847e84b12d temporary change for release v0.9.0 2016-06-06 17:26:42 +09:00