Summary: fix the view resize callback
Test Plan:
1. launch enventor
2. run group template
3. change the view size
4. change the group
5. change the view size
6. change the group to firxt
7. see the result
Reviewers: Hermet, NikaWhite, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4208
Summary: when group is changed, view information should be updated
Test Plan:
1. launch enventor
2. run group template
3. change the view size
4. change the group
5. change the view size
6. change the group to firxt
7. see the result
Reviewers: Hermet, NikaWhite, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4207
Summary: GUI composed of the edc layout.
Test Plan:
1. enventor
2. press F1 Key
Reviewers: Hermet, Jaehyun_Cho, herb
Differential Revision: https://phab.enlightenment.org/D4187
This reverts commit 335575eb84
Although using macro as a group name is not a common usage, but it takes
a lot of efforts to maintain and implement new features based on this.
Summary:
In case of the live edit item has min size without relative to part,
the size of the item should not be changed.
To cover this case, I added more condition
Test Plan:
1. launch envnetor
2. click a live edit item on tools
3. check the fixed option without "relative to" setting
4. insert the item with mouse double click
5. see the min size of the item while the view size is changing
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Differential Revision: https://phab.enlightenment.org/D4173
When go to window is unfocused, window is closed.
Though this behavior was intended, the functionality was not quite nice.
Even this caused a weired behavior(bug) on windows that,
go to window was closed when it's minimized.
So get rid of this policy!
@fix T3922
If user don't specify the workspace path,
Enventor set the workspace path to current directory path
while turning off file browser and file tab function in default.
Previously each live edit components are messed up in stacking.
Restacked by putting wireframe, dummy objects
below live edit object, control points, align lines and texts.
This required a totally hackishy method but there are no other solution so far.
@fix T4026
fix a side effect of localizing floats.
_posix_fp() uses static stringbuffer.
If this function is called multiple times in printf(),
previous buffer data will be invalid.
we are calling this for x, y twice in one func.
Summary:
Enventor live edit would generate invalid code with
the french locale.
Indeed, french uses a comma (",") as the decimal point,
instead of the dot. With localization enabled, printf()
would automatically localized the floating point,
introducing a comma in the edje code where a dot is
expected...
To avoid this, we now enclose the floats we don't want
to be localized (use the implicit POSIX local: with a dot)
in a function that looks the current locale and replace
the decimal point with a dot.
Test Plan:
(1) Without the patch, call LC_ALL=C enventor and see live
edit if correct.
(2) Without the patch, call LC_ALL=fr_FR.UTF-8 envetor and
see live edit generate invalid edje code.
(3) Apply the patch, and repeat steps (1) and (2) and observe
that both cases now success.
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D4146
Summary:
current error message is hard to read.
if the message has a syntax color, then it will be better.
Reviewers: Hermet, herb, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4124
Previously, searching files in file browser causes crash.
Now, each file browser data contains genlist item and the genlist item
is also deleted when the file browser data is deallocated.
Changed item concept that only one item can represent the enventor object.
I'd thought multiple editors of Enventor could be active at the same time,
but it brought Enventor Lib has over-concept feature,
because Enventor App doesn't support it so far.
I didn't dig further, but that corrupted enventor menu/setting.
probably, eina_stringshare ocurred memory corrution...?
anyhow, its useless to apply same font again.
@fix T4013
This properly switchs a current focused item view on realtime.
That means, when user switch files, it will display the first group
view in a new selected file.
Summary: change the description
Test Plan:
1. open new file
2. see the template name
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Differential Revision: https://phab.enlightenment.org/D4091
Conflicts:
data/templates/Makefile.am
Summary: align line should be shown always on live edit item
Test Plan:
1. launch enventor
2. click an live edit item on tools
3. move and align the item
4. see the align line on other parts
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4121
Like the file browser, file_tab will be forcely disabled if the workspace were
not given by user. In that case, file tab would have false always.
So, it needs restore mechanism for original file tab value.
Now it works on search/replace.
API changes.
Below object APIs replaced with item APIs.
enventor_object_text_get()
enventor_object_text_insert()
enventor_object_selection_get()
enventor_object_cursor_pos_get()
enventor_object_cursor_pos_set()
enventor_object_select_none()
enventor_object_select_region_set()
enventor_object_syntax_color_partial_apply()
enventor_object_syntax_color_full_apply()
It wont set the view size if the statusbar were disabled.
This time, statusbar is almost mandatory function.
So, regardless of statusbar activation,
Enventor updates the view size and mouse cursor info.
@fix T3974
Summary:
if grammatically incorrect EDC file is opened, then
Undo causes error caution (with red alert) even though
there is no Undo action.
Test Plan:
1. Make incorrect EDC file. (e.g. Write "aaaa" in EDC file incorrectly)
2. Save the wrong EDC file.
3. Newly open the wrong EDC file.
4. press Undo button and it causes error caution.
Reviewers: Hermet, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4118
Summary:
When we add a live edit item, it is convenient to be support part outline.
so I added part outline feature. It can be toggling.
@T3626
Test Plan:
1. launch enventor
2. activate parts outline item on tools
3. see the parts outline in live edit view
Reviewers: Hermet, NikaWhite, bowonryu, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4071
Summary: change the description of fixed mode
Test Plan:
1. click a live edit item on tools
2. see the description of fixed mode in live view
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4106
Summary: change the description of build setting
Test Plan:
1. show the build setting
2. see the path title
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4105
Summary: change the descrtipion for the tools for live edit mode
Test Plan:
1. move the mouse cursor on part highlighting, dummy parts and mirror mode tools
2. see the tooltip messages
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4103
Summary: change the description
Test Plan:
1. Open basic.edc template
2. remove the annotation of program part
3. Show EDC Navigator
4. move the mouse cursor on the button of Program which have rectangle icon.
5. move the mouse cursor on the button of program which have triangle icon.
6. see the each tooltip messages.
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4102
Summary: change the description
Test Plan:
1. open setting menue
2. move the mouse cursor on View Size, Auto Hiding Console, Smart Undo/Redo and Error Message Alert
3. see the tooltip messages
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4099
Summary: change the description of window layout
Test Plan:
1. move the mouse cursor on EDC Navigator and Status item of tools
2. see the tooltip messages
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4098
Summary: change the description
Test Plan:
1. move the mouse cursor on each statusbar item
(Resize, Swap and Group)
2. see the tooltip messages
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4097
Summary: change the description
Test Plan:
1. move the mouse cursor on each live edit item
2. see the tooltip messages
Reviewers: Hermet, NikaWhite, Jaehyun_Cho, bowonryu
Differential Revision: https://phab.enlightenment.org/D4095
Summary: change the description
Test Plan:
1. toggle dummy parts, mirror mode and parth highlighting
2. see the result
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4094
Added a toggle option in setting.
and replaced the status shortcut key to F8 from F11.
Now, tools shortcut key is moved to F7.
This change is such a pre-requisition for a file tab feature.
Summary: change the description
Test Plan:
1. input some text into text view
2. click x button of enventor window
3. see the popup message
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4092
Summary: change the description
Test Plan:
1. open search window
2. see the text
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D4090
Summary:
the line is over than 80 character.
@fix
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D4083
Summary:
ux update for text setting.
add dec & inc buttons and spinner for font_size slider.
Test Plan: esc > settings > text editor
Reviewers: Hermet, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D4057
Summary:
When we search the word or click part in live edit view and edc navigator,
The corresponding name in text view is selected, but it is not center align.
So I make it center align when the word is selected.
@T3326
Test Plan:
1. launch enventor
2. open search window
3. input any word in script
4. click ok forward button
5. check selection part if it is placed in center
6. click a part in live edit view
7. check selection part if it is placed in center
8. click a part name in edc navigator
9. check selection part if it is placed in center
Reviewers: Hermet, Jaehyun_Cho, NikaWhite, bowonryu
Differential Revision: https://phab.enlightenment.org/D4059
Summary:
There are some hole cases.
For example, if we want to input fixed part
then we had to check fixed option first.
but now, we can input fixed part in any order.
In addition, Unnecessary codes are removed
and added more comments.
Test Plan:
1. launch envnetor.
2. make a live edit item by clicking live edit item on tools.
3. set relatives for the live edit item.
4. double click and insert the item.
5. see the result.
Reviewers: Jaehyun_Cho, NikaWhite, bowonryu, Hermet
Differential Revision: https://phab.enlightenment.org/D4047
ECORE_GETOPT_STORE_METAVAR_STR() prints additional information such as
"TYPE: STR".
Not to print "TYPE: STR", ECORE_GETOPT_APPEND_METAVAR() is used for
workspace path option.
Workspace path option did not work because option type was changed
incorrectly.
Now the option type has been changed from list strings to one string
correctly.
Summary: add build setting tooltip messeges
Test Plan:
1. launch enventor
2. go settign menu
3. click EDC build tab
4. move mouse cursor on each item
5. see the tooltip messeges
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D4034
Summary: add more comments for preference
Test Plan:
1. launch enventor
2. move mouse cursor on preference of setting
3. see the tooltip messeges
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D4033
Summary: add more comments for statusbar tooltip
Test Plan:
1. launch enventor
2. move mouse cursor on statusar tooltips
3. see the message of tooltips
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D4032
Summary: add more comment for broswer tooltips
Test Plan:
1. launch enventor
2. move mouse curor on broswer tooltips
3. see the message of tooltips
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D4031
Summary: add more comment of script tooltips
Test Plan:
1. launch enventor
2. move mouse cursor on script tooltip
3. see the message of tooltips
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Reviewed By: NikaWhite
Differential Revision: https://phab.enlightenment.org/D4030
Previously, autocomp list moved to selected part name position because
autocomp list did not disappear when mouse down event occurred.
Now, an event rectangle is added to catch mouse down event and autocomp
list disappears when mouse down event occurs.
@fix T3738
Previously, part highlighting worked if part highlighting button is
clicked or enventor window moves during live edit mode.
Now, part highlighting does not work during live edit mode.
@fix T3653
Previously, part highlighting worked if part highlighting button is
clicked or enventor window moves during live edit mode.
Now, part highlighting does not work during live edit mode.
@fix T3653
if image string is in comments, image shouldn't be appeared.
but edc parser didn't compares texts elaborately and it came out error.
now fixed it.
@fix T3740
when user press a part on the live view, the part name compareing is triggered.
in that sequence, cursor is jump onto the part wrt clicked part.
since, however, the string compare is not enough
the cursor could go on other part which has a similar name.
now compare them in detail to correct this
@fix T3736
Since enventor allowed user to touch outer of editor while its ctxpopup is activated,
the context could be broken.
Block whole area and prevent the context break.
@fix T3752
Previously, template code was inserted before the closing bracket.
Now, template code is inserted after the closing bracket.
Test Plan
1. Open basic.edc.
2. Put mouse cursor the end of the line 18.
3. Press Ctrl + t to insert template code of image part.
Previously, line count was not correct after textblock part is inserted
in live edit mode.
Now, line count is correctly calculated after textblock part is inserted
in live edit mode.
Test Plan
1. Insert textblock part in live edit mode.
2. Check max line number.
Summary:
live_edit: when the live edit item's width and height are fixed,
the size of live edit item should be fixed.
Test Plan:
1. launch enventor
2. click a live edit item
3. check all of fixed options
4. do not set relative_to options
5. insert the live edit item to the live view
6. check the inserted item's size whether it is fixed or not
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3976
Summary: add control toggle key for enabling and disabling auto align
Test Plan:
1. launch enventor
2. click a live edit item using toolbar item
3. move the item to the another part
4. press control key when the item is close to the another part
5. check auto align function whether it is disabled or not
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3931
Previously, current font name was not visible because scroller of font
name did not move to the current font name list item.
Now, current font name is visible.
Summary:
Enventor window stops responding on double clicking "min" on Windows.
Because of approaching the index in which the cur_context doesn't exist, the crash happens.
*cur_context[] in parser_attribute_get() edc_parser.c
Test Plan:
1. launch enventor on Windows
2. add image using live edit
3. double click "min" on editor
@TSAM-3524
Reviewers: Jaehyun_Cho, Hermet
Differential Revision: https://phab.enlightenment.org/D3972
Summary: update fixed width and height interface to choose easier
Test Plan:
1. launch enventor
2. make live edit item by clicking live edit toolbar
3. click fixed width or fixed height check item on setting interface in live edit view
4. set relative_to property by dragging the edge of the part
5. insert the live edit item
6. check the result in text view
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3962
now enventor object is nothing more than just eo interface.
actual contents are totally moved on items.
we use item interfaces to figure their zones for mouse wheel events.
Summary:
if we move a live edit item by direction key, sometimes pixel is increased by 2 pixels.
so I modified it is increaed by 1 pixed when the scale is larger than 1.0
Test Plan:
1. launch enventor
2. click a live edit item using toolbar
3. move the live edit item by direction key
4. check the change of pixel info
@T3473
Reviewers: Jaehyun_Cho, NikaWhite, Hermet
Differential Revision: https://phab.enlightenment.org/D3946
Summary:
toolbox object is not used anyware, so I remove it
@fix
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3964
spacer margin should be removed from the image
because live edit needs accruate pixel control.
on the other hands, spacer button icon needs margin.
this implementation is a little tricky but i have no idea better than this.
Summary: update live edit item when view is resized
Test Plan:
1. add a live edit item on live view
2. resize the live view using resize item on statusbar
3. see live edit item is resing well
Reviewers: Hermet, NikaWhite, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D3940
Summary:
fix the fixed condifion for relative_to.
the condition was wrong, so I fixed it.
Test Plan:
1. Launch Enventor
2. Click a Live Edit Item
3. Check fixed_w and fixed_h
4. Insert the Live Edit Item
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3943
Summary:
When we apply mirror mode, we need to considering swap relative_to,
but exist code was not checking null pointer.
so I fixed the logic.
Test Plan:
1. Launch Enventor
2. Apply Mirror Mode
3. Insert a live edit item with relative_set setting
Reviewers: Hermet, Jaehyun_Cho, NikaWhite
Differential Revision: https://phab.enlightenment.org/D3942
Taehyub Kim
Jaehyun Cho
Hermet Park
Bowon Ryu
Thiep Ha
Jean Guyomarc'h
Jaehyun Cho