Remove libexif support and code as this is now done outside of Ephoto. Remove all photocam code until photocam can rotate like elm_image and doesn't crash on certain jpegs and while zooming. Slideshow now starts in window, as usual press F11 for fullscreen. Single brower now does rotations. There is still a keybinding bug that needs to be fixed where keybindings are passed through to other pages within the naviframe.
Moved the toolbars to panels on the left side in order to make better use of space. Removed the ability to browse using the grid as it is redundant with the entry and file selector.
Summary:
Add jpg into the filter to recognitze the file type in the ephoto browser.
Fixes T1684
Reviewers: raster, Hermet, huchi
Maniphest Tasks: T1684
Differential Revision: https://phab.enlightenment.org/D1472
This reverts commit 9cae696fab.
q!
nnnls -la
efr:wq!
eet mime will always be an order of magnitude slower than evas_object_image_extension_can_load_get.
Summary:
ephoto uses evas_common_extension_can_load_get() to determine whether a certain type of file should be displayed or not.
mp3, mp4, ogg etc can be loaded by evas.
There is already code in ephoto to enable "mime" type based loading of files - commented because efreet crashed in multi thread case.
We should enable that code and fix issues in efreet.
Reviewers: raster
Differential Revision: https://phab.enlightenment.org/D1257
Use layout and edje externals for better themability when others make elm themes. Using toolbars improves the size and functionality of the icons. Remove unnecessary entry/label in single view.
Use standard icons based on icon theme to remove dependency on Faenza icons. Removed the old directory code that would provide a preview of the images in the directory. This code hasn't worked in a while and frankly is just unneccasry and would slow down the app. Remove images and theme that was shipped with Ephoto. It is no longer needed. Change style on some widgets to better match dark theme. Prepare Ephoto to be released soon.
I suppose elm will take care of making this button big
enough to be used considering user configs and such.
finger size, scale, ...
SVN revision: 75577
Now ephoto doesn't looks like other photo browsers.
OK, it's a joke, but I don't see why we shouldn't centralize it
just to make it looks like other photo browsers. Maybe their toolkits
don't support it, =D
I will centralize the single browser too, as soon as I can.
SVN revision: 75561
On Fri, Mar 9, 2012 at 2:29 PM, Hyoyoung Chang <hyoyoung@gmail.com>
wrote:
> Dear all
>
> In ephoto, elm_gengrid_item_bring_in is used.
> However some days ago, many changes was committed to elm. Also it's
> parameters are changed.
> It's patch for this.
>
> Thanks
>
SVN revision: 69074
directory. e's fileman favorites are stored in $HOME/.e/e/fileman/favorites ... you can add a directory to your favorites by
symlinking it to .e/e/fileman/favorites/
SVN revision: 60002
Inform the relevant parties when the list starts and stops getting populated, and when an entry is created, via ecore events.
Remove the pending path stuff from the thumb browser, as it is not for it.
Remove the ability to set the currently viewed file by path alone, always rely on an entry.
Correctly set the disable states on the navigation toolbar buttons when starting ephoto directly in flow mode
SVN revision: 54541
viewer object (child) may have the focus and it would die, then there
is no focused object anymore (we should have a way to revert focus to
parent when children die).
SVN revision: 54058
after actually using it to browse a directory of pictures I realized
auto-fit is something we need, and need it by default.
as we auto-fit, the zoom range makes no sense anymore... and zoom
should be percentual changes, not absolute. So now zoom increments and
decrements of 20% of the previous value, and there is no lower/upper
limits anymore.
SVN revision: 54057
Raster had his word "it is broken that way, either fix it or remove"
and thus removed it is as fixing it properly takes much more time than
I have now.
SVN revision: 54056
just add items from an animator so we give time to have a good queue
and do the insert in a batch. It will change the grid population less
often, and will trigger the grid recalc less often as well.
SVN revision: 53380
in few cases we could quickly change directories and views would still
be populating, then they could access dt->entry
(ephoto_directory_thumb.c), so we need notifiers to know it is gone
and not mess with it any further.
Then ephoto_entry_free_listener_add() is born, added it to
flow_browser and slideshow for the sake of it... it shouldn't be
needed.
SVN revision: 53341
probably this is an eina issue with last optimizations from cedric,
but I'm commenting these out for now. (if efreet_mime is no-go from
threads, must remove it from enjoy as well).
SVN revision: 53339
Well, at least that was what I had time and stamina to do. Please join
the development with your ideas and requirements.
The toolbar is now placed on top, because default.edc (from
elementary) says so. We better use elementary's profile to define the
theme to use, and a theme could have it at the bottom (mobiles?).
I've added all options to toolbar, which makes it very wide on single
image viewer. We'll later introduce toolbar item "visibility priority"
to auto-hide items and add a "More" menu if the elementary's profile
says so, other options will be to make it scrollable (as it is now).
EXIF rotation support is not right in my opinion. We're using map to
rotate, but it is not doing fine, as I said in another bug. We should
have code to request evas to load the image rotated, then we re-load
the image and it should work better (need to check how that would work
with region load from JPEG, used by elm_photocam).
Preferences are out as I ran out of time.
SVN revision: 53319
Raster, this exposes some problems with map as well. At least flipping
seems to not work properly sometimes. In my case I just use Shift+[ to
flip horizontally and it does not work.
SVN revision: 53312
* added Vincent recommended warnings (ie: -Wshadow) and also -Wextra;
* uses ac_attribute.m4 to define __UNUSED__;
* uses -Wl,--as-needed
* uses -fvisibility=hidden by default, if supported
* uses -ffunction-sections -fdata-sections + -Wl,--gc-sections
* added gettext (not tested yet, but should work)
* added quicklaunch support (not tested yet, but should work)
* make it pass make distcheck
with the optimization flags, on my 32bits machine ephoto is amazingly
44Kb binary! Of course it loads super-fast even without quicklaunch,
amazing what we can do with 44kb binary + 188kb theme (mostly about
images I'm shipping in 128x128 + 256x256 + 512x512 and other images
that should be in elementary's theme).
SVN revision: 53293
maybe the code is complaining is complaining too loud of lack of exif,
we can change that later if required.
remove the rotation animation as the case 270->0 is too confusing! it
would need some logic to rotate 270->360 then make it 0.
SVN revision: 53254
flow browser (why that name?!) is back, with the my traditional
combination of 255,0 in rgb colored buttons in edje.
tomorrow will work on slideshow and make it work.
NOTE: ProFUSION team will work on a solution to have elm_toolbar +
elm_menu to be good and provide what we have in eve/enjoy in a more
generic way without thousand lines of macros in EDC. The goal is to
have configurable implementation that would provide some UI on desktop
and another on embedded, also showing buttons as we have space, and
hidding them with an automatic "more" entry if there is no space for
all items. That should improve eve, enjoy, ephoto and possibly others.
SVN revision: 53250
I was about to move to efenniht theme, but it will be some work I'd
not be able to finish in time... given that we'll have enjoy, eve,
envision and ephoto using the same things, it is time to consider a
better replicable solution.
SVN revision: 53240
okay, still yet another partial code, it's far from ready, don't even
checkout until you're ready to code.
preferences, flow_browser, slideshow are temporarily gone.
still no toolbar in main window, layout redone using EXTERNAL... when
it go back, it will be in the same form as eve/enjoy.
SVN revision: 53238
I'm rewriting parts of ephoto to simplify it, one of the things is to
avoid lots of nesting of layouts to get a simple preview
image.
So far just the thumb directory is done to the point it shows the
contents of a directory, it will do nothing on selection and
clicks. There is no toolbar either, as this is going to be replaced
later on.
EFL bugs so far:
* eio_file_cancel() is not playing nice with ecore_pipe, with errors like: "ecore_pipe.c:517 _ecore_pipe_read() An unhandled error (ret: -1 errno: 9)occurred while reading from the pipe the length"
* evas/edje map is broken WRT clipping! if I have map { on: 1;
rotation.z: 10;} and this part is clipped to some other part, the
clipper will be ignored!
Sorry, but I couldn't finish it now, trying to do it later today and
tomorrow. I still need to add the elm_genlist_item_prepend(),
elm_genlist_item_insert_before() and elm_genlist_item_insert_after()
to get the sorted insert to work.
SVN revision: 53237
if source file is a jpeg, then speed up and generate thumbnails in
format "JPEG" that are smaller and faster to load.
also define the aspect to be cropped rather than keep aspect as we're
showing the images in a fixed square. The aspect one would be good if
we did not use a grid, rather a flow layout.
SVN revision: 53218
use super-duper-nice edje features to choose image based on the
current object size and provide icons at 128, 256 and 512 so we're
always high quality.
SVN revision: 53212
If we used such a large border with small item sizes, the content size
would be zero and thus icons did turn invisible. Limit that to 16x16.
"thumbs" in group will say how many thumbnails are desired, instead of
hardcoding it to 3.
countless code simplifications.
SVN revision: 53207
* fix a bit of coding style (damn, it's totally off with SVN coding style!)
* save basename to avoid calculating it over and over again.
* ignore hidden files and folders (those that start with ".")
* rename "top" to "Up" as we just go one level.
* add TODO that requires adding eio_file_ls_direct()... the current
version is not that useful, we really could use dirent, basename
and lengths while filtering.
* add TODO to speed up matches of JPG, PNG, and like... these will
account for most of the files we browse, thus they should be fast
and not rely on efreet (which may not be that good to use from
threads... if it is, then it's more expensive as we need to lock)
SVN revision: 53198
Author: Otavio Pontes <otavio@profusion.mobi>
Date: Mon Sep 27 15:26:55 2010 -0300
Displaying directories in thumb browser
It is possible also to open an directory to see images in it.
SVN revision: 52994
Author: Otavio Pontes <otavio@profusion.mobi>
Date: Mon Sep 27 11:32:34 2010 -0300
Fixing some bugs in image exibition.
Using photocan to show png files in flow browser and using elm_image
instead of elm_bg to display thumbs in thumb_browser. elm_bg was
creating a strange border in images with white(or transparent)
background.
SVN revision: 52902
Date: Thu, 23 Sep 2010 16:39:58 -0300
Subject: [PATCH 4/5] Adding new keyboard shortcuts to ephoto.
To: otavio@profusion.mobi
Also adds:
- zoom in/out function to flow_browser and buttons in toolbar
for zoom and rotation.
- Fullscreen mode to slideshow.
SVN revision: 52899