Coverity reports a resource leak here as we were not freeing
'sanitized_path' inside the if statement.
Fixes CID1367502
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
This extra snaitized path assign path does not make sense and leads to a leak
in the end. We already have sanitized_path and handle that correctly.
Fixes 62a0c41fd3
CID: 1366925
Summary:
Since there is infra to support EXIF orientation in the loaders, we don't need to use libexif explicitely.
(Currently jpeg loader support EXIF orientaion fully.)
@fix
Test Plan: generate thumbnail of "Light_exif_*.jpg" in efl/src/tests/evas/image/ -> check whether the image is rotated properly or not
Reviewers: raster, cedric
CC: seoz, cedric
Differential Revision: https://phab.enlightenment.org/D1142
Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
Summary:
setup related API was not working at all due to below problems
1. dbus type signature is wrong. it's array of dictionary not array of struct
2. since quality value was assigned to compress value, there was a problem during saving png image (out of bound)
3. orientation_set API was not working except NONE and ORIGINAL
@fix
Test Plan: make thumbnail by using elm_thumb_add -> orientation set to 90 CCW -> check whether image is rotated properly or not
Reviewers: raster, cedric
CC: seoz, cedric
Differential Revision: https://phab.enlightenment.org/D1138
Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
this makes efl ignore certain env vars for thnigs and entirely removes
user modules (that no one ever used) etc. etc. to ensure that *IF* an
app is setuid, there isn't a priv escalation path that is easy.
above, so fix. On a mkpath failure, print out the message, Then free
dname. Be sure to also free dname if we do not error.
NB: Fixes Coverity CID1039893
Signed-off-by: Chris Michael <cp.michael@samsung.com>
This one was a painful bitch. The edbus2 port was quite broken, mainly
leaking eina_stringshare and also not adding the '\0' to the strings
that are represented as bytearray (paths cannot be utf8 to avoid
translations).
Emotion plugin was also quite bogus and the video thumbnail as edje
(animated) is not working yet due bug in Edje_Edit api -- someone
needs to investigate this, seems strange.
Emotion plugin also had a bug that it was deleting the object from
inside object callback.
Now it seems to work. Please report if it does not.
SVN revision: 82675
Vincent Torri
Elyes HAOUAS
Hermet Park
Carsten Haitzler
Marcel Hollerbach
Marcel Hollerbach
Gustavo Sverzut Barbieri
Chris Michael
Cedric BAIL
Stefan Schmidt
Andrii Kroitor
Vincent Torri
wonguk.jeong
Cedric BAIL
Cedric Bail
Sebastian Dransfeld
Gustavo Sverzut Barbieri