TESTING

It has been checked in all other places, but has been forgotten in these
two.

CID: 1401081

.travis.yml

@@ -58,39 +58,30 @@ jobs:
     - os: linux
       env: DISTRO=Fedora32 CI_BUILD_TYPE=default
     - os: linux
-      if: type = cron
       env: DISTRO=Fedora32 CI_BUILD_TYPE=release-ready
     - os: linux
-      if: type = cron
       env: DISTRO=Ubuntu2004
     - os: linux
-      if: type = cron
       env: DISTRO=Ubuntu1910
     - os: linux
-      if: type = cron
       env: DISTRO=Debian103
     - os: linux
       if: type = cron
       env: DISTRO=Fedora31 CI_BUILD_TYPE=coverity
     - os: linux
-      if: type = cron
       env: DISTRO=Fedora32 CI_BUILD_TYPE=asan
     - os: linux
-      if: type = cron
       env: DISTRO=Fedora32-exactness CI_BUILD_TYPE=exactness
     - os: linux
       if: type = cron
       env: CI_BUILD_TYPE=codecov
     - os: linux
-      if: type = cron
       arch: arm64
       env: CI_BUILD_TYPE=default
     - os: linux
-      if: type = cron
       arch: ppc64le
       env: CI_BUILD_TYPE=no-bindings
     - os: linux
-      if: type = cron
       arch: s390x
       env: CI_BUILD_TYPE=no-bindings
 
@@ -144,14 +135,3 @@ before_cache:
          mv $HOME/Library/Caches/Homebrew $HOME/cachedir/Homebrew
        fi
 
-notifications:
-  irc:
-    channels:
-      - "chat.freenode.net#edevelop"
-    on_success: change
-    on_failure: always
-    template:
-      - "TravisCI build %{build_number} in branch %{branch}: %{result} - %{message} (%{elapsed_time})"
-      - "Commit: %{commit_subject} (%{commit}) from %{author}"
-      - "Change view : %{compare_url}"
-      - "Build details : %{build_url}"

src/benchmarks/eina/ecore_hash.c

@@ -429,9 +429,12 @@ ecore_hash_dump_stats(Ecore_Hash *hash)
              sum_n += (double)n;
           }
      }
-   variance = (sum_n_2 - ((sum_n * sum_n) / (double)i)) / (double)i;
-           printf("Average length: %f\n\tvariance^2: %f", (sum_n / (double)i),
-          variance);
+   if (i)
+     {
+        variance = (sum_n_2 - ((sum_n * sum_n) / (double)i)) / (double)i;
+        printf("Average length: %f\n\tvariance^2: %f", (sum_n / (double)i),
+               variance);
+     }
 }
 
 static int

src/tests/eina/eina_test_file.c

@@ -814,7 +814,7 @@ EFL_START_TEST(eina_test_file_mktemp)
 
    fd = eina_file_mkstemp(buf, &tmpfile);
    fail_if((fd < 0) || !tmpfile || errno);
-   close(fd);
+   fail_if(close(fd));
 
    it = eina_file_direct_ls(tmpdir);
    fail_if(!it);
@@ -825,8 +825,8 @@ EFL_START_TEST(eina_test_file_mktemp)
 
    eina_iterator_free(it);
 
-   unlink(tmpfile);
-   remove(tmpdir);
+   fail_if(unlink(tmpfile));
+   fail_if(remove(tmpdir));
 }
 EFL_END_TEST
 

src/tests/eina/eina_test_matrixsparse.c

@@ -145,9 +145,11 @@ EFL_START_TEST(eina_test_simple)
    fail_if(row != 3 || col != 5);
 
    test1 = eina_matrixsparse_data_idx_get(matrix, 4, 3);
+   fail_if(test1 == NULL);
    fail_if(*test1 != data[4][3]);
 
    test1 = eina_matrixsparse_data_idx_get(matrix, 1, 3);
+   fail_if(test1 == NULL);
    fail_if(*test1 != data[1][3]);
 
    /* data changing */

src/tests/eina/eina_test_module.c

@@ -32,14 +32,14 @@ static Eina_Bool list_cb(Eina_Module *m, void *data EINA_UNUSED)
    const char *file;
 
    /* the reference count */
-   eina_module_load(m);
+   fail_if(!eina_module_load(m));
    /* get */
    sym = eina_module_symbol_get(m, "dummy_symbol");
    fail_if(!sym);
    fail_if(*sym != 0xbad);
    file = eina_module_file_get(m);
    fail_if(!file);
-   eina_module_unload(m);
+   fail_if(eina_module_unload(m));
 
    return EINA_TRUE;
 }

src/tests/eo/suite/eo_test_class_simple.c

@@ -27,12 +27,19 @@ static Eina_Error
 _a_set_reflect(Eo *obj, Eina_Value value)
 {
    int a;
+   Eina_Error r = 0;
 
-   eina_value_int_convert(&value, &a);
+   if (!eina_value_int_convert(&value, &a))
+      {
+        r = EINA_ERROR_VALUE_FAILED;
+        goto end;
+      }
    simple_a_set(obj, a);
+
+end:
    eina_value_flush(&value);
 
-   return 0;
+   return r;
 }
 
 static int

src/tests/evas/evas_test_image.c

@@ -904,7 +904,8 @@ EFL_START_TEST(evas_object_image_map_unmap)
 
    // save file, verify its pixels
    fd = eina_file_mkstemp("/tmp/evas-test.XXXXXX.png", &tmp);
-   close(fd);
+   fail_if(fd <= 0);
+   fail_if(close(fd));
    if (efl_file_save(o, tmp, NULL, NULL))
      {
         Eina_Rw_Slice sorig, sdest;