From 4cb05b41201b7fd805a3d009252afd77344ef720 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Fri, 25 Aug 2017 14:47:04 -0400 Subject: [PATCH] use clone of remembers list in window remember config this modifies the remember list and guarantees a crash if sorting occurs --- src/modules/conf_window_remembers/e_int_config_remembers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/modules/conf_window_remembers/e_int_config_remembers.c b/src/modules/conf_window_remembers/e_int_config_remembers.c index c50bbbe42..4774fc7c1 100644 --- a/src/modules/conf_window_remembers/e_int_config_remembers.c +++ b/src/modules/conf_window_remembers/e_int_config_remembers.c @@ -207,7 +207,7 @@ _fill_remembers(E_Config_Dialog_Data *cfdata) e_widget_ilist_freeze(cfdata->list); e_widget_ilist_clear(cfdata->list); - ll = e_config->remembers; + ll = eina_list_clone(e_config->remembers); ll = eina_list_sort(ll, -1, _cb_sort); ic = e_icon_add(evas); @@ -280,6 +280,7 @@ _fill_remembers(E_Config_Dialog_Data *cfdata) e_widget_ilist_thaw(cfdata->list); edje_thaw(); evas_event_thaw(evas); + eina_list_free(ll); e_widget_disabled_set(cfdata->btn, 1); }