In order to move composite inside the core we need to kill the
use_composite option. However in some places it is being used to switch
between ARGB and shaped windows. It doesn't make much sense to keep the
advanced/engine dialog to let the user toggle this options if we have
composite always enabledm, but lets allow the user to shoot
himself on the foot (for now).
Next step will be to move the comp module files to core so user can't
unload it anymore.
SVN revision: 82433
here is a patch.
1. free() already null-checks the passed argument, so it is not
necessary to do 'if(x) free(x)'.
2. Moved some '{free(x); x = NULL}' to E_FREE.
3. In e_start_main.c, 'buf' is allocated with the size of the
two arguments + '=', so we don't need to check for lenght;
we should use sprintf().
thanks
Maxime Villard
SVN revision: 81364
Subject: Re: Re: Re: [E-devel] [RFC] Virtual desktop window profile
I've attached 4th patch. May the 4th be with you.
ecore patch has been merged with efl and all files are based on r80123.
Thanks & Regards,
Gwanglim
------- Original Message -------
Sender : Daniel Juyung Seo<seojuyung2@gmail.com>
Date : 2012-12-04 01:55 (GMT+09:00)
Title : Re: Re: [E-devel] [RFC] Virtual desktop window profile
It looks ok to me.
Sorry but can you re-generate the patch according to the recent ecore
merge to efl single tree?
Daniel Juyung Seo (SeoZ)
On Thu, Nov 29, 2012 at 12:29 AM, Gwanglim Lee <gl77.lee@samsung.com>
wrote:
Dear Raster and Daniel Juyung Seo,
I've attached 3rd patches and test_config according to your reviews.
These are based on r79782.
[elementary & ecore]
1. "profile,set" -> "profile,changed" - done
2. spaces after EINA_LIST_FOREACH - done
3. variable type - keep
4. author - done
5. removing deprecated marking in patch - done
6. add elm_win_available_profiles_get to test_config for the debugging
purpose - done
7. check whether a given profile is present in an available profiles.
otherwise window profile will be one of the item
in available profiles. - newly added thing to the elm_win
8. merge with EO - done. :(
Any comments would be appreciated.
SVN revision: 80216
This fixes trapping of events on modal parents. We can't change event
mask, as that changes the event _we_ receive, not the client. We must
add and input window above the parent which traps the events.
SVN revision: 79367
Dear all.
I found that there is code to occur memory leak in e_border.c and I fixed it.
Please review this patch.
Thanks.
Doyoun Kang
Singed-Off-By:Doyoun Kang<doyoun.kang@samsung.com>
SVN revision: 78910
zone). Use e_util_zone_current_get.
Add missing parens around eina_list_data_get.
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 77938
The idea of not deleting the borders of unmapped windows started with
r12777 to fix problems when changing virtual desktops. A lot of stuff
was added later to fix this problem, but this original fix has lived on.
When hunting down a mplayer bug raster commented in r14744:
"we need to re-enable the above. when clients hide windows they often
dont destory - keep around to do somethign else with. if we dont unmanage
then we have all sorts of problems believeing it still exists. bigger
problems than mplayer. :)"
So I guess the right thing to do is to destroy the borders of hidden
windows, fixes#917
SVN revision: 77363
Lucas De Marchi
Mike Blumenkrantz
Boris Faure
Carsten Haitzler
Gwanglim Lee
Sebastian Dransfeld
ChunEon Park
Cedric BAIL
Christopher Michael
Christopher Michael