Commit Graph

333 Commits

Author SHA1 Message Date
Elyes HAOUAS 153f479d3f tree-wide: fix typos all over the place
Fix some typos

Differential Revision: https://phab.enlightenment.org/D11778
2020-05-14 12:04:51 +02:00
Carsten Haitzler ac4323b453 fileman module - fix warning about constness of ptrs
noisy warning so we can see real bugs. no real bug fixed here.
2020-01-15 11:33:55 +00:00
Carsten Haitzler dda50e8d87 shot + efm - add efm action to show dir so if same dir is open it shows
and if there is not the same dir upa  new win is created and shown.
... shot uses this to avoid shot dir duplication.
2020-01-09 00:26:45 +00:00
Carsten Haitzler b7d8916701 efm: ensure progress popup is visible with min calc and hint set
we never calc'd min size and set min size hint - fix that and set it...
@fix
2019-08-15 09:55:12 +01:00
Carsten Haitzler e912e0a087 efm - fix always new window mode to put dir inline from favorites select
when u select something from the favorites on the left it should
always affect the content of the current window, not open a new one -
this would happen if u switch mode to open new windows from the default.

this fixes that.
2019-05-08 15:09:27 +01:00
Carsten Haitzler d8e92184b8 fix casts to use void ptr to avoid warning that isnt important
the callback uses a subset of the arguments (taking advantage that our
first arg is void * data) so it can re-use across callback types. void
* makes this case not complain as oposed to casint to a specific fn
sig type from another.
2019-01-12 01:51:43 +00:00
Carsten Haitzler 21dd3b1aba efm - reorder destroy to toolbar can access fm obj still on free
less ERRs
2019-01-09 18:39:16 +00:00
Carsten Haitzler e493891151 fileman - don't add cbs to a fwin window that doesnt exist
less ERR noise.
2019-01-09 18:23:19 +00:00
Carsten Haitzler a1994536a4 move from data_home/apps/defaults.list to config_home/mimeapps.list
this moves to the newer mimeapps.list file in ~/.config from the older
defaults.list. it also provides a migration (copy file ovr if target
doesnt exist on e startup).

this fixes T6784

@fix
2018-03-20 20:36:56 +09:00
Mike Blumenkrantz 99db9e2557 more E_BITFIELD conversions 2017-11-08 09:22:24 -05:00
Mike Blumenkrantz 0bd73b5a54 use client geometry for fileman popup positioning instead of win object geometry
window objects don't return accurate geometry under wayland

fix T3842
2017-08-25 14:47:10 -04:00
Mike Blumenkrantz 7a3876ffc9 add and use new event for zone useful geometry changing
many times it's useful to have an event for actual zone geometry change
vs useful geomtry change, so split this out and use the right handler where appropriate
2017-08-04 16:05:15 -04:00
Derek Foreman 4cf555f36e Replace all timer_reset with timer_loop_reset
Another sed bomb - didn't occur to me first time around to
check for this.  Cleans up more clock_gettime calls.
2017-02-06 15:59:25 -06:00
Derek Foreman 73aecd73ab Replace all timer_add with timer_loop_add
So yeah, I've literally used sed to replace every occurrence of
ecore_time_add() with ecore_timer_loop_add() because I'm reasonably
confident that no part of E has a legitimate need for timer based on the
exact current time.

It would be really nice if I'm not wrong. :)

The reason for this is the incredible spew of clock_gettime() calls I'm
seeing on an ARM system (that should have a vdso for gettime, but...)
This can amount to thousands of system calls per second.

 #YOLO
2017-02-03 15:52:28 -06:00
Al Poole bfe02d2303 efm - fix popup if file is a fifo
this fixes T4815

@fix
2016-11-02 11:00:40 +09:00
Carsten Haitzler fd8d41a2a6 e fm - fix popup to not crash by referring to possibly deleted data
fm icon info is transient because fm icons are transient. files may
get deleted, added or removed on the fly. keeping icon info around for
things like the popup is asking for tyrouble and does create  trouble.

so look it up each time based on filename string. safe!

this fixes T4716 and fixes T4798 (they are the same bug basically).
2016-10-31 18:23:08 +09:00
Al Poole 382fe30688 fwin: prevent segv when the vaarg abi messup with unused parameter.
Quite a hack overall, but if you don't need those parameter, just put
nothing and it will work.

@fix T4112

Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
2016-07-15 09:17:44 -07:00
Mike Blumenkrantz 768252740b don't revert focus to desktop fileman during compositor grab
grabs indicate an action is already occurring and focus shouldn't be altered
2016-05-03 20:27:03 -04:00
Mike Blumenkrantz 6d45baa510 do not shortcut access of Efreet_Desktop->x hash in fileman
this subverts thread safety and also (now) avoids return data validation

fix T3096
2016-01-25 11:29:55 -05:00
Mike Blumenkrantz d659b86478 remove fwin popup size hint change callback on win deletion
this callback also crashes if called during delete
2015-11-20 09:16:21 -05:00
Mike Blumenkrantz b2706afe06 ensure fwin efm delete callback does not trigger crash
if this is called during fwin delete, dereferencing the passed data
will result in a crash
2015-11-20 09:09:38 -05:00
Mike Blumenkrantz d2a9596753 use evas object callbacks for fwin mouse in/out, don't use ecore-x handlers in wayland
improve compatibility with wayland compositors
2015-07-06 14:23:54 -04:00
Mike Blumenkrantz 038df92cdd only apply fwin focus to main efm object if no icon is editing 2015-04-30 16:06:09 -04:00
Mike Blumenkrantz 5db35cd85a add focus callback to override elm_win being stupid
plz elm_win, you can't focus yourself. you aren't a real widget.
2015-04-27 16:03:42 -04:00
Mike Blumenkrantz 5ae00e6525 redo drop handlers to take an E_Object and Evas_Object
temp change to fix crashing when closing fwins with ctrl+w
2015-04-27 15:39:43 -04:00
Mike Blumenkrantz 471dcb24cb __UNUSED__ -> EINA_UNUSED
this has been bugging me forever. __UNUSED__ is no longer a valid macro here.
2015-03-18 18:09:09 -04:00
Mike Blumenkrantz f9fc4b13de remove E_Comp usage from fileman/fwin 2015-03-18 17:40:04 -04:00
Mike Blumenkrantz 09ec213a31 remove e_util_zone_current_get() usage 2015-03-13 17:58:45 -04:00
Mike Blumenkrantz ba7c1ac49c remove E_Zone->comp member 2015-03-13 17:44:24 -04:00
Mike Blumenkrantz b63e490a33 remove e_util_comp_current_get() usage 2015-03-13 16:28:08 -04:00
Mike Blumenkrantz 107ab84a19 Revert "disable fileman popups in wl-only mode"
This reverts commit e6c47e8d90.

these no longer crash so reenable them
2015-03-06 16:06:17 -05:00
Mike Blumenkrantz e6c47e8d90 disable fileman popups in wl-only mode
these crash for now and I'm annoyed
2015-02-27 14:45:45 -05:00
Chris Michael 96b3a04192 enlightenment: Don't crash if fwin app dialog has no exec_cmd
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2015-02-08 11:53:45 -05:00
Mike Blumenkrantz ffd51904e2 ignore size hint changes for fileman popups if popup icon has been moused out 2015-01-14 20:43:32 -05:00
Mike Blumenkrantz 3afc36bbe4 de-e_comp_get()ify e_fwin 2015-01-13 22:44:55 -05:00
Mike Blumenkrantz e30dd076e9 redo fileman tooltips to size correctly
exhibits edje min size calc bug/workaround
2015-01-13 22:44:55 -05:00
Mike Blumenkrantz c978a045e6 e_entry -> elm_entry conversion
another dice roll in the board game of enlightenment development. next, I will attempt to roll doubles to get out of jail.

 #teamborker

fix T1906
2015-01-11 12:20:46 -05:00
Mike Blumenkrantz 922af2c52f remove e_comp_list(), deprecate all related functions for pending removal
there is only one E_Comp which can now be accessed by the e_comp global.

if you're editing a file with some uses of these deprecated functions, replace their usages with appropriate references to this variable

pass -Wno-deprecated-declarations to ignore these warnings during build
2015-01-05 15:39:15 -05:00
Carsten Haitzler 6510e8bd0e Revert "all dialogs are now resizable"
This reverts commit 9157ca8ca7.

this also makes all dialogs that have content in a toolbar that goes
off window at min size resizable - this is actually what you wanted ..
bgut this previous "all dialogs are resizable" thing was uber-lazy.

Conflicts:
	src/modules/bluez4/e_mod_main.c
	src/modules/conf_bindings/e_int_config_signalbindings.c
	src/modules/conf_theme/e_int_config_theme.c
	src/modules/mixer/conf_gadget.c
	src/modules/shot/e_mod_main.c
2014-12-22 23:02:05 +09:00
Carsten Haitzler 87baecb098 Revert "windows - allow close button to work again in internal wins"
This reverts commit 285951c8cb.
2014-11-23 13:54:14 +09:00
Carsten Haitzler 285951c8cb windows - allow close button to work again in internal wins
since the move to elm_win ... windows don't close with close button in
the titlebar. this fixes that in the simplest way - enabling autodel
on the window.
2014-11-22 18:46:10 +09:00
Mike Blumenkrantz 18c1e3620d fix fileman crash when restarting with window open 2014-11-20 15:26:22 -05:00
Mike Blumenkrantz 99589eb5af remove E_Win+e_canvas, convert all internal wins to use elm_win
known issues:

* keybindings for efm windows (eg. ctrl+w) are broken until the rest of the conversion is completed
2014-11-20 15:26:21 -05:00
Chris Michael c8dd1d95d3 modules/fileman: Fix Dereference before null check
Fixes CID1039814

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 10:57:21 -04:00
Mike Blumenkrantz b944738d83 bugfix: don't save mime info when opening .desktop files
fix T1421
2014-07-16 10:48:48 -04:00
Mike Blumenkrantz 526bdab7c4 unset fwin win delete callback before delete during delete callback 2014-06-25 16:05:26 -04:00
Cedric BAIL 3f9af38da2 edje: remove use of deprecated functions. 2014-06-07 21:10:55 +02:00
Mike Blumenkrantz 9157ca8ca7 all dialogs are now resizable
any bug reports regarding issues resulting this will be ignored.
2014-05-14 13:00:35 -04:00
Chidambar Zinnoury 4db7e467c7 e fileman: Remove unused parameter.
Thanks Mike!
2014-05-09 16:49:43 +02:00
Mike Blumenkrantz 9e3dedb23f hide fileman popups on window close
fix T1221
2014-05-07 17:46:24 -04:00