Commit Graph

12561 Commits

Author SHA1 Message Date
Christopher Michael 194f1c77b5 e_system_main: Fix resource leak
Coverity reports a leak here because we are not closing the previously
opened file. Fix that.

fixes CID1427985
2020-04-28 11:31:24 -04:00
Carsten Haitzler 8157253032 e - rememebr - fix resolution change re-shuffle for remembers
this kind of broke along the way. re-fix it to work again.

@fix
2020-04-25 00:16:45 +01:00
Carsten Haitzler 3d413eea68 fix menus to jump content onto screen better without side-effects
fixes T8680

@fix
2020-04-24 18:58:45 +01:00
Carsten Haitzler ffa60c9345 e bg - make anim gifs work again 2020-04-24 12:25:09 +01:00
Carsten Haitzler 5852c17c2e e bg - fix blurred non-edj wallpapers 2020-04-24 12:21:18 +01:00
Carsten Haitzler 7227173169 e comp x - debug and correct mask handling for configure requests 2020-04-23 17:00:21 +01:00
Carsten Haitzler 91c003100e e system - allow the per system permit/deny rules to work 2020-04-23 13:43:45 +01:00
Carsten Haitzler 3d490704ca e system - check chdir return
chdir to / will never fail... it's the root dir.. but let's make
coverity happy.

fix CID 1425454
2020-04-23 01:05:00 +01:00
Carsten Haitzler 273ec41687 e actions - handle params not being provided by user bindings
fix CID 1425456
2020-04-23 01:00:10 +01:00
Carsten Haitzler 089051af9e e system main - check getgrid return like elsewhere to maake cov happy
fix CID 1425457
2020-04-23 00:54:35 +01:00
Carsten Haitzler 21ec506dfd randr - provide dialog telling the user they have no screens
this shouldn't be a state to find yourself in... so let the user know
they are in that broken state with a dialog.
2020-04-22 21:01:38 +01:00
Carsten Haitzler 2b452e5db1 e - avoid segv's when zero screens are configured
at least backlight won't be applied now...
2020-04-22 20:46:59 +01:00
Carsten Haitzler d8130a741c e sys storage - disable it effectively by failing all devices
all devices will fail the check for now as i have no filter to only
check for block + removable devices etc.

fixes T8672
2020-04-22 14:53:25 +01:00
Carsten Haitzler 800ff4e24f e sys store - unmount verify its root and right username
also check for relative paths, shell metachars etc.

fixes T8671
2020-04-22 14:40:59 +01:00
Carsten Haitzler dfed5c2718 e sys storage - also address media dirs to have to be user named
only allow media dirs to be /media/username/xxx ...

fixes T8672
2020-04-22 14:27:21 +01:00
Carsten Haitzler 0c79c6317b e sys store - make it all root owned for meda mount dirs
fixes T8670
2020-04-22 14:11:00 +01:00
Carsten Haitzler 027095b68e e system - use ERR - its not the eina log - it's already a custom one
i already made ERR do fprintf to stderr... so use it :)
2020-04-22 13:44:01 +01:00
Carsten Haitzler fc6c423a9f e system main - fix system.conf parsing to parse all of it
forgot my for loop.. :)

fixes T8675
2020-04-22 13:42:32 +01:00
Carsten Haitzler 2e75a9410e e sys man - double check root homedir to be paranoid 2020-04-22 13:15:08 +01:00
Carsten Haitzler ac37da4167 e sys inout - abort on messages more than 1m in size
i never see a need for messages more than 1m in size so lets just
abort on them to limit abuse

fixes T8677
2020-04-22 13:00:55 +01:00
Carsten Haitzler 5fb2fccd70 e sys main - double check return from getpwent homedir 2020-04-22 12:37:51 +01:00
Carsten Haitzler d42605f5c0 e sys main - change cwd to avoid loading .so's in ./
fixes T8676
2020-04-22 12:35:32 +01:00
Carsten Haitzler fc26d91ac0 e sys l2ping - handle null params
fixes T8674
2020-04-22 12:25:36 +01:00
Carsten Haitzler 6926d1d338 e sys l2ping - limit devv string scanf size to buffer size
fixes T8673
2020-04-22 12:20:54 +01:00
Alastair Poole d0b2f3db0c e_system: When setuid, set home also.
This ensures we have a matching $HOME when using setuid, without
which can potentially cause issues in eina_vpath on some
systems (FreeBSD as example).
2020-04-21 15:56:26 +01:00
Carsten Haitzler bd97c74492 e alert - in case of crash use e system in new alert mode
this forces all ddc/backlight devices to max when discovered so you
can always see the alert.
2020-04-21 03:01:54 +01:00
Carsten Haitzler 5d6424e3bc backlight - if bl devices not there yet for a zone then fix them later
if bl devices added later - sync them up to the desired backlight leave
when that happens and ensure we store the desired level...l
2020-04-21 01:35:57 +01:00
Christopher Michael 77f8008334 e_pixmap: Missed one on that variable change 2020-04-20 18:55:51 -04:00
Christopher Michael e365138a2b e_pixmap: No need for this variable here
We only ever used this var Once in this func...
2020-04-20 18:52:08 -04:00
Christopher Michael 7c678e5762 e_pixmap: Final formatting
This code is now readable in a terminal...yay !! :)
2020-04-20 18:51:57 -04:00
Christopher Michael acf622b31b e_comp_wl: Remove EINA_UNUSED from used parameter
'client' is potentially used here if we have an error
2020-04-20 11:58:36 -04:00
Christopher Michael b7ecc19c61 e_comp_object: Minor formatting fix 2020-04-20 11:58:36 -04:00
Carsten Haitzler fee794af29 comp - handle possible case where we're grabbed - ungrab first 2020-04-19 23:52:34 +01:00
Carsten Haitzler 1d7adf0626 comp - blackwin - only use compositor size and not 32k x 32k 2020-04-19 23:38:04 +01:00
Carsten Haitzler e66af58795 e - restarts - if theme supports make it totally seamless
if theme doesn't support, fade-in will not happen (it'll just appear),
but if it does... e will fade to black for a restart, then fade back
in nice and cleanly.
2020-04-19 23:14:35 +01:00
Carsten Haitzler 24524001c4 e - restart - fix restoring of visible virtual desktop
e now (in x mode) will restore virtual desktop. not in wl at this
stage as i think i need to work on a proper serialised sate file...
2020-04-19 20:17:19 +01:00
Carsten Haitzler 4ff2b3e4c7 e main - remove unused env vbar stuff since we dont exec ourselves 2020-04-19 19:10:50 +01:00
Carsten Haitzler 97d98c9beb desklock - remove commented out getenv for locked state 2020-04-19 19:02:30 +01:00
Carsten Haitzler 6d8b24aef5 e - profile send to efl wins - fall back to getting ellm profile
use elm profile THEN .. if that fails use standard.
2020-04-19 13:44:32 +01:00
Carsten Haitzler b88b7bd1c4 e profile send - add debug to let you know what profile e is sending app 2020-04-19 12:36:59 +01:00
Carsten Haitzler 2ccfec3dad e ckpasswd - handle read errors on stdin
error path - not going to be a problem but in theory... it's there.

fix CID 1425211
2020-04-19 01:58:44 +01:00
Carsten Haitzler 23493550b2 wp gen - remove unused var assignments
these ren't used, so

fix CID 1425228 1425225
2020-04-19 01:48:28 +01:00
Carsten Haitzler d5d53a0e96 wl - handle logicaly dead code by doing the most logical thing
it would seem it wants to send it being allowed if it has handled the
case, so get rid of logically dead coe and make it not dead...

fix CID 1403932
2020-04-19 01:45:10 +01:00
Carsten Haitzler 3d6597d3ec comp wl - add comment to indicate args are in the right orer...
clarify CID 1403953
2020-04-19 01:33:06 +01:00
Carsten Haitzler f4c49a071f e auth - also use wrapped memory zeroing in polkit and normal auth
fix CID 1425207
2020-04-19 01:17:39 +01:00
Carsten Haitzler 8f019a4ef7 comp wl - fix sync with dmabuf code to not have early return
coverity pointed out dead code - code wss actually wrong. it'd have
skippedlinear on older proto

fix CID 1425218
2020-04-19 00:57:43 +01:00
Carsten Haitzler 3b15f1bb8f e win - fix dead code
fi CID 1425219
2020-04-19 00:50:11 +01:00
Carsten Haitzler f1e899fee0 e system ddc - handle error case of alloc fail and dont deref null
fix CID 1425220
2020-04-19 00:48:07 +01:00
Carsten Haitzler 8931a333eb e system - handle /dev/null not opening
fix CID 1425222
2020-04-19 00:39:51 +01:00
Carsten Haitzler f9454fcb65 e win - remove logically dead code
fix CID 1425227
2020-04-19 00:32:51 +01:00