Commit Graph

20546 Commits

Author SHA1 Message Date
Carsten Haitzler 3d6597d3ec comp wl - add comment to indicate args are in the right orer...
clarify CID 1403953
2020-04-19 01:33:06 +01:00
Carsten Haitzler 01a145811f shot upload - fix close of fd -1 - harmless but wrong
fix CID 1425205
2020-04-19 01:24:46 +01:00
Carsten Haitzler f4c49a071f e auth - also use wrapped memory zeroing in polkit and normal auth
fix CID 1425207
2020-04-19 01:17:39 +01:00
Carsten Haitzler 569146ed6a shot - handle error path and don't double close fd
fix CID 1425213
2020-04-19 01:10:55 +01:00
Carsten Haitzler 8f019a4ef7 comp wl - fix sync with dmabuf code to not have early return
coverity pointed out dead code - code wss actually wrong. it'd have
skippedlinear on older proto

fix CID 1425218
2020-04-19 00:57:43 +01:00
Carsten Haitzler 3b15f1bb8f e win - fix dead code
fi CID 1425219
2020-04-19 00:50:11 +01:00
Carsten Haitzler f1e899fee0 e system ddc - handle error case of alloc fail and dont deref null
fix CID 1425220
2020-04-19 00:48:07 +01:00
Carsten Haitzler 7d5f64430b shot upload - handle invalid args even though they never will be
since the caller is e's shot module, they will be sane, but coverity
in theory is right.

fix CID 1425221
2020-04-19 00:44:48 +01:00
Carsten Haitzler 8931a333eb e system - handle /dev/null not opening
fix CID 1425222
2020-04-19 00:39:51 +01:00
Carsten Haitzler f9454fcb65 e win - remove logically dead code
fix CID 1425227
2020-04-19 00:32:51 +01:00
Carsten Haitzler 948d064561 fileman - handle rare path where dev may not be found
fix CID 1425230 1425226
2020-04-19 00:32:38 +01:00
Carsten Haitzler 65f9b94d2b wp import dialog - fix string leak in error case
fix CID 1425206
2020-04-19 00:11:56 +01:00
Carsten Haitzler 4749e1e065 backlight - fix string ptr leak
fix CID 1425215
2020-04-19 00:06:08 +01:00
Carsten Haitzler 1617659255 polkit - fix error case leak
error path leak found by coverity

fix CID 1425216
2020-04-19 00:02:21 +01:00
Carsten Haitzler a6a10d405d e wp gen tool -fix theoretical leak on tool exit
theoretical leak - but not really as porcess exits anyway

fix CID 1425217
2020-04-18 23:31:11 +01:00
Carsten Haitzler 5ac19b1372 shot - fix leak of img data in error path
fix CID 1425223
2020-04-18 23:27:39 +01:00
Carsten Haitzler 5e0bb63118 e system storage - fix double free found by coverity
fix CID 1425224
2020-04-18 23:19:54 +01:00
maxerba cac4c69f74 Fixed error message's lines stick each other 2020-04-18 09:54:14 +02:00
Christopher Michael d37ffa3599 e_comp_wl_dmabuf: Fix another formatting snafu
NB: No functional changes
2020-04-17 16:21:50 -04:00
Alastair Poole 909cb2be30 e_shelf: Improve auto hide behaviour.
Improve auto hide behaviour. Allow the user to re-enter an
auto-hiding shelf as many times as he/she likes. This fixes the
issue where hovering back onto such a configured shelf causes
the shelf to hide and then animate.

This needs to move to edje. As per the TODO task.
2020-04-17 21:18:41 +01:00
Christopher Michael 2e14660bec e_comp_wl_dmabuf: Fix minor snafu from formatting patch 2020-04-17 16:15:14 -04:00
Christopher Michael dc013b8626 e_comp_wl_dmabuf: Format this file properly
NB: No functional changes (yet), just formatting to make this code
remotely readable.
2020-04-17 16:12:55 -04:00
Carsten Haitzler bc28793796 efm - fix eio usage to notuse efl apis in a thread
the heavy func is in a theread and thus needs to only stick to things
that will be thread safe...
2020-04-17 20:36:22 +01:00
Carsten Haitzler 6ca000a257 only define beta api defines if not defined in e.h 2020-04-17 20:20:50 +01:00
Carsten Haitzler bcd612e78d revert last focus fixes - they both end up worse than before.
Revert "fix spurious pointer jumps due to previous commit bugfix"
This reverts commit 550de9a680.
Revert "focus - fix emacs buffer switch focus set reported by felipe"
This reverts commit 690ab94c06.
2020-04-17 19:02:23 +01:00
Carsten Haitzler 550de9a680 fix spurious pointer jumps due to previous commit bugfix
690ab94c06 fixed one bug and added
another - this fixes the other spurious pointer warps.
2020-04-17 18:50:13 +01:00
Alastair Poole 876f509be4 sysinfo: Don't use fallback when not implemented.
There is no fallback mechanism for BSD systems. We need to avoid
polling here as it will break E on first poll of data.

Essentially, if we fail to find a battery, we use a broken
fallback mechanism which breaks E. Don't do this :)
2020-04-17 15:25:37 +01:00
Carsten Haitzler 3b705cbdd9 wizard - on request disable autoraise on pointer focus 2020-04-16 13:13:25 +01:00
Carsten Haitzler e07e56036a e - stop trying to fixup xdg runtime dir env var - leave it as is
so it's consistently broken .. or not. os/distro should just set this
for login sessions.
2020-04-16 13:09:04 +01:00
Carsten Haitzler be8286e154 emixer - limit icon sizes in toolbar to be... nicer 2020-04-16 10:32:18 +01:00
Carsten Haitzler 690ab94c06 focus - fix emacs buffer switch focus set reported by felipe
emacs window (not in terminal). now in one:
ctrl+x 5 2 <- open new buffer

now we have it try switch to the other buffer:
ctrl+x 5 o

broken ... now fixed.

@fix
2020-04-15 18:04:49 +01:00
Carsten Haitzler 1edddcda66 e system rfkill - use list command for old rfkill output
some distros use an ancient rfkill without default listing of devices.
this adapts to work there.

@fix
2020-04-15 15:31:14 +01:00
Simon Tischer 4acee9e448 batman - fix one more slider issue using mouse wheel
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11710
2020-04-15 08:51:14 -04:00
Simon Tischer 118467697b shot - make it full translateable
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11708
2020-04-15 06:53:23 -04:00
Carsten Haitzler c0ee372ba1 e dnd - add timeout in case we don't get a finished from the other end
2 second timeout seems reasonable. could be less... but should avoid
hangs.
2020-04-14 19:30:02 +01:00
Carsten Haitzler f66ef70770 use SIL/OFL fonts for shot and be clear on the topaz font GPL-FE 2020-04-14 13:51:50 +01:00
Simon Tischer 06b7b9205a (e)mixer - add possibility to translate strings
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11702
2020-04-14 08:17:49 -04:00
Carsten Haitzler a59d3c2a68 typo-- 2020-04-13 21:07:33 +01:00
Christopher Michael 4e626b8f04 bluez: Fix typo spotted by jf_simon 2020-04-13 14:48:08 -04:00
Simon Tischer ab257692f6 wallpaper selector - fix preview of personl wallpapers
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11694
2020-04-13 12:59:40 -04:00
Alastair Poole f7654e7681 e_entry_dialog: Fix entry sizing.
Fixes "Add shelf" and "Rename shelf"...
2020-04-13 14:06:09 +01:00
maxerba 76384d7ace Fixed chinese locale definition from "Traditional Chinese" to "Simplified Chinese" as reported from 玉堂白鹤 2020-04-13 14:17:12 +02:00
Simon Tischer 5853fca2d4 netstatus/batman/pager - slider stepping fixes with mousewheel
detail work on pager(gadget) settings

- changed indicator format to slider format
- changed steps to make more sence

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11693
2020-04-13 08:09:55 -04:00
Carsten Haitzler 2f52f093b6 simplify stacking rules to be a bit dumber so stacking works better
fixes T8652
2020-04-12 16:52:40 +01:00
Alastair Poole 2f27fe1430 conf_theme: fix small logic issue.
Obtain evas before using it.
2020-04-12 14:22:46 +01:00
Carsten Haitzler 42100a1ae7 e - fix fullscreen state revert on focusing of another window if child
check the newly focused window is not part of a parent tree back to a
fullscreen window e is considering unfullscreening on loss of focus.

fixes T8651

@fix
2020-04-11 23:11:33 +01:00
Simon Tischer 136b30d354 temperature module settings - sizing/align optimizations
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11685
2020-04-11 15:23:27 -04:00
Simon Tischer 71a67823c9 shelf settings - sizing/align optimizations
make the dialog resizeable
the position tab is not the beste

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11683
2020-04-11 13:05:59 -04:00
Simon Tischer 23a6a67290 various settings dialogs: sizing/align optimizations
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11682
2020-04-11 11:35:32 -04:00
Simon Tischer 6c1a623e01 settings -> window: settings window align optimizations
settings ->  file manager window align optimizations

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11681
2020-04-11 10:45:12 -04:00
Simon Tischer 37ae415385 sysinfo/thermal - fix slider stepping with mouse wheel
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11680
2020-04-11 09:14:01 -04:00
Christopher Michael 30395f481d conf_theme: Reduce calls to e_win_evas_win_get
There is no point in calling this function multiple times here when we
can call it once, store the result, and reuse that.
2020-04-10 15:15:15 -04:00
Christopher Michael 63e73d9f47 conf_theme: Reduce calls to e_win_evas_win_get
There is no point in calling this function multiple times here when we
can call it once, store the result, and reuse that.
2020-04-10 15:12:41 -04:00
Simon Tischer c1d096bec4 theme selector - remove duplicate code
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11677
2020-04-10 07:19:34 -04:00
Simon Tischer 39384e26c3 theme selector - small optimizations
theme selector - small optimizations

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11674
Differential Revision: https://phab.enlightenment.org/D11675
2020-04-10 07:00:02 -04:00
Simon Tischer cf566306c6 wallpaper selector - small optimizations
wallpaper selector - small optimizations

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11673
2020-04-10 06:58:19 -04:00
Alastair Poole d5790f65fb sysinfo: Fix swap for FreeBSD and DragonFlyBSD. 2020-04-09 16:59:06 +01:00
Riccardo Calixte 61b19484bf Updating Pithos due to MPRIS rename
Sorting music players alphabetically

Pithos 1.5.0 renames the MPRIS app-id, this is the update.
Also, sorting the list of music players alphabetically.

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D10349
2020-04-09 08:00:49 -04:00
Simon Tischer 4a7ebe86bc emixer - add icons to toolbar
Differential Revision: https://phab.enlightenment.org/D11658
2020-04-08 12:30:02 -04:00
Carsten Haitzler b5a6635137 gad bar - make right menu items more obvious and simple 2020-04-08 10:55:31 +01:00
Carsten Haitzler b5fa86e7f5 e system - disable singleton mode code - fewer pluses than minuses 2020-04-08 09:39:23 +01:00
Carsten Haitzler ccbbe5a459 wayland xdg positioner - fix to handle resize constraints
this fixes T8295

@fix
2020-04-07 10:40:12 +01:00
Simon Tischer 039f96df91 emixer - add icon for playback device
Summary:
add playback icons

emixer - add playback icons

Reviewers: devilhorns, raster

Subscribers: raster, bu5hm4n, cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D11640
2020-04-06 14:27:44 +01:00
Alastair Poole 48f9529fbd filepreview: Fix aspect ratio of audio preview.
Artwork from an icon. Previously the image was squashed.
2020-04-06 11:52:01 +01:00
Simon Tischer 90b36f64c0 thermal/netstatus/memusage/cpumonitor - allow setting to open although the popup is visible
Reviewers: devilhorns, raster

Reviewed By: raster

Subscribers: netstar, cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D11639
2020-04-06 10:28:12 +01:00
Simon Tischer 66f0eb79b1 Wallpaper Selector - add button for online themes/wallpapers using extra (extra.e.org) also for advanced
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11648
2020-04-04 15:19:36 -04:00
Simon Tischer 8194f7c663 cpuclock - allow setting to open although the popup is visible
Reviewers: devilhorns, raster

Subscribers: cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D11633
2020-04-03 10:24:12 +01:00
Alastair Poole b320eda808 emixer.png: install in correct place.
Icon not displaying. Install in hicolor as per FDO.
2020-04-02 18:21:38 +01:00
Carsten Haitzler 54847302cc printf-- 2020-04-01 20:47:42 +01:00
Carsten Haitzler 64f87877a6 fix pointer offset fpor older themes
fixes T8622

so due rto optimizations in edje it no longer moves/resizes invsible
parts, so swallow a rect and it wont have moved if it is not visible
thus tracking its geometry by getting the geometry of the swallowed
part only works if its visible, so get the part geom from edje instead
which has to give the calculated geom.
2020-04-01 20:12:15 +01:00
Simon Tischer 43ed98beff Wallpaper/Theme Selector - add button for online themes/wallpapers using extra (extra.e.org)
Reviewers: devilhorns, raster

Reviewed By: raster

Subscribers: ProhtMeyhet, raster, cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D11561
2020-03-29 11:16:46 +01:00
Carsten Haitzler 6435e9a075 emixer - desktop - limit groups to one only and only show in e 2020-03-25 17:11:32 +00:00
Carsten Haitzler 0a4b0962b6 dont segv on shelf settings dialog closing beofre shelf content
fixes T8635
2020-03-22 14:33:22 +00:00
Mike Blumenkrantz a08304fdd0 update gadget runner smart events to stable api
the legacy events here are no longer emitted

fix T8633
2020-03-19 10:56:10 -04:00
Christopher Michael d85d0194a9 e_gadget: Check for valid gadget config before trying to remove it
Should fix crash when trying to add a gadget to a gadget bar

https://nopaste.linux-dev.org/?1295161
2020-03-18 13:28:52 -04:00
Carsten Haitzler 385d26d961 systray - add a little logging and explicit stupid checks 2020-03-15 20:53:18 +00:00
Carsten Haitzler 1fdaa2a113 systray - handle other non conforming notifier clients
serviceshould be org.xxxx or whatever... some do /org/... some do
:1.89 and some comply with the std... so be more forgiving...
2020-03-15 20:43:34 +00:00
Mike Blumenkrantz 0cce17f3cc final gadget runner efl.canvas.wl api update 2020-03-13 12:19:39 -04:00
Mike Blumenkrantz b80ddda9fb update gadget runner to (stabilized) efl api
efl-wl -> efl-canvas-wl
2020-03-12 12:15:42 -04:00
maxerba 9764dd76a7 Updating french translation 2020-03-11 17:56:53 +01:00
Carsten Haitzler 4368916c2c e theme - fix leak of list of stringshares and be paranoid about strings
what if the list contains strings that are not sub-paths for some
reason? check lenghts at least are big enough...
2020-03-09 15:27:58 +00:00
Carsten Haitzler 381c12bd19 cleared widgets handle part 2 2020-03-08 12:28:09 +00:00
Carsten Haitzler b22831fb30 efm/widget robustness - handle cleared or invalid widgets 2020-03-08 12:27:02 +00:00
Carsten Haitzler 4a69f273fa shot - typo in tool shadow. fix to have right mirror flip 2020-03-07 18:34:04 +00:00
Carsten Haitzler 3a3257e789 personal app editor - force size up to be sanely sized for use 2020-02-18 10:55:45 +00:00
Carsten Haitzler a3ae1b0ac2 e auth - use our memclear and fill it out with modern zeroing methods
so memset_s still doesn't get detected (add a check anyway), but there
are other alternatives, so detect and use them if found
(explicit_bzero, explicit_memset) in addition to the generally
"practically works" memset ptr method we had and.. just to be extra
safe add an asm memory barrier to this fallback. also.. mlock the
passwd memory in lokker (if it doesn't work - don't worry - there is
nothing we can do, so we did our best) to avoid this memory gettign
swapped etc.
2020-02-18 10:29:43 +00:00
Carsten Haitzler 276eb5b091 pager - remove unsued vars from segv fix 2020-02-16 12:45:26 +00:00
Carsten Haitzler 20aaa9464b pager - new gad - fix segv on vdesk size config change
match old pager gadget logic as it's happy to not crash when the
virtual desktop count config changes

@fix
2020-02-16 01:18:23 +00:00
Carsten Haitzler 4fcd1a989c e - scale pointer by scale factor properly... 2020-02-15 15:33:02 +00:00
Carsten Haitzler d524673f96 e system ddc - add optional sleep multiplier api - new in libddc
add ability to find it at any rate...
2020-02-14 11:02:42 +00:00
Carsten Haitzler 8f535e523f backlight - removed useless bits of backlight config dialog
unused or not useful or commented out code - remove.
2020-02-13 18:21:40 +00:00
Christopher Michael a8afd46a82 e_main: Remove unused variables 2020-02-13 12:13:42 -05:00
Carsten Haitzler 71cbbeff27 e start - clean up xdg runtime dir in e_start not e if created in estart 2020-02-13 16:06:44 +00:00
Carsten Haitzler eba37f40a6 backlight - on get fails, also retry a few times
so sometimes i see gets fail, especially on wakeup, so retry.
2020-02-10 08:09:47 +00:00
Carsten Haitzler 346969eb90 todo - add magnifier 2020-02-09 13:59:12 +00:00
Carsten Haitzler 559a7737a7 e sytem - dont add null hash items 2020-02-08 09:52:39 +00:00
Carsten Haitzler fcacbe8a4f ddc - work around some probe fails, missing timer handle, etc.
beating on ddc support to make it solid. dealing with some bad screens
that don't respond, a libddcutil that was doing a printf messing up
the message stream from e_system to e .... and more.
2020-02-07 19:56:01 +00:00
Carsten Haitzler d7325c3aad ddc - use return val of system to decide to usleep or not 2020-02-07 13:36:09 +00:00
Carsten Haitzler 78b73fb1a7 when backlight devices change, ensure they are restored to normal level
this ensures things like on login e setsup backlights fine - also on
monitor add/plug-in as when e's backlight init happens it may not see
all screens or devices yet.
2020-02-07 10:49:15 +00:00
Carsten Haitzler ee59cec585 ddc - add small delay after modprobe to allow module to init in bg... 2020-02-07 10:48:54 +00:00