Commit Graph

16 Commits

Author SHA1 Message Date
Elyes HAOUAS f47d1a789e tree-wide: get rid of trailing whitespace (part 6)
Remove trailing whitespaces

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11825
2020-05-14 13:49:18 +02:00
Simon Tischer 19fe001f4f Backlight Gadget slider fixes
Summary:
What i have done:

  - Open slider will update using mouse wheel over light bulb
  - Open slider will update using keybindings
  - Slider shows now a value between 1 and 100 (no double value is displayed anymore)
  - Removed unnecessary code for shelf module
  - removed code for buggy popup using keybindings (may add later an option for showing popup on backlight change)

I am still learning. please consider :)

Greetings Simon

Reviewers: bu5hm4n, morlenxus, devilhorns, raster

Subscribers: cedric, zmike

Tags: #enlightenment-git

Differential Revision: https://phab.enlightenment.org/D11065
2020-02-06 14:18:53 +00:00
Carsten Haitzler 37f32ac73a backlight - new gad - use zone of gadget not current zone
this is correct and maatches the shelf gadget code that always uses
the zone of the shelf not "current zone" for backlight control.
2020-02-03 10:29:21 +00:00
Carsten Haitzler e4339f4819 bryce - improve usability from code and user by having std right menu
now right click on any gagdte in bryce and they ALL have a menu that
allows removal of the gagdte bar or the gadget as well as access to
gadget settings AND the ability for gadgets to extendthis menu like
lunhcer does per icon. now it's standard behavior everywhere which is
much easier to use and discover. it also removes code from every
gadget to do their own "button 3" handling as its handled centrally
making the code in gadgets simpler.

this is part of my effort to improve usability (mostly discoverability
and accessibility of settings/features).

also  long press left mouse gets u gadget right click menu

this has to move many modules/gadgets actions to mouse up instead of
mouse down so the bryce has a chance to trap the events first and set
hold flags. but now long press for 0.5 sec and bryce menu come sup
(with left mouse .. so touch friendly).

in addition move context menu hanbdling to e_gadget instead of in
bryce and in e_gadget. a context callback is called so different
systems can still do different things. this should probably change to
always pop up a mnenu and simple call populate callbacks for site
owner specific content.

all in all it makes the new gagdtes more consistent, easier to use
(without a right mouse button), doesn't need special action bindings
etc. etc.
2018-10-11 16:25:10 +01:00
Mike Blumenkrantz b5e75eb264 formatting
lot of mixed spaces/tabs here made the code unreadable
2017-08-29 15:32:18 -04:00
Stephen 'Okra' Houston ad46d041a8 Gadgets: Don't set gadgets to expand. 2017-08-23 09:55:59 -05:00
Stephen 'Okra' Houston c3ae81586c Backlight: Don't add del callback for demo gadgets. 2017-08-22 18:18:57 -05:00
Stephen 'Okra' Houston 0332eca3c7 Mixer Gadget: Use demo gadget in places where demo gadgets are used. 2017-08-22 11:54:52 -05:00
Stephen 'Okra' Houston 062664d839 Backlight: Use a static number for demo purposes. 2017-08-22 11:10:48 -05:00
Stephen 'Okra' Houston 0b6c8a4d91 Backlight Gadget: No need for a settings button as the uniform right click does the same. 2017-07-13 11:12:58 -05:00
Stephen 'Okra' Houston 9894726039 Gadgets: Clamp aspect sets to a minimum of width and height minimum of 1.
This fixes T5600
2017-07-06 14:16:00 -05:00
Stephen 'Okra' Houston 202bf770f4 Gadgets: Follow gadget theme naming conventions. 2017-07-06 12:20:53 -05:00
Stephen 'Okra' Houston e5c337abfb Mixer/Backlight: Set correct levels on creation.
This fixes T5500
2017-05-19 10:52:18 -05:00
Stephen 'Okra' Houston 9d0bcd9ce2 Gadgets: Send proper theme strings, and set aspect/size correctly. 2017-05-12 15:38:45 -05:00
Stephen 'Okra' Houston ac2c9a220f Backlight Gadget: Properly set on hold events. 2017-05-12 09:57:48 -05:00
Stephen 'Okra' Houston 20f94cec74 Bryce/Gadgets: Add backlight, xkbswitch, and mixer gadgets. This should round out the core gadget ports.
All three of these gadgets are ports of the existing modules of the same name and are contained within those directories.  Once the move from shelves -> bryce and gadcon->gadgets is complete, backlight and mixer will likely need to go into the sysinfo gadget.
2017-05-11 17:13:15 -05:00