timer23
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

elm/hoversel: reduce sizing_eval calcs 

this doesn't need to be emitting signals or recalculating the box on
every sizing eval; signals are emitted naturally during the eval, and
the box (and its items) can be calculated only during activation since there
will be no post-activation changes there, as hoversel lacks a group_calc
implementation to handle such things anyway

Differential Revision: https://phab.enlightenment.org/D11645
This commit is contained in:
Mike Blumenkrantz 2020-04-03 11:32:35 -04:00
parent 6231c47319
commit 1e766c2757
1 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/lib/elementary/elc_hoversel.c
View File

@ -238,8 +238,6 @@ static void
_sizing_eval(void *data)
{
Evas_Object *obj = data;
Elm_Object_Item *eo_item;
const Eina_List *l;
const char *max_size_str;
int max_size = 0;
char buf[128];
@ -254,16 +252,6 @@ _sizing_eval(void *data)
if ((!sd->expanded) || (!sd->bx)) return;
elm_layout_signal_emit(sd->hover, "elm,state,align,default", "elm");
edje_object_message_signal_process(elm_layout_edje_get(sd->hover));
EINA_LIST_FOREACH(sd->items, l, eo_item)
{
ELM_HOVERSEL_ITEM_DATA_GET(eo_item, item);
efl_canvas_group_calculate(VIEW(item));
}
elm_box_recalculate(sd->bx);
evas_object_size_hint_combined_min_get(sd->bx, &box_w, &box_h);
max_size_str = elm_layout_data_get(sd->hover, "max_size");
@ -283,8 +271,6 @@ _sizing_eval(void *data)
adjusted.w = box_w;
adjusted.h = (max_size > 0) ? MIN(box_h, max_size) : box_h ;
}
evas_object_size_hint_min_set(sd->spacer, adjusted.w, adjusted.h);
if (!sd->last_location)
sd->last_location = elm_hover_best_content_location_get(sd->hover, !sd->horizontal + 1);
@ -510,7 +496,10 @@ _activate(Evas_Object *obj)
ELM_HOVERSEL_ITEM_DATA_GET(eo_item, item);
evas_object_show(VIEW(item));
elm_box_pack_end(sd->bx, VIEW(item));
if (efl_canvas_group_need_recalculate_get(VIEW(item)))
efl_canvas_group_calculate(VIEW(item));
}
elm_box_recalculate(sd->bx);
_create_scroller(obj, sd);
elm_object_content_set(sd->scr, sd->bx);