vtorri
/
enlightenment
forked from enlightenment/enlightenment
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use strncpy instead of strcpy 

Even though a user has to be stupid to trigger this, strncpy should be
used if not to much hassle :)
This commit is contained in:
Sebastian Dransfeld 2013-12-07 21:47:42 +01:00
parent 7542ddef4c
commit 0c4131d1be
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/bin/e_utils.c
View File

@ -163,19 +163,19 @@ e_util_head_exec(int head, const char *cmd)
/* yes it could overflow... but who will overflow DISPLAY eh? why? to
* "exploit" your own applications running as you?
*/
strcpy(buf, penv_display);
strncpy(buf, penv_display, sizeof(buf));
buf[p2 - penv_display + 1] = 0;
snprintf(buf2, sizeof(buf2), "%i", head);
strcat(buf, buf2);
}
else if (p1) /* "blah:x */
{
strcpy(buf, penv_display);
strncpy(buf, penv_display, sizeof(buf));
snprintf(buf2, sizeof(buf2), ".%i", head);
strcat(buf, buf2);
}
else
strcpy(buf, penv_display);
strncpy(buf, penv_display, sizeof(buf));
ok = 1;
exe = ecore_exe_run(cmd, NULL);