From 3fdcc92ab0f9a48c6333dc1d8b4dbe4900c86f5f Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Fri, 30 Jun 2017 10:25:23 -0400 Subject: [PATCH] check exit status from auth subprocess if the process doesn't exit then auth didn't succeed and this is a system issue ref T5604 --- src/modules/lokker/lokker.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modules/lokker/lokker.c b/src/modules/lokker/lokker.c index b009093fd..cdec4d1db 100644 --- a/src/modules/lokker/lokker.c +++ b/src/modules/lokker/lokker.c @@ -570,14 +570,14 @@ _lokker_cb_exit(void *data EINA_UNUSED, int type EINA_UNUSED, void *event) _auth_child_pid = -1; /* ok */ - if (ev->exit_code == 0) + if (ev->exited && (ev->exit_code == 0)) { /* security - null out passwd string once we are done with it */ _lokker_null(); e_desklock_hide(); } /* error */ - else if (ev->exit_code < 128) + else if ((!ev->exited) || (ev->exit_code < 128)) { /* security - null out passwd string once we are done with it */ _lokker_null(); @@ -586,7 +586,7 @@ _lokker_cb_exit(void *data EINA_UNUSED, int type EINA_UNUSED, void *event) _("Authentication via PAM had errors setting up the
" "authentication session. The error code was %i.
" "This is bad and should not be happening. Please report this bug.") - , ev->exit_code); + , ev->exited ? ev->exit_code : ev->exit_signal); } /* failed auth */ else