vtorri
/
enlightenment
forked from enlightenment/enlightenment
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

NEVER, EVER should modify the stringshared pointer. 

That is why stringshare returns "const char*".

ZMike, pay attention to these cases. I know this one was particularly
nasty to spot since you receive the "const char *path", but later on
you request strrchr(path..) and receive "char *p", the cast is done
implicitly by libC to make all the case works (C++ version fixed this
recently, but in C there is no way).

The crash that lead me to investigate it was spot by Lucas De Marchi
at advanced wallpaper dialog, but actually other places that uses efm
should be equaly broken.



SVN revision: 48508
This commit is contained in:
Gustavo Sverzut Barbieri 2010-05-01 16:02:03 +00:00
parent 46ada2a38b
commit 4cd34cc5e8
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/bin/e_fm.c
View File

@ -1304,15 +1304,14 @@ EAPI void
e_fm2_parent_go(Evas_Object *obj)
{
E_Fm2_Smart_Data *sd;
char *p;
const char *path;
char *p, *path;
sd = evas_object_smart_data_get(obj);
if (!sd) return; // safety
if (!evas_object_type_get(obj)) return; // safety
if (strcmp(evas_object_type_get(obj), "e_fm")) return; // safety
if (!sd->path) return;
path = eina_stringshare_add(sd->path);
path = strdup(sd->path);
if (!path) return;
if ((p = strrchr(path, '/'))) *p = 0;
if (*path == 0)
@ -1320,7 +1319,7 @@ e_fm2_parent_go(Evas_Object *obj)
else
e_fm2_path_set(obj, sd->dev, path);
eina_stringshare_del(path);
free(path);
}
EAPI void