From 51fe04e6ed15578719a2f1a4d03400a065087f73 Mon Sep 17 00:00:00 2001 From: Marcel Hollerbach Date: Fri, 21 Nov 2014 10:26:54 -0500 Subject: [PATCH] wizard: Fix the resolving of the FIXME comment Summary: Commit rE5b992bdc4a76 added the free for the list, the list is filed with static pointers from the .c file, soo free will crash. This pointer does not need to be freed, just freeing the list. Test Plan: Just run the wizard Reviewers: zmike Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D1679 --- src/modules/wizard/page_010.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/modules/wizard/page_010.c b/src/modules/wizard/page_010.c index 774a24cf5..da9059597 100644 --- a/src/modules/wizard/page_010.c +++ b/src/modules/wizard/page_010.c @@ -145,7 +145,12 @@ wizard_page_init(E_Wizard_Page *pg __UNUSED__, Eina_Bool *need_xdg_desktops __UN EAPI int wizard_page_shutdown(E_Wizard_Page *pg __UNUSED__) { - E_FREE_LIST(blang_list, free); + void *_tmp; + EINA_LIST_FREE(blang_list, _tmp) + { + // we dont need to free _tmp cause this is just a pointer to the basic_language_predefined_pairs + // array. a free will end up in a crash + } return 1; }