vtorri
/
enlightenment
forked from enlightenment/enlightenment
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

e hints - fix beyond end of array fetch and segv 

asan found this one.

@fix
This commit is contained in:
Carsten Haitzler 2019-08-10 13:34:32 +01:00
parent 9ee7f38659
commit 67da43ee36
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/bin/e_hints.c
View File

@ -681,7 +681,7 @@ e_hints_window_type_get(E_Client *ec)
(void)ec;
#else
Ecore_X_Window_Type *types = NULL;
int num, i, j;
int num, i, j, k;
if (!e_client_has_xwindow(ec)) return;
num = ecore_x_netwm_window_types_get(e_client_util_win_get(ec), &types);
@ -701,8 +701,8 @@ e_hints_window_type_get(E_Client *ec)
while ((j < num) &&
(ec->netwm.type == E_WINDOW_TYPE_UNKNOWN))
{
j++;
ec->netwm.type = types[j];
j++;
}
if (num > j)
{
@ -710,8 +710,8 @@ e_hints_window_type_get(E_Client *ec)
malloc((num - j) * sizeof(Ecore_X_Window_Type));
if (ec->netwm.extra_types)
{
for (i = j + 1; i < num; i++)
ec->netwm.extra_types[i - (j + 1)] = types[i];
for (i = j, k = 0; i < num; i++, k++)
ec->netwm.extra_types[k] = types[i];
ec->netwm.extra_types_num = num - j;
}
}